From c3f93af9b8e948e459339d363e81630629923fbf Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Mon, 10 Mar 2025 01:18:32 +0100 Subject: [PATCH] DefaultCoinSelector: in compareByDepth() compare transaction hashes directly Before this change, it was converting them to BigInteger. --- .../main/java/org/bitcoinj/wallet/DefaultCoinSelector.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/wallet/DefaultCoinSelector.java b/core/src/main/java/org/bitcoinj/wallet/DefaultCoinSelector.java index ee0a575bb..d01b518b1 100644 --- a/core/src/main/java/org/bitcoinj/wallet/DefaultCoinSelector.java +++ b/core/src/main/java/org/bitcoinj/wallet/DefaultCoinSelector.java @@ -19,6 +19,7 @@ package org.bitcoinj.wallet; import org.bitcoinj.base.BitcoinNetwork; import org.bitcoinj.base.Coin; import org.bitcoinj.base.Network; +import org.bitcoinj.base.Sha256Hash; import org.bitcoinj.core.Transaction; import org.bitcoinj.core.TransactionConfidence; import org.bitcoinj.core.TransactionOutput; @@ -91,8 +92,8 @@ public class DefaultCoinSelector implements CoinSelector { int c2 = bValue.compareTo(aValue); if (c2 != 0) return c2; // They are entirely equivalent (possibly pending) so sort by hash to ensure a total ordering. - BigInteger aHash = a.getParentTransactionHash().toBigInteger(); - BigInteger bHash = b.getParentTransactionHash().toBigInteger(); + Sha256Hash aHash = a.getParentTransactionHash(); + Sha256Hash bHash = b.getParentTransactionHash(); return aHash.compareTo(bHash); };