Preconditions: add generic check() that allows to supply a custom exception

Also adds tests.
This commit is contained in:
Andreas Schildbach 2023-03-17 10:46:19 +01:00
parent 80178c011c
commit 31123bea3d
2 changed files with 45 additions and 7 deletions

View File

@ -25,8 +25,7 @@ public class Preconditions {
* @throws IllegalArgumentException if {@code expression} is false * @throws IllegalArgumentException if {@code expression} is false
*/ */
public static void checkArgument(boolean expression) { public static void checkArgument(boolean expression) {
if (!expression) check(expression, IllegalArgumentException::new);
throw new IllegalArgumentException();
} }
/** /**
@ -36,8 +35,7 @@ public class Preconditions {
* @throws IllegalArgumentException if {@code expression} is false * @throws IllegalArgumentException if {@code expression} is false
*/ */
public static void checkArgument(boolean expression, Supplier<String> messageSupplier) { public static void checkArgument(boolean expression, Supplier<String> messageSupplier) {
if (!expression) check(expression, () -> new IllegalArgumentException(messageSupplier.get()));
throw new IllegalArgumentException(messageSupplier.get());
} }
/** /**
@ -47,8 +45,7 @@ public class Preconditions {
* @throws IllegalStateException if {@code expression} is false * @throws IllegalStateException if {@code expression} is false
*/ */
public static void checkState(boolean expression) { public static void checkState(boolean expression) {
if (!expression) check(expression, IllegalStateException::new);
throw new IllegalStateException();
} }
/** /**
@ -59,7 +56,17 @@ public class Preconditions {
* @throws IllegalStateException if {@code expression} is false * @throws IllegalStateException if {@code expression} is false
*/ */
public static void checkState(boolean expression, Supplier<String> messageSupplier) { public static void checkState(boolean expression, Supplier<String> messageSupplier) {
check(expression, () -> new IllegalStateException(messageSupplier.get()));
}
/**
* Ensures the truth of an expression, throwing a custom exception if untrue.
* @param expression a boolean expression
* @param exceptionSupplier supplier of the exception to be thrown
* @throws X if {@code expression} is false
*/
public static <X extends Throwable> void check(boolean expression, Supplier<? extends X> exceptionSupplier) throws X {
if (!expression) if (!expression)
throw new IllegalStateException(messageSupplier.get()); throw exceptionSupplier.get();
} }
} }

View File

@ -0,0 +1,31 @@
/*
* Copyright by the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.bitcoinj.base.internal;
import org.junit.Test;
public class PreconditionsTest {
@Test
public void check_true() {
Preconditions.check(true, ArithmeticException::new);
}
@Test(expected = ArithmeticException.class)
public void check_false() {
Preconditions.check(false, ArithmeticException::new);
}
}