From 30dec4ff7cb556690b7ad5c70bf7c3b9c16429c4 Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Wed, 22 Mar 2023 21:39:05 +0100 Subject: [PATCH] Message: replace `readBytes(1)[0]` with `readByte()` --- core/src/main/java/org/bitcoinj/core/BloomFilter.java | 2 +- core/src/main/java/org/bitcoinj/core/RejectMessage.java | 2 +- core/src/main/java/org/bitcoinj/core/VersionMessage.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/core/BloomFilter.java b/core/src/main/java/org/bitcoinj/core/BloomFilter.java index bc2422f9f..acb92d81b 100644 --- a/core/src/main/java/org/bitcoinj/core/BloomFilter.java +++ b/core/src/main/java/org/bitcoinj/core/BloomFilter.java @@ -155,7 +155,7 @@ public class BloomFilter extends Message { if (hashFuncs > MAX_HASH_FUNCS) throw new ProtocolException("Bloom filter hash function count out of range"); nTweak = readUint32(); - nFlags = readBytes(1)[0]; + nFlags = readByte(); } /** diff --git a/core/src/main/java/org/bitcoinj/core/RejectMessage.java b/core/src/main/java/org/bitcoinj/core/RejectMessage.java index c37115f38..e8c873d5d 100644 --- a/core/src/main/java/org/bitcoinj/core/RejectMessage.java +++ b/core/src/main/java/org/bitcoinj/core/RejectMessage.java @@ -96,7 +96,7 @@ public class RejectMessage extends Message { @Override protected void parse() throws ProtocolException { message = readStr(); - code = RejectCode.fromCode(readBytes(1)[0]); + code = RejectCode.fromCode(readByte()); reason = readStr(); if (message.equals("block") || message.equals("tx")) messageHash = readHash(); diff --git a/core/src/main/java/org/bitcoinj/core/VersionMessage.java b/core/src/main/java/org/bitcoinj/core/VersionMessage.java index bb97c34b2..197a56a4b 100644 --- a/core/src/main/java/org/bitcoinj/core/VersionMessage.java +++ b/core/src/main/java/org/bitcoinj/core/VersionMessage.java @@ -144,7 +144,7 @@ public class VersionMessage extends Message { // int bestHeight (size of known block chain). bestHeight = readUint32(); if (clientVersion >= params.getProtocolVersionNum(NetworkParameters.ProtocolVersion.BLOOM_FILTER)) { - relayTxesBeforeFilter = readBytes(1)[0] != 0; + relayTxesBeforeFilter = readByte() != 0; } else { relayTxesBeforeFilter = true; }