From 0de458db4573aff218840f4075babde4236d144b Mon Sep 17 00:00:00 2001
From: Kirill Vlasov <kirill.vlasov@devfactory.com>
Date: Mon, 7 Dec 2015 12:14:07 +0500
Subject: [PATCH] Strings literals should be placed on the left side when
 checking for equality

---
 core/src/main/java/org/bitcoinj/core/RejectMessage.java   | 2 +-
 .../org/bitcoinj/protocols/payments/PaymentProtocol.java  | 8 ++++----
 .../main/java/org/bitcoinj/tools/PaymentProtocolTool.java | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/core/src/main/java/org/bitcoinj/core/RejectMessage.java b/core/src/main/java/org/bitcoinj/core/RejectMessage.java
index 208da6df9..f09566635 100644
--- a/core/src/main/java/org/bitcoinj/core/RejectMessage.java
+++ b/core/src/main/java/org/bitcoinj/core/RejectMessage.java
@@ -101,7 +101,7 @@ public class RejectMessage extends Message {
         byte[] reasonBytes = reason.getBytes("UTF-8");
         stream.write(new VarInt(reasonBytes.length).encode());
         stream.write(reasonBytes);
-        if (message.equals("block") || message.equals("tx"))
+        if ("block".equals(message) || "tx".equals(message))
             stream.write(messageHash.getReversedBytes());
     }
 
diff --git a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java
index 8fafed63a..4483c9a4b 100644
--- a/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java
+++ b/core/src/main/java/org/bitcoinj/protocols/payments/PaymentProtocol.java
@@ -136,7 +136,7 @@ public class PaymentProtocol {
             final Protos.PaymentRequest paymentRequestToSign = paymentRequest.build();
 
             final String algorithm;
-            if (privateKey.getAlgorithm().equalsIgnoreCase("RSA"))
+            if ("RSA".equalsIgnoreCase(privateKey.getAlgorithm()))
                 algorithm = "SHA256withRSA";
             else
                 throw new IllegalStateException(privateKey.getAlgorithm());
@@ -166,14 +166,14 @@ public class PaymentProtocol {
         List<X509Certificate> certs = null;
         try {
             final String pkiType = paymentRequest.getPkiType();
-            if (pkiType.equals("none"))
+            if ("none".equals(pkiType))
                 // Nothing to verify. Everything is fine. Move along.
                 return null;
 
             String algorithm;
-            if (pkiType.equals("x509+sha256"))
+            if ("x509+sha256".equals(pkiType))
                 algorithm = "SHA256withRSA";
-            else if (pkiType.equals("x509+sha1"))
+            else if ("x509+sha1".equals(pkiType))
                 algorithm = "SHA1withRSA";
             else
                 throw new PaymentProtocolException.InvalidPkiType("Unsupported PKI type: " + pkiType);
diff --git a/tools/src/main/java/org/bitcoinj/tools/PaymentProtocolTool.java b/tools/src/main/java/org/bitcoinj/tools/PaymentProtocolTool.java
index 0bbb9a6c0..cfefdcd43 100644
--- a/tools/src/main/java/org/bitcoinj/tools/PaymentProtocolTool.java
+++ b/tools/src/main/java/org/bitcoinj/tools/PaymentProtocolTool.java
@@ -55,9 +55,9 @@ public class PaymentProtocolTool {
                 Protos.PaymentRequest request = Protos.PaymentRequest.parseFrom(stream);
                 stream.close();
                 session = new PaymentSession(request);
-            } else if (uri.getScheme().equals("http")) {
+            } else if ("http".equals(uri.getScheme())) {
                 session = PaymentSession.createFromUrl(arg).get();
-            } else if (uri.getScheme().equals("bitcoin")) {
+            } else if ("bitcoin".equals(uri.getScheme())) {
                 BitcoinURI bcuri = new BitcoinURI(arg);
                 final String paymentRequestUrl = bcuri.getPaymentRequestUrl();
                 if (paymentRequestUrl == null) {