From 0cb686481fabebaec57254da3e44973f225163e3 Mon Sep 17 00:00:00 2001 From: Sean Gilligan Date: Mon, 6 Sep 2021 15:55:56 -0700 Subject: [PATCH] Block: Fix JavaDoc comment on EASIEST_DIFFICULTY_TARGET MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It said “half of all possible hash solutions” which led me to believe that decodeCompactBits() would extend 1’s all the way out to the least significant bit. --- core/src/main/java/org/bitcoinj/core/Block.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/org/bitcoinj/core/Block.java b/core/src/main/java/org/bitcoinj/core/Block.java index 4b13411b0..d1d6ca4dc 100644 --- a/core/src/main/java/org/bitcoinj/core/Block.java +++ b/core/src/main/java/org/bitcoinj/core/Block.java @@ -75,7 +75,7 @@ public class Block extends Message { */ public static final int MAX_BLOCK_SIGOPS = MAX_BLOCK_SIZE / 50; - /** A value for difficultyTarget (nBits) that allows half of all possible hash solutions. Used in unit testing. */ + /** A value for difficultyTarget (nBits) that allows (slightly less than) half of all possible hash solutions. Used in unit testing. */ public static final long EASIEST_DIFFICULTY_TARGET = 0x207fFFFFL; /** Value to use if the block height is unknown */