From dd3c8eaa3399b28dc78a883ff78cbe7cc5c31b5b Mon Sep 17 00:00:00 2001
From: Jarol Rodriguez <jarolrod@tutanota.com>
Date: Tue, 6 Apr 2021 17:54:29 -0400
Subject: [PATCH] rpc: swap position of banned_until and ban_created fields

A ban expires after its creation. Therefore, for the listbanned RPC,
position banned_until after ban_created in help and output.
---
 src/rpc/net.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rpc/net.cpp b/src/rpc/net.cpp
index 96533a50c84..41e5ea1c6c1 100644
--- a/src/rpc/net.cpp
+++ b/src/rpc/net.cpp
@@ -750,8 +750,8 @@ static RPCHelpMan listbanned()
                 {RPCResult::Type::OBJ, "", "",
                     {
                         {RPCResult::Type::STR, "address", ""},
-                        {RPCResult::Type::NUM_TIME, "banned_until", ""},
                         {RPCResult::Type::NUM_TIME, "ban_created", ""},
+                        {RPCResult::Type::NUM_TIME, "banned_until", ""},
                     }},
             }},
                 RPCExamples{
@@ -774,8 +774,8 @@ static RPCHelpMan listbanned()
         const CBanEntry& banEntry = entry.second;
         UniValue rec(UniValue::VOBJ);
         rec.pushKV("address", entry.first.ToString());
-        rec.pushKV("banned_until", banEntry.nBanUntil);
         rec.pushKV("ban_created", banEntry.nCreateTime);
+        rec.pushKV("banned_until", banEntry.nBanUntil);
 
         bannedAddresses.push_back(rec);
     }