From 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 Mon Sep 17 00:00:00 2001 From: practicalswift Date: Fri, 6 Dec 2019 13:22:04 +0000 Subject: [PATCH] tests: Use a default of supports_cli=True (instead of supports_cli=False) --- test/functional/create_cache.py | 1 - test/functional/rpc_deriveaddresses.py | 1 - test/functional/test_framework/test_framework.py | 2 +- test/functional/wallet_createwallet.py | 1 - test/functional/wallet_multiwallet.py | 1 - test/functional/wallet_watchonly.py | 1 - 6 files changed, 1 insertion(+), 6 deletions(-) diff --git a/test/functional/create_cache.py b/test/functional/create_cache.py index edf16fa47e4..16a791177b6 100755 --- a/test/functional/create_cache.py +++ b/test/functional/create_cache.py @@ -16,7 +16,6 @@ class CreateCache(BitcoinTestFramework): def set_test_params(self): self.num_nodes = 0 - self.supports_cli = True def setup_network(self): pass diff --git a/test/functional/rpc_deriveaddresses.py b/test/functional/rpc_deriveaddresses.py index 42128d57670..42d7d59d563 100755 --- a/test/functional/rpc_deriveaddresses.py +++ b/test/functional/rpc_deriveaddresses.py @@ -10,7 +10,6 @@ from test_framework.util import assert_equal, assert_raises_rpc_error class DeriveaddressesTest(BitcoinTestFramework): def set_test_params(self): self.num_nodes = 1 - self.supports_cli = 1 def run_test(self): assert_raises_rpc_error(-5, "Missing checksum", self.nodes[0].deriveaddresses, "a") diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py index f468f9eaec5..a17e7709f29 100755 --- a/test/functional/test_framework/test_framework.py +++ b/test/functional/test_framework/test_framework.py @@ -97,7 +97,7 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass): self.nodes = [] self.network_thread = None self.rpc_timeout = 60 # Wait for up to 60 seconds for the RPC server to respond - self.supports_cli = False + self.supports_cli = True self.bind_to_localhost_only = True self.set_test_params() self.parse_args() diff --git a/test/functional/wallet_createwallet.py b/test/functional/wallet_createwallet.py index e302e499f46..048b3127ff1 100755 --- a/test/functional/wallet_createwallet.py +++ b/test/functional/wallet_createwallet.py @@ -15,7 +15,6 @@ class CreateWalletTest(BitcoinTestFramework): def set_test_params(self): self.setup_clean_chain = False self.num_nodes = 1 - self.supports_cli = True def skip_test_if_missing_module(self): self.skip_if_no_wallet() diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py index ce0b7e87827..85d900f6cc6 100755 --- a/test/functional/wallet_multiwallet.py +++ b/test/functional/wallet_multiwallet.py @@ -24,7 +24,6 @@ class MultiWalletTest(BitcoinTestFramework): def set_test_params(self): self.setup_clean_chain = True self.num_nodes = 2 - self.supports_cli = True def skip_test_if_missing_module(self): self.skip_if_no_wallet() diff --git a/test/functional/wallet_watchonly.py b/test/functional/wallet_watchonly.py index be8d7714fba..b0c41b27380 100755 --- a/test/functional/wallet_watchonly.py +++ b/test/functional/wallet_watchonly.py @@ -16,7 +16,6 @@ class CreateWalletWatchonlyTest(BitcoinTestFramework): def set_test_params(self): self.setup_clean_chain = False self.num_nodes = 1 - self.supports_cli = True def skip_test_if_missing_module(self): self.skip_if_no_wallet()