From 232d1f92bb4c99ce0f5d210b17562c96c32ab61a Mon Sep 17 00:00:00 2001 From: Prayank Date: Sun, 17 Jan 2021 05:14:09 +0530 Subject: [PATCH] Add information to "Confirm fee bump" window Check if "Coin Control features" are enabled to display warning before broadcasting replacement transaction Workaround to fix issue: bitcoin/bitcoin#20795 Co-authored-by: Jon Atack --- src/qt/walletmodel.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qt/walletmodel.cpp b/src/qt/walletmodel.cpp index cad472b43bc..c99f861ccbf 100644 --- a/src/qt/walletmodel.cpp +++ b/src/qt/walletmodel.cpp @@ -514,6 +514,13 @@ bool WalletModel::bumpFee(uint256 hash, uint256& new_hash) questionString.append(""); questionString.append(BitcoinUnits::formatHtmlWithUnit(getOptionsModel()->getDisplayUnit(), new_fee)); questionString.append(""); + + // Display warning in the "Confirm fee bump" window if the "Coin Control Features" option is enabled + if (getOptionsModel()->getCoinControlFeatures()) { + questionString.append("

"); + questionString.append(tr("Warning: This may pay the additional fee by reducing change outputs or adding inputs, when necessary. It may add a new change output if one does not already exist. These changes may potentially leak privacy.")); + } + SendConfirmationDialog confirmationDialog(tr("Confirm fee bump"), questionString); confirmationDialog.exec(); QMessageBox::StandardButton retval = static_cast(confirmationDialog.result());