mirror of
https://github.com/bitcoin-s/bitcoin-s.git
synced 2025-01-19 05:43:51 +01:00
fb178eb295
* Add proper parsing of bitcoin.conf, remove datadir Somewhat recently a new config format was introduced in Bitcoin Core. Options can now be specified under section headers ([regtest], [main], [test]), as well as with network prefixes (regtest.rpcport, main.prune) and the traditional format. In this commit we introduce a new type BitcoindConfig that parses this format. We also make the necessary changes in the bitcoind/Eclair RPC clients to accomodate this new type. We also remove the datadir field from BitcoindAuthCredentials. This is not strictly necessary to connect to a bitcoind, so this is a bad separation of concerns. The datadir field is instead moved into the BitcoindInstance. Finally we go over some places in tests and test utils and assert that we are operating in the user temporary directory. This is a safety measure so that other developers/users won't do the same mistake I did while working on this and accidentally blow up their $HOME/.bitcoin directory. * Add BitcoindRpcClient.fromDatadir * Address code review from Chris |
||
|---|---|---|
| .. | ||
| src/main/scala/org/bitcoins/rpc | ||
| README.md | ||