Commit graph

1708 commits

Author SHA1 Message Date
Chris Stewart
effa0aab1f Add comments indicating what time unit eclair sends things in for the… (#884)
* Add comments indicating what time unit eclair sends things in for the various rpc calls

* Add missing comment

* Make sure time units returned by eclair rpc are correct
2019-11-26 12:25:45 -06:00
Scala Steward
e091040fa1 Update sbt to 1.3.4 (#889) 2019-11-24 09:01:49 -06:00
Chris Stewart
abffe5d7a9 Add sanity tests for .hashCode() and .equals() for multiple instances for EclairRpcClient/BitcoindRpcClient (#881) 2019-11-22 07:59:26 -06:00
rorp
14d3878d01 Rescan RPC (#854)
* Rescan RPC

* cleanup

* fix optional args

* cleanup

* unit tests

* fix build error

* fix unit tests

* scalaMock

* cleanup

* more unit tests

* some more validation checks
2019-11-21 08:03:32 -06:00
Nadav Kohen
40d2efd4aa MultiSignatureWithTimeoutScriptPubKey (#867)
* Added MultiSignatureWithTimeoutScriptPubKey

* Renamed If and NotIf to NonStandardIf and NonStandardNotIf and removed multiple representations

* Added MultiSignatureScriptPubKey to CreditingTxGenerators

* Responded to code review

* Fixed UTXOSpendingInfoTest
2019-11-18 15:08:50 -06:00
Chris Stewart
94161b718b Fix runnable not being cancelled when payment fails (#869) 2019-11-18 15:08:25 -06:00
Nadav Kohen
911541cf52 Made ScriptPubKey and ScriptSignature toStrings nicer (#859) 2019-11-18 11:12:38 -06:00
Nadav Kohen
fb2188b7d8 OP_NOTIF ScriptPubKey and Signing (#858)
* Implemented OP_NOTIF

* Responded to code review

* Fixed test bug for sampling
2019-11-18 10:45:33 -06:00
Nadav Kohen
ab00fffffc Conditional Signing Tests (#865)
* Added ConditionalScriptPubKeys to CreditingTxGen so that we are actually testing Conditional signing now

* Responded to code review

* Renamed scriptPubKeyTooBig => redeemScriptTooBig
2019-11-15 14:26:21 -06:00
Nadav Kohen
fad72c66d5 Increase some Test Coverage (#866)
* Added ScriptTypeTest

* Added ScriptSignature coverage

* Added Signer test coverage

* Added test coverage for UTXOSpendingInfo

* Responded to code review
2019-11-15 12:21:52 -06:00
Nadav Kohen
b80a46ca9a Nested OP_IF ScriptPubKey and signing (#857)
* Enabled nested conditional parsing

* Added nested conditionals to tests

* Responded to code review
2019-11-13 15:44:35 -06:00
Nadav Kohen
609f7e6ad6 ScriptInterpreter Conditional Refactor (#855)
* Redid conditional interpreting without binary trees

* Fixed ControlOperationsInterpreterTest

* Implemented O(1) conditional handling as proposed here https://github.com/bitcoin/bitcoin/pull/16902 because Ben Carman pointed it out

* Added some docs

* Responded to code review
2019-11-08 13:19:53 -06:00
rorp
7fcab8948a Fix monitorInvoice unit test (#846)
* Fix monitorInvoice unit test

* more logs

* even more logging

* fix build error

* custom eclair jar

* custom eclair

* more logging

* remove println's

* more logging

* more logging

* fix 'payment expiry is too close to the current block height'

* pobably the final fix

* cleanup

* fix download URL

* responded to PR comments
2019-11-06 12:42:38 -06:00
Nadav Kohen
f2081dfa46 OP_IF Signing (#827)
* Introduced ConditionalScriptPubKey

Some more progress

Added Conditional signing infrastracture, tests do not pass and there are no Conditional tests

Fixed tests!

* Redid calcLockTime and calcSequenceForInputs in TxBuilder (added Conditional support)

* Added ScriptGenerators for Conditional scripts, only one test to go!

* Fixed CLTV(Empty) tests

* Responded to code review

* responded to code review

* ScriptSignature only types Policy-compliant script signatures

* Fixed md doc
2019-11-05 18:48:50 -06:00
Chris Stewart
c22512a6ce Bump micro pickle/json to 0.8.0 (#853) 2019-11-05 15:13:54 -06:00
rorp
507a55fe90 Fix getsentinfo Eclair Rpc call (#851) 2019-11-04 12:33:44 -06:00
Scala Steward
f7c8825a4c Update flyway-sbt to 6.0.7 (#844) 2019-11-01 09:13:12 -05:00
Scala Steward
5b7d29e2ed Update scalacheck to 1.14.2 (#849) 2019-11-01 09:06:44 -05:00
Scala Steward
f22906dfad Update slf4j-api to 1.7.29 (#848) 2019-11-01 06:11:03 -05:00
Nadav Kohen
4a3677c009 RawScriptPubKey (#843)
* Introduced RawScriptPubKey type

* Responded to code review
2019-10-31 18:34:48 -05:00
Nadav Kohen
40ebc8e53e Replace scriptPubKeyToSatisfy with spendingInfoToSatisfy in Signer (#842)
* Replace scriptPubKeyToSatisfy with spendingInfoToSatisfy and made UTXOSpendingInfo ADT nicer

Tightened up types on Signer with a type parameter

Factored out common functionality in Signer

Responded to code review

* More review
2019-10-31 12:17:30 -05:00
Nadav Kohen
0c2bdafdf0 GCSTest fix (#845)
* Raised the min p value in GCSTest to avoid large x/2^p values which cause long unary to happen

* Lowered upper bound to 50
2019-10-31 06:21:23 -05:00
Nadav Kohen
c1d90c2305 Spending Info ADT use (#840)
* Replaced TxBuilder signAndAddInput match with UTXOSpendingInfo match, tests don't pass

* Fixed tests!
2019-10-30 15:00:41 -05:00
cwaldron97
96476e56b3 (WIP)Changes to client start() (#748)
* changes to client

fixed daemon flag

yielding bitcoindRPCclient

versioned

more implementation

update

fixed yield error and some documentation

docs + compiler error fix

updated

responding to code review

missing bracket

fixed compiler warnings

fixed compiler warning

* scalafmt
2019-10-30 14:59:35 -05:00
rorp
9062e1b0cc Rescan and fetch blocks (#835)
* Rescan and fetch blocks

* unit test

* fix log level

* addessed the PR comments

* fix test timeout

* improve unit tests
2019-10-30 09:51:03 -05:00
Scala Steward
a7064c7b57 Update sourcecode to 0.1.8 (#841) 2019-10-28 20:11:00 -05:00
Chris Stewart
d2cefd2b99 Revert "Update scalafmt-core to 2.2.1 (#833)" (#839)
This reverts commit a4b49b3be1.
2019-10-27 17:21:15 -05:00
Nadav Kohen
1b51ad689f Signer UTXOSpendingInfo refactor (#830)
* Refactored Signer interface to use TxSigComponent and UTXOSpendingInfo

Fixed all the broken things

Replaced TxSigComponent with unsigned Transaction in Signer interface to remove illegal states

* Added p2sh throw case in Signer
2019-10-25 15:40:33 -05:00
Chris Stewart
19783ea546 Revert "Update sbt-mdoc to 1.3.6 (#831)" (#837)
This reverts commit ae9f662532.
2019-10-25 10:32:27 -05:00
Scala Steward
a4b49b3be1 Update scalafmt-core to 2.2.1 (#833) 2019-10-25 08:56:48 -05:00
Scala Steward
ae9f662532 Update sbt-mdoc to 1.3.6 (#831) 2019-10-25 08:50:35 -05:00
Nadav Kohen
e924650ca1 Created LockTimeSigner and delegated LockTimeScriptSignature signing from other places to it (#798)
Remove redundant work on P2WPKH signing

Added scaladoc

Added to OverridesForNestedSigning for LockTime scripts nested in SHs
2019-10-25 06:15:55 -05:00
rorp
06d210ba80 Upgrade to ecalir v0.3.2 (#818)
* Upgrade to ecalir v0.3.2

* addressed the PR comments

* some more changes

* and some more

* external payment id
2019-10-24 13:19:59 -05:00
Scala Steward
a17a4d3673 Update sbt-bloop to 1.3.5 (#829) 2019-10-24 06:00:51 -05:00
Nadav Kohen
3960fbd0d1 P2WSH Signer! (#797)
* Created P2WSHSigner and removed P2WSHWitnessSPKV0 case from P2PK and P2PKH signers

* Moved P2WSH MultiSig from MultiSigSigner to P2WSHSigner

* Cleaned up P2WSH case of BitcoinTxBuilder.signAndAddInput to exclusively use P2WSHSigner

* Replaced Option[(TxSigComponent, ScriptPubKey)] with an ADT

* Added signing with overrides to super Signer class to simplify delegation code

* Added Scaladocs for OverridesForNestedSigning ADT

* Made naming better for OverridesForNestedSigning ADT and added scaladocs
2019-10-23 15:29:52 -05:00
rorp
57d37ba145 Improve EclairRpcClientTest execution time (#826) 2019-10-23 14:29:48 -05:00
Nadav Kohen
ec7bd7f51d Removed the ScriptProgram companion object (#811) 2019-10-23 10:12:41 -05:00
dependabot[bot]
b54c9d20ab Bump mixin-deep from 1.3.1 to 1.3.2 in /website (#822)
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
2019-10-23 07:19:03 -05:00
dependabot[bot]
ee81a026fc Bump lodash.merge from 4.6.1 to 4.6.2 in /website (#821)
Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2019-10-23 07:18:45 -05:00
Scala Steward
6f1db47e2c Update sttp:core to 1.7.2 (#808) 2019-10-22 14:25:45 -05:00
dependabot[bot]
fcecc968f5 Bump lodash from 4.17.11 to 4.17.15 in /website (#819)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>
2019-10-22 14:25:13 -05:00
Ben Carman
92f8fd96a0 Refactor old test cases to use BitcoinSUnitTest (#814) 2019-10-20 02:35:03 -05:00
Scala Steward
179b66cede Update akka-actor, akka-stream, ... to 2.5.26 (#817) 2019-10-20 01:54:12 -05:00
philbertw4
113edf8e96 quick fix of link to txbuilder examples in docs (#815) 2019-10-16 07:46:21 -05:00
Chris Stewart
62bb36928e Update script_tests.json, fix bugs that were unveiled with that updat… (#799)
* Update script_tests.json, fix bugs that were unveiled with that update. Specifically around handling negative zero in Script, and cleanstack behavior for segwit scripts. We were not checking for equality at the byte level for negative zero. With cleanstack, we were failing the script, but not failing with the correct error. If you look at interpreter.cpp in bitcoin core, cleanstack check is done before checking if the stacktop is true or false

* Address code review
2019-10-15 09:57:47 -05:00
rorp
6d050602ce Increase test coverage (#810)
* Increase test coverage

* more coverage
2019-10-14 19:54:34 -05:00
rorp
ce55897243 Create removed Neutrino tables (#796) 2019-10-14 14:42:59 -05:00
Scala Steward
cda13ebbdf Update sbt to 1.3.3 (#809) 2019-10-14 13:56:58 -05:00
Scala Steward
04a22c415f Update typesafe:config to 1.4.0 (#803) 2019-10-13 19:30:09 -05:00
Ben Carman
9d16d723ae Script Program apply method refactor part 5 (#760) (#801)
* Script Program apply method refactor part 5 (#760)

* Formatting
2019-10-13 13:20:03 -05:00