* Add proper parsing of bitcoin.conf, remove datadir
Somewhat recently a new config format was introduced
in Bitcoin Core. Options can now be specified under
section headers ([regtest], [main], [test]), as
well as with network prefixes (regtest.rpcport,
main.prune) and the traditional format. In this commit
we introduce a new type BitcoindConfig that parses
this format. We also make the necessary changes in
the bitcoind/Eclair RPC clients to accomodate this new
type.
We also remove the datadir field from
BitcoindAuthCredentials. This is not strictly necessary
to connect to a bitcoind, so this is a bad separation
of concerns. The datadir field is instead moved into
the BitcoindInstance.
Finally we go over some places in tests and test
utils and assert that we are operating in the
user temporary directory. This is a safety measure
so that other developers/users won't do the same
mistake I did while working on this and accidentally
blow up their $HOME/.bitcoin directory.
* Add BitcoindRpcClient.fromDatadir
* Address code review from Chris
* Docs: Introduce new Docusaurus-based website
This commit is the result of running
npx docusaurus-init, and nothing more.
Further changes will happen on top of
this, to make it easier to review changes
and update to newer versions of Docusaurus
in the future.
* WIP: Add Bitcoin-S website
Change the default Docusaurus template to a custom website. Goes
off of existing documentation, and moves it into the new docs and
website directories. Deletes some unused files, such as
BUILD_README.md
* Initial mdoc support
* Add Scaladoc to website
* Add SVG assets
* Change colors, flesh out pages, correct Scaladoc links
* Rename doc project to scripts, move security doc to website
* Add copy buttons to website code snippets
* Add doc and tasks for publishing website
* Refactor how paths get copied after generating Scaladocs
* Add Get Started button
* Replace bitcoin-s logo with white text
* Add Montserrat font for headers
* flesh out user showcase and landing page
* Change Scaladoc URL to bitcoins package
* Reduce number of requests we send to eclair in testkits, add commandName param to parseResult in EclairRpcClient
* Factor our EclairRpcClient error message
* Make jvm opts more sane, refactor error message code again
* Add error message on EclairRpcTestUtil.sendPayments, scalafmt
* Put tests for bitcoind-rpc and eclair-rpc into a separate project to get rid of circular dependency
* Modify travis yml file to get rid of all testkit stuff
* rename rpc project to bitcoind-rpc project
* Add bitcoind-rpc test cases that got deleted accidentally
* Add more files missing from bitcoind-rpc-test
* Remove circular deps part on CONTRIBUTING.md
WIP: Refactoring EclairTestUtil to use Futures
Finished refactor EclairTestUtil to use futures
Address code review
fix async bug in chan opening
Change snapshot version to something that should compile
Add documentation for TxBuilder
Try to fix links on core/README.md
add readme badges for bintray
Nits and formatting of README (#23)
ran scalafmt, fixed format in secp readme
* remove duplicate files in rpc,eclair-rpc and replace them with publish testkit dep
remove gen package, fix bugs in testkit generators that weren't properly copied for the gen project
* Adding bintray resolver, fixing bug in bech32 address generator where exception was being thrown because an unassigned witness spk was hash was being called
* Implementation of LnCurrencyUnit
Fix unary and unneeded comments.
Refactor and change arithmetic to use PicoBitcoins.
Add property based testing for LnCurrencyUnits
Refactor LnCurrencyUnits after code review
Fix case and change LnPolicy to val
Remove division and add Unit tests
* Add additional unit tests and deserialization
* WIP: Implement LnHumanReadablePart (#190)
* Initial Implementation of LnHumanReadablePart
* Add unit tests and improve deserialization from string
* Refactor LnParams and LnHrp. Add requirements for instantiating LnHrp.
* Clean up and re-organize things
Re-working LnHumanReadablePart.fromString
Fix unnecessary pattern match
Removing test case
* Created eclairRpc project (#193)
Added getinfo functionality
Added connect functionality
Added most of the rpcs
Added send and checkpayment functionality
Added updaterelayfee functionality
Fixed compile errors
Ran scalafmt
Added DaemonInstance and start/stop methods
Added TestUtil
Added open test
Fixed typo in allUpdates
Fixed ChannelResult
Add eclair prefix to rpc stuff
open channel unit test passing
Adding instructions to grab default eclair in build
Add zmq config to bitcoin.conf
rename test log files, bump timeouts on connections
Add eclair-rpc README, rework some RpcUtil/TestUtil stuff for async
fixing bug in precious block, addressing code review
Address more code review comments
* Add NodeId, NodeUri, ChannelId (#196)
refactor json serializing methods to SerializerUtil, add more types
* Adding LnCurrencyUnit types to rpc api, fixing bug where eclair tests were not binding to a random port for zmq (#198)
Remove start stuff
* Adding more rpc tests, testing open, payment over channel, and closing of the channel (#199)
Add checkpayment tests
Address code review, create EclairTestUtil.createNodPair
* Two way eclair transactions sanity test (#200)
* Added a test for sending payments in both directions
* Updated travis bitcoin core version
* Initial LnInvoice Implementation (#194)
Start typing some ln invoice stuff
Add support for Fallback Address encoding
Part 1: Breaking out Bech32 specific functions into a util class, don't embed in Bech32Address
re-naming fromBase8ToBase5 -> from8BitTo5bit
Part 1: Breaking out Bech32 specific functions into a util class, don't embed in Bech32Address
rework ln invoices tags
fix more method names in Bech32
Rename ScriptPubKeyTag -> NodeIdTag
All invoice tags tests passing except weird serialization order one
Address code review, add some more comments
rename 'LnInvoiceTags' -> 'LnInvoiceTaggedFields'
create a UInt5 type to represent all of the bech32 data structures
Passing all serialization in the BOLT11 examples
First cut at deserialization
* Adding bitcoin-s types to the eclair-rpc, fixing bug with decoding numbers, refactoring more things (#204)
* Switch bech32 p2wpkh hash from RipdeMd160 -> Sha256Hash160Digest (#206)
* Add testkit project / dependency (#209)
fix core-gen build.sbt name
* add correct dependencies to testkit (#210)
* Get dep name right (#211)
* Add serialization symmetry property for LnInvoice, fixing various bugs in LnInvoice data structures, adding generators for various LnInvoice data structures (#217)
* Reworking AuthCredentials and Instances so that we can read from config files (#218)
add core files that were missing
* Reworking a lot of testkit data structures to be more helpful for testing (#219)
Add missing EclairApi file
remove noisy log
* Rebase onto master, fix testkit compile issues
* Simplify LnCurrencyUnit, add MilliSatoshis, refactor EclairRpc to use… (#226)
* Simplify LnCurrencyUnit, add MilliSatoshis, refactor EclairRpc to use MilliSatoshis
* Add some helper functions around millisatoshis for comparing them to other things
* more tests / helper methods, at generator for millisatoshis
* Fix typo
* Fix comparison operators for millisatoshis, add Writes for MilliSatos… (#227)
* Fix comparison operators for millisatoshis, add Writes for MilliSatoshis in JsonWriters
* re-add comparison operators to LnCurrencyUnit for convinience
* Add millisatoshi reads (#228)
* Updating version of eclair to https://github.com/ACINQ/eclair/releases/download/v0.2-beta8/eclair-node-0.2-beta8-52821b8.jar (#229)
* Derive nodeId from ln invoice signature, move nodeid case class into … (#230)
* Derive nodeId from ln invoice signature, move nodeid case class into the core project
* Add missing assert
* Fix null pointer exception that could occurred during requiring the invoice's signature to valid. This could occurr if a user tried to construct an invoice with an invalid signature (#233)
* Turn down logging / remove logging (#235)
* Cleaned up eclair conf (#237)
* Cleaned up eclair conf
* Added test for bad auth and Reads for LnInvoice
* WIP: rebase onto master with new compiler opts
fix more compiler warnings with testkit
* fix new compiler warnings for scalac 2.12.x on ln (#253)
* fix new compiler warnings for scalac 2.12.x on ln
* fix missing p2wpkhoutput in rawoutput testkit/CreditingTxGen.scala
* First cut at code review for the ln branch (#258)
Fix bug in parsing the LnTagPrefix.CltvExpiry, add properties that check if the NodeIdTag is given explicitly to the invoice
remove dumb invariants
revert version
* 2018 12 4 ln code review rd2 (#259)
* Amend EclairRpc test case for confirming that channel is closed
* Add final check to test case to make sure the bitcoind wallet received funds when closing channel
* Address Torkel's code review
* Addresses some review on #256 (#260)
* Docstring cleanup, small nits
* Refactors some redudant data, nested if => switch
* Fixes SO error by reversing remowal of `new`
* Fixes a couple of bugs
* map.get instead of list.find
* StringBuilder in HRP
* Rework NetworkParam to LnParam
* Cleanup
* Renames file to match trait/object name
* Docstring cleanup, pure formatting
* Simplifies a few expressions, doesn't change semantics
* Adds overloaded findRoute method instead of Either[NodeId, LnInvoice]
* Eclair cleanup
* Address concerns from Chris
* Type annotation to match case
* Address nadav's code review
