mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2025-03-03 18:47:38 +01:00
Code Issues Projects Releases Packages Wiki Activity

Support bip32 paths with 'h' instead of an apostrophe (#4881)

Browse source
This commit is contained in:
benthecarman 2022-11-12 12:49:38 -06:00 • committed by GitHub
parent 7a64accd69
commit cc8d327ea5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core-test/src/test/scala/org/bitcoins/core/crypto/bip32/BIP32PathTest.scala
View file

@ -90,6 +90,12 @@ class BIP32PathTest extends BitcoinSUnitTest {
assert(fromString.path.head.toUInt32 == ExtKey.hardenedIdx)
}
it must "parse a hardened path without an apostrophe" in {
val fromString = BIP32Path.fromString("m/0h")
assert(fromString.path.length == 1)
assert(fromString.path.head.toUInt32 == ExtKey.hardenedIdx)
}
it must "parse a hardened path from bytes" in {
val fromString = BIP32Path.fromBytes(hex"0x80000000")
assert(fromString.path.length == 1)

2
core/src/main/scala/org/bitcoins/core/hd/BIP32Path.scala
View file

@ -136,7 +136,7 @@ object BIP32Path extends Factory[BIP32Path] with StringFactory[BIP32Path] {
val path = rest.map { str =>
val (index: String, hardened: Boolean) =
if (str.endsWith("'")) {
if (str.endsWith("'") || str.endsWith("h")) {
(str.dropRight(1), true)
} else {
(str, false)