mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2025-02-23 22:56:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix and Optimize Broadcast Transaction Test (#1545)

Browse source 
* Fix and Optimize Broadcast Transaction Test

* Use variable
This commit is contained in:
Ben Carman 2020-06-12 10:43:26 -05:00 • committed by GitHub
parent cc25387b11
commit a2ea3490c8
1 changed files with 18 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
node-test/src/test/scala/org/bitcoins/node/BroadcastTransactionTest.scala
View file

@ -1,16 +1,13 @@
package org.bitcoins.node package org.bitcoins.node
import org.bitcoins.core.currency._ import org.bitcoins.core.currency._
import org.bitcoins.core.protocol.BitcoinAddress
import org.bitcoins.core.protocol.transaction.Transaction import org.bitcoins.core.protocol.transaction.Transaction
import org.bitcoins.core.wallet.fee.SatoshisPerByte
import org.bitcoins.rpc.BitcoindException import org.bitcoins.rpc.BitcoindException
import org.bitcoins.server.BitcoinSAppConfig import org.bitcoins.server.BitcoinSAppConfig
import org.bitcoins.testkit.BitcoinSTestAppConfig import org.bitcoins.testkit.BitcoinSTestAppConfig
import org.bitcoins.testkit.async.TestAsyncUtil import org.bitcoins.testkit.async.TestAsyncUtil
import org.bitcoins.testkit.node.NodeUnitTest.{ import org.bitcoins.testkit.node.NodeUnitTest.SpvNodeFundedWalletBitcoind
NeutrinoNodeFundedWalletBitcoind,
SpvNodeFundedWalletBitcoind
}
import org.bitcoins.testkit.node.{NodeTestUtil, NodeUnitTest} import org.bitcoins.testkit.node.{NodeTestUtil, NodeUnitTest}
import org.scalatest.FutureOutcome import org.scalatest.FutureOutcome
@ -28,6 +25,11 @@ class BroadcastTransactionTest extends NodeUnitTest {
def withFixture(test: OneArgAsyncTest): FutureOutcome = def withFixture(test: OneArgAsyncTest): FutureOutcome =
withSpvNodeFundedWalletBitcoind(test, NodeCallbacks.empty) withSpvNodeFundedWalletBitcoind(test, NodeCallbacks.empty)
private val sendAmount = 1.bitcoin
private val junkAddress: BitcoinAddress =
BitcoinAddress("2NFyxovf6MyxfHqtVjstGzs6HeLqv92Nq4U")
it must "broadcast a transaction" in { param => it must "broadcast a transaction" in { param =>
val SpvNodeFundedWalletBitcoind(node, wallet, rpc) = param val SpvNodeFundedWalletBitcoind(node, wallet, rpc) = param
@ -47,27 +49,28 @@ class BroadcastTransactionTest extends NodeUnitTest {
} }
} }
for { val addrF = rpc.getNewAddress
val balanceF = rpc.getBalance
address <- rpc.getNewAddress for {
_ <- wallet.getBloomFilter() _ <- wallet.getBloomFilter()
_ <- node.sync() _ <- node.sync()
_ <- NodeTestUtil.awaitSync(node, rpc) _ <- NodeTestUtil.awaitSync(node, rpc)
address <- addrF
tx <- wallet tx <- wallet
.sendToAddress(address, 1.bitcoin, Some(SatoshisPerByte(10.sats))) .sendToAddress(address, sendAmount, None)
bitcoindBalancePreBroadcast <- rpc.getBalance bitcoindBalancePreBroadcast <- balanceF
_ = node.broadcastTransaction(tx) _ <- node.broadcastTransaction(tx)
_ <- TestAsyncUtil.awaitConditionF(() => hasSeenTx(tx), _ <- TestAsyncUtil.awaitConditionF(() => hasSeenTx(tx),
duration = 1.second) duration = 1.second)
fromBitcoind <- rpc.getRawTransaction(tx.txIdBE) _ <- rpc.generateToAddress(blocks = 1, junkAddress)
_ = assert(fromBitcoind.vout.exists(_.value == 1.bitcoin))
_ <- rpc.getNewAddress.flatMap(rpc.generateToAddress(1, _))
bitcoindBalancePostBroadcast <- rpc.getBalance bitcoindBalancePostBroadcast <- rpc.getBalance
} yield assert(bitcoindBalancePreBroadcast < bitcoindBalancePostBroadcast) } yield assert(
// pre-balance + sent amount + 1 block reward maturing
bitcoindBalancePreBroadcast + sendAmount + 50.bitcoins == bitcoindBalancePostBroadcast)
} }
} }