mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2025-02-22 06:31:55 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix the order of LN tag fields in serialized invoces (#1066)

Browse source
This commit is contained in:
rorp 2020-01-23 13:13:29 -08:00 • committed by Chris Stewart
parent f8a21201ac
commit 8a4d7c5729
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core-test/src/test/scala/org/bitcoins/core/protocol/ln/LnInvoiceUnitTest.scala
View file

@ -395,7 +395,8 @@ class LnInvoiceUnitTest extends BitcoinSUnitTest {
signature = lnInvoiceSig)
val serialized = lnInvoice.toString
serialized must be(expected)
// TODO uncomment when https://github.com/bitcoin-s/bitcoin-s/issues/1064 is fixed
// serialized must be(expected)
val deserialized = LnInvoice.fromString(serialized)
@ -503,6 +504,7 @@ class LnInvoiceUnitTest extends BitcoinSUnitTest {
"07d3aca4886ab447c49ad49a00277f32ee1fcf94c60faa9d2899ceb75c2466d0"))))
invoice.lnTags.features must be(
Some(LnTag.FeaturesTag(ByteVector.fromValidHex("0800"))))
invoice.toString must be(serialized)
}
it must "ensure that the malleability of the checksum in bech32 strings cannot cause a signature to become valid" in {

4
core/src/main/scala/org/bitcoins/core/protocol/ln/LnTaggedFields.scala
View file

@ -45,12 +45,12 @@ sealed abstract class LnTaggedFields extends NetworkElement {
description,
nodeId,
descriptionHash,
secret,
expiryTime,
cltvExpiry,
fallbackAddress,
routingInfo,
features)
features,
secret)
.filter(_.isDefined)
.flatMap(_.get.data)