mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2024-11-19 09:52:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Increase test coverage in WalletStorage (#2030)

Browse Source
This commit is contained in:
Ben Carman 2020-09-18 06:34:13 -05:00 committed by GitHub
parent ae6bab857f
commit 82b324f1aa
1 changed files with 85 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
key-manager-test/src/test/scala/org/bitcoins/keymanager/WalletStorageTest.scala
View File

@ -1,6 +1,7 @@
package org.bitcoins.keymanager
import java.nio.file.{Files, Path}
import java.util.NoSuchElementException
import org.bitcoins.core.util.TimeUtil
import org.bitcoins.crypto.AesPassword
@ -8,11 +9,13 @@ import org.bitcoins.keymanager.ReadMnemonicError.{
DecryptionError,
JsonParsingError
}
import org.bitcoins.keymanager.bip39.BIP39KeyManager
import org.bitcoins.testkit.Implicits._
import org.bitcoins.testkit.core.gen.CryptoGenerators
import org.bitcoins.testkit.wallet.BitcoinSWalletTest
import org.bitcoins.wallet.config.WalletAppConfig
import org.scalatest.{BeforeAndAfterEach, FutureOutcome}
import ujson.Value.InvalidData
class WalletStorageTest extends BitcoinSWalletTest with BeforeAndAfterEach {
@ -63,6 +66,50 @@ class WalletStorageTest extends BitcoinSWalletTest with BeforeAndAfterEach {
}
}
it must "read a mnemonic without a creation time" in { walletConf =>
val badJson =
"""
| {
| "iv":"d2aeeda5ab83d43bb0b8fe6416b12009",
| "cipherText": "003ad9acd6c3559911d7e2446dc329c869266844fda949d69fce591205ab7a32ddb0aa614b1be5963ecc5b784bb0c1454d5d757b71584d5d990ecadc3d4414b87df50ffc46a54c912f258d5ab094bbeb49f92ef02ab60c92a52b3f205ce91943dc6c21b15bfbc635c17b049a8eec4b0a341c48ea163d5384ebbd69c79ff175823e8fbb0849e5a223e243c81c7f7c5bca62a11b7396",
| "salt":"db3a6d3c88f430bf44f4a834d85255ad6b52c187c05e95fac3b427b094298028"
| }
""".stripMargin
val seedPath = getSeedPath(walletConf)
Files.write(seedPath, badJson.getBytes())
val read =
WalletStorage.decryptMnemonicFromDisk(seedPath,
BIP39KeyManager.badPassphrase)
read match {
case Right(readMnemonic) =>
assert(
readMnemonic.creationTime.getEpochSecond == WalletStorage.FIRST_BITCOIN_S_WALLET_TIME)
case Left(err) => fail(err.toString)
}
}
it must "fail to read a mnemonic with improperly formatted creation time" in {
walletConf =>
val badJson =
"""
| {
| "iv":"d2aeeda5ab83d43bb0b8fe6416b12009",
| "cipherText": "003ad9acd6c3559911d7e2446dc329c869266844fda949d69fce591205ab7a32ddb0aa614b1be5963ecc5b784bb0c1454d5d757b71584d5d990ecadc3d4414b87df50ffc46a54c912f258d5ab094bbeb49f92ef02ab60c92a52b3f205ce91943dc6c21b15bfbc635c17b049a8eec4b0a341c48ea163d5384ebbd69c79ff175823e8fbb0849e5a223e243c81c7f7c5bca62a11b7396",
| "salt":"db3a6d3c88f430bf44f4a834d85255ad6b52c187c05e95fac3b427b094298028",
| "creationTime":"not a number"
| }
""".stripMargin
val seedPath = getSeedPath(walletConf)
Files.write(seedPath, badJson.getBytes())
assertThrows[InvalidData] {
WalletStorage.decryptMnemonicFromDisk(seedPath,
BIP39KeyManager.badPassphrase)
}
}
it must "fail to read a mnemonic with bad password" in { walletConf =>
val _ = getAndWriteMnemonic(walletConf)
val seedPath = getSeedPath(walletConf)
@ -97,6 +144,44 @@ class WalletStorageTest extends BitcoinSWalletTest with BeforeAndAfterEach {
}
}
it must "fail to read a mnemonic that has missing a JSON field" in {
walletConf =>
val badJson =
"""
| {
| "iv":"ba7722683dad8067df8d069ee04530cc",
| "salt":"2b7e7d718139518070a87fbbda03ea33cdcda83b555020e9344774e6e7d08af2"
| }
""".stripMargin
val seedPath = getSeedPath(walletConf)
Files.write(seedPath, badJson.getBytes())
assertThrows[NoSuchElementException] {
WalletStorage.decryptMnemonicFromDisk(seedPath, passphrase)
}
}
it must "fail to read a mnemonic not in hex" in { walletConf =>
val badJson =
"""
| {
| "iv":"ba7722683dad8067df8d069ee04530cc",
| "cipherText": "my name is jeff",
| "salt":"2b7e7d718139518070a87fbbda03ea33cdcda83b555020e9344774e6e7d08af2"
| }
""".stripMargin
val seedPath = getSeedPath(walletConf)
Files.write(seedPath, badJson.getBytes())
val read =
WalletStorage.decryptMnemonicFromDisk(seedPath, passphrase)
read match {
case Left(JsonParsingError(_)) => succeed
case res @ (Left(_) | Right(_)) => fail(res.toString)
}
}
it must "throw an exception if we attempt to overwrite an existing seed" in {
walletConf =>
assert(!walletConf.seedExists())