mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2024-11-19 09:52:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

added test and fixed code (#435)

Browse Source
This commit is contained in:
Ramon Boss 2019-04-23 18:44:27 +00:00 committed by Chris Stewart
parent e5f9885312
commit 6944f948ab
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core-test/src/test/scala/org/bitcoins/core/protocol/transaction/TransactionTest.scala
View File

@ -294,6 +294,12 @@ class TransactionTest extends FlatSpec with MustMatchers {
}
}
it must "check transaction with two out point referencing the same tx with different indexes" in {
val hex = "0200000002924942b0b7c12ece0dc8100d74a1cd29acd6cfc60698bfc3f07d83890eec20b6000000006a47304402202831d3708867f9bfb4268690cbcf97a686ccec1f5a4334cf0256fd442a88d0b802206fa8fa5550df8bfcc9c31cc8b6aad035be68b767b67e2b823f844680a79349650121038991058ce7ef4b00194e8426e3630dffd32822f819c150938f26113ba751c9a100000000924942b0b7c12ece0dc8100d74a1cd29acd6cfc60698bfc3f07d83890eec20b6010000006a47304402202e4cf01174afb9f97b0ab8f24c64c796ae4b3bb91d1838099bf262e8842e6480022006399d769d6d4ba099c2d3188f62caa5b51f572e7c2775a9bc23495c020dd1090121038991058ce7ef4b00194e8426e3630dffd32822f819c150938f26113ba751c9a1000000000288130000000000001976a914cc1fe3e943bd91e0e263f08a93f0d2a5299a7e5e88ac32600000000000001976a914af84620f44464d1a404386485885d1cd9e5d396d88ac00000000"
val btx = BaseTransaction.fromHex(hex)
ScriptInterpreter.checkTransaction(btx) must be(true)
}
private def findInput(
tx: Transaction,
outPoint: TransactionOutPoint): Option[(TransactionInput, Int)] = {

4
core/src/main/scala/org/bitcoins/core/script/interpreter/ScriptInterpreter.scala
View File

@ -779,8 +779,8 @@ sealed abstract class ScriptInterpreter {
val totalSpentByOutputs: CurrencyUnit =
outputValues.fold(CurrencyUnits.zero)(_ + _)
val allOutputsValidMoneyRange = validMoneyRange(totalSpentByOutputs)
val prevOutputTxIds = transaction.inputs.map(_.previousOutput.txId)
val noDuplicateInputs = prevOutputTxIds.distinct.size == prevOutputTxIds.size
val prevOutputs = transaction.inputs.map(_.previousOutput)
val noDuplicateInputs = prevOutputs.distinct.size == prevOutputs.size
val isValidScriptSigForCoinbaseTx = transaction.isCoinbase match {
case true =>