Refactor make dependent fixtures to use built in scalatest helper met… (#939)

* Refactor make dependent fixtures to use built in scalatest helper methods

* Avoid unit return warning

testkit/src/main/scala/org/bitcoins/testkit/fixtures/BitcoinSFixture.scala

@@ -32,33 +32,18 @@ trait BitcoinSFixture extends BitcoinSAsyncFixtureTest {
       throw err
     }
 
-    val outcomeF = fixtureF.flatMap { fixture =>
+    val outcomeF: Future[Outcome] = fixtureF.flatMap { fixture =>
       test(fixture.asInstanceOf[FixtureParam]).toFuture
     }
 
-    outcomeF.failed.foreach(err =>
+    val futOutcome: FutureOutcome = new FutureOutcome(outcomeF)
-      println(s"Failed fixture test execution=${err}"))
 
-    val destroyP = Promise[Unit]()
+    val result: FutureOutcome = futOutcome.onOutcomeThen { _ =>
-    outcomeF.onComplete { _ =>
+      fixtureF.flatMap(f => destroy(f))
-      fixtureF.foreach { fixture =>
+      ()
-        destroy(fixture).onComplete {
-          case Success(_) => destroyP.success(())
-          case Failure(err) =>
-            logger.error(s"Failed to destroy fixture with err=${err}")
-            destroyP.failure(err)
-        }
-      }
     }
 
-    val outcomeAfterDestroyF = destroyP.future.flatMap(_ => outcomeF)
+    result
-
-    outcomeAfterDestroyF.failed.foreach { err =>
-      println(s"err creating and destroying fixture")
-      throw err
-
-    }
-    new FutureOutcome(outcomeAfterDestroyF)
   }
 
   /**