mirrors/bitcoin-s
1
0
Fork 0
mirror of https://github.com/bitcoin-s/bitcoin-s.git synced 2025-01-18 21:34:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove .map() and use .foreach() with buffer in CryptoBytesUtil.toByteVector() (#4454)

Browse Source
This commit is contained in:
Chris Stewart 2022-07-06 18:23:14 -05:00 committed by GitHub
parent ae0962d7ed
commit 2b60bbb1c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/scripts/src/main/scala/org/bitcoins/scripts/ScanBitcoind.scala
View File

@ -36,7 +36,7 @@ class ScanBitcoind()(implicit
bitcoind <- bitcoindF
endHeight <- endHeightF
//_ <- countWitV1MempoolTxs(bitcoind)
_ <- countTaprootTxsInBlocks(endHeight, 10000, bitcoind)
_ <- countTaprootTxsInBlocks(endHeight, 250000, bitcoind)
} yield ()
f.failed.foreach(err =>
logger.error(s"Failed to count witness v1 mempool txs", err))

8
crypto/src/main/scala/org/bitcoins/crypto/CryptoBytesUtil.scala
View File

@ -2,7 +2,7 @@ package org.bitcoins.crypto
import scodec.bits.{BitVector, ByteVector}
import scala.math.BigInt
import java.io.ByteArrayOutputStream
/** Created by chris on 2/26/16.
*/
@ -97,7 +97,11 @@ trait CryptoBytesUtil {
@inline
final def toByteVector[T <: NetworkElement](h: Seq[T]): ByteVector = {
ByteVector.concat(h.map(_.bytes))
val outputStream = new ByteArrayOutputStream()
h.foreach { ne =>
outputStream.write(ne.bytes.toArray)
}
ByteVector(outputStream.toByteArray)
}
}