Have BroadcastTransactionTest rebroadcast on failure (#1561)

node-test/src/test/scala/org/bitcoins/node/BroadcastTransactionTest.scala

@@ -70,7 +70,19 @@ class BroadcastTransactionTest extends NodeUnitTest {
       bitcoindBalancePreBroadcast <- balanceF
       _ <- node.broadcastTransaction(tx)
       _ <-
-        TestAsyncUtil.awaitConditionF(() => hasSeenTx(tx), duration = 1.second)
+        TestAsyncUtil
+          .awaitConditionF(() => hasSeenTx(tx),
+                           duration = 1.second,
+                           maxTries = 25)
+          .recoverWith {
+            case _: Throwable =>
+              for {
+                _ <- node.broadcastTransaction(tx)
+                _ <- TestAsyncUtil.awaitConditionF(() => hasSeenTx(tx),
+                                                   duration = 1.second,
+                                                   maxTries = 25)
+              } yield ()
+          }
       _ <- rpc.generateToAddress(blocks = 1, junkAddress)
       bitcoindBalancePostBroadcast <- rpc.getBalance
 

node/src/main/scala/org/bitcoins/node/Node.scala

@@ -208,7 +208,7 @@ trait Node extends NodeApi with ChainQueryApi with P2PLogger {
   override def broadcastTransaction(transaction: Transaction): Future[Unit] = {
     val broadcastTx = BroadcastAbleTransaction(transaction)
 
-    txDAO.create(broadcastTx).onComplete {
+    txDAO.upsert(broadcastTx).onComplete {
       case Failure(exception) =>
         logger.error(s"Error when writing broadcastable TX to DB", exception)
       case Success(written) =>