Add -Xsource:3 to rpc projects (#5590)

* Add -Xsource:3 to bitcoind-rpc/ bitcoind-rpc-test/ lnd-rpc/ lnd-rpc-test/ eclair-rpc/ eclair-rpc-test/ clightning-rpc/ clightning-rcp-test/

* Remove -quickfix:any

* Remove lndRpc/ -Xsource:3 flag

build.sbt

@@ -83,6 +83,7 @@ lazy val coreJS = core.js
 lazy val asyncUtils = crossProject(JVMPlatform, JSPlatform)
   .crossType(CrossType.Pure)
   .in(file("async-utils"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.prodSettings: _*)
   .settings(name := "bitcoin-s-async-utils",
             libraryDependencies ++= Deps.asyncUtils.value)
@@ -124,6 +125,7 @@ lazy val testkitCoreJS = testkitCore.js
 
 lazy val bitcoindRpc = project
   .in(file("bitcoind-rpc"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.prodSettings: _*)
   .dependsOn(
     asyncUtilsJVM,
@@ -133,6 +135,7 @@ lazy val bitcoindRpc = project
 
 lazy val eclairRpc = project
   .in(file("eclair-rpc"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.prodSettings: _*)
   .dependsOn(asyncUtilsJVM, bitcoindRpc)
 
@@ -143,6 +146,7 @@ lazy val lndRpc = project
 
 lazy val clightningRpc = project
   .in(file("clightning-rpc"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.prodSettings: _*)
   .dependsOn(asyncUtilsJVM, bitcoindRpc)
 
@@ -592,6 +596,7 @@ lazy val bench = project
 
 lazy val eclairRpcTest = project
   .in(file("eclair-rpc-test"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.testSettings: _*)
   .settings(
     libraryDependencies ++= Deps.eclairRpcTest.value,
@@ -601,6 +606,7 @@ lazy val eclairRpcTest = project
 
 lazy val clightningRpcTest = project
   .in(file("clightning-rpc-test"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.testSettings: _*)
   .settings(
     libraryDependencies ++= Deps.clightningRpcTest.value,
@@ -610,6 +616,7 @@ lazy val clightningRpcTest = project
 
 lazy val lndRpcTest = project
   .in(file("lnd-rpc-test"))
+  .settings(scalacOptions += "-Xsource:3")
   .settings(CommonSettings.testSettings: _*)
   .settings(
     libraryDependencies ++= Deps.eclairRpcTest.value,

lnd-rpc/src/main/scala/org/bitcoins/lnd/rpc/LndRpcClient.scala

@@ -1177,7 +1177,7 @@ class LndRpcClient(val instance: LndInstance, binaryOpt: Option[File] = None)(
 
         // register callback that publishes a payment to our actor system's
         // event stream,
-        receivedInfoF.foreach { info: Invoice =>
+        receivedInfoF.foreach { (info: Invoice) =>
           if (info.state.isSettled) {
             // invoice has been paid, let's publish to event stream
             // so subscribers so the even stream can see that a payment

project/CommonSettings.scala

@@ -165,7 +165,8 @@ object CommonSettings {
       "-Xlint:constant",
       "-Xlint:nonlocal-return",
       "-Xlint:implicit-not-found",
-      "-Xlint:serial"
+      "-Xlint:serial",
+      "-quickfix:any"
     )
   }