1
0
mirror of https://github.com/bitcoin/bips.git synced 2025-01-19 05:45:07 +01:00
Commit Graph

23 Commits

Author SHA1 Message Date
Luke Dashjr
f59f235d91
Merge pull request #1268 from JeremyRubin/patch-1
Fix BIP-119 Typo + Clarify the reasons for 32 bit lengths
2022-01-15 23:14:23 +00:00
Luke Dashjr
01fe8b4615
Merge pull request #1260 from JeremyRubin/ctv-test-vectors
[BIP-0119] Include test vectors for CTV in BIP's subdirectory
2022-01-15 23:14:05 +00:00
Jeremy Rubin
b96b1712fc
Fix BIP-119 Typo + Clarify the reasons for 32 bit lengths
when drafting the BIP I attempted to triangulate what the width of the fields for number of inputs/outputs should be from various sources in the codebase, and made an error in looking at the signing and encoding logic, and not the _decoding_ logic which restricts vectors (vin, vout) to MAX_SIZE which is 33554432. This fully justifies not using a wider type (uint64_t).

Also clarified arguments for not using a narrower type (uint16_t) which would be possible just for the vIn based on block size, because it's a leaky abstraction (you can still encode and decode such a transaction,  just not mine it).


thanks to @roconnor-blockstream for pointing this out
2022-01-04 16:11:30 -08:00
Jeremy Rubin
ae747e2b90 [BIP-0119] Include test vectors for CTV in BIP's subdirectory 2021-12-25 11:07:33 -08:00
Jeremy Rubin
ea6008eeb1 BIP-119: Clarify that Speedy Trial may or may not be implemented for BIP-119 2021-12-22 19:32:05 -08:00
Jeremy Rubin
4479187baf BIP-119: Update Motivations and describe vaults alternatives better 2021-12-22 19:32:05 -08:00
Luke Dashjr
1904334276
Merge pull request #1226 from OrfeasLitos/define-check-119
Define BIP-119 CheckDefaultCheckTemplateVerifyHash
2021-12-15 21:36:04 +00:00
Orfeas Litos
3ff4a4ce9d
Convert inside CheckDefaultCheckTemplateVerifyHash 2021-11-12 01:08:46 +01:00
Orfeas Litos
1839f43779
Fix typo 2021-11-11 23:27:52 +01:00
Orfeas Litos
897e6458ce
Cast 8-vector of u32 to u256 2021-11-10 23:40:20 +01:00
Orfeas Litos
1cab3e87f3
Define BIP-119 CheckDefaultCheckTemplateVerifyHash 2021-11-02 22:36:05 +01:00
Jeremy Rubin
6058f2f669 [BIP-119] Whitspace Consistency 2021-10-16 09:00:48 -07:00
Jeremy Rubin
b305d56352 [BIP-119] Explain Hash Function Choices 2021-10-15 12:47:42 -07:00
Jeremy Rubin
afc605f8e2 [BIP-119] Describe Synergies with future soft fork proposals 2021-10-15 12:47:42 -07:00
Jeremy Rubin
27466fa815 [BIP-119] Better Explain AnyPrevout v.s. CTV 2021-10-15 12:47:42 -07:00
Jeremy Rubin
8364e25ebc [BIP-119] Clarify Draft Deployment Params 2021-10-15 12:47:42 -07:00
Jeremy Rubin
c788bd9d08 Update BIP-119 Variable Names 2021-08-30 10:48:33 -07:00
Tom Harding
4a4f593c8c
Update bip-0119.mediawiki
"susceptibility", but meaning is clear without this word
2020-08-25 09:34:33 -07:00
Luke Dashjr
b38171d14e
Merge pull request #882 from MarcoFalke/patch-2
Fix links in bip-0119.mediawiki
2020-02-20 01:44:51 +00:00
Richard Kiss
3e85c85044
Update bip-0119.mediawiki
Fix typo.
2020-02-01 12:25:27 -08:00
MarcoFalke
a7597ec2c3
Update bip-0119.mediawiki
fix links
2020-01-25 12:10:07 -05:00
Jeremy Rubin
117f4186e7 Fix Links to images in BIP-119 2020-01-23 16:56:03 -08:00
Jeremy Rubin
1db62a07c5 Assign CTV BIP #119 2020-01-23 16:51:50 -08:00