1
0
mirror of https://github.com/bitcoin/bips.git synced 2025-01-19 05:45:07 +01:00
Commit Graph

2682 Commits

Author SHA1 Message Date
Jonas Nick
8b4f79b6f6 BIP-340: Stress that secret key should be fresh and if not then RFC6979 shouldn't be used 2020-02-23 19:33:13 -08:00
Anthony Towns
2a122f20c5 missing space 2020-02-23 19:33:13 -08:00
Keagan McClelland
4b18c45e74
Update bip-0340.mediawiki 2020-02-23 13:43:25 -08:00
Adam Rutkowski
1a42bb3450 Update BIP39 Elixir implementation 2020-02-21 11:57:13 +01:00
Vis Virial (a.k.a. びりある)
9329af381f
Fix "Using a single OP_CHECKSIGADD-based script"
1. CHECKSIG / CHECKSIGADD is confused

Only the first OP-code for the first public key should be "CHECKSIG" and the following (second to n-th) OP-codes should be "CHECKSIGADD".
It is confusing because it is only specified the first and last OP-codes, so I specified the second OP-code clearly.
(I recommend to describe why only the first OP-code should be "CHECKSIG", not "CHECKSIGADD".)

2. Order of the signatures in witness

In the original sentence, the stack status after the all witness elements are pushed will be
| w_n  |
|    :    |
| w_1 |

and then, the first element of the script, "<pubkey_1>" will be pushed to the stack
| pubkey_1 |
| w_n  |
|    :    |
| w_1 |

so the "pubkey_1" and "w_n" won't match.

The order of either "pubkey_i"s or "w_i"s should be inverted.
2020-02-20 16:24:06 +09:00
Luke Dashjr
b38171d14e
Merge pull request #882 from MarcoFalke/patch-2
Fix links in bip-0119.mediawiki
2020-02-20 01:44:51 +00:00
Luke Dashjr
cd2c4069a7
Merge pull request #887 from richardkiss/patch-1
Update bip-0119.mediawiki
2020-02-19 23:55:31 +00:00
Luke Dashjr
5dba54b5f1
Merge pull request #889 from JeremyRubin/fix-color-of-change-ctv
Fix Colorings in BIP-0119 states.svg
2020-02-19 22:48:02 +00:00
Luke Dashjr
99d4de01cd
Merge pull request #884 from RandyMcMillan/patch-2
bip-0340: typo change intent to intend
2020-02-19 22:47:00 +00:00
Luke Dashjr
85f512b8df
Merge pull request #706 from Varunram/patch-3
[trivial] remove duplicate of
2020-02-19 22:45:57 +00:00
Luke Dashjr
fcce0e7656
Merge pull request #886 from jonasnick/synth-nonce
BIP 340: Recommend synthetic nonces and verifying signing output
2020-02-19 22:44:04 +00:00
Luke Dashjr
6fdf2eda61
Merge pull request #880 from NicolasDorier/patch-12
Fix broken link
2020-02-19 22:43:05 +00:00
Jeremy Rubin
bef6dc91c4 Fix Colorings in BIP-0119 states.svg 2020-02-06 13:54:05 -08:00
Richard Kiss
3e85c85044
Update bip-0119.mediawiki
Fix typo.
2020-02-01 12:25:27 -08:00
Jonas Nick
b4255dc83b BIP 340: Recommend verifying the signing output 2020-01-28 22:04:39 +00:00
Jonas Nick
2874f1ffe7 BIP 340: Recommend synthetic nonces 2020-01-28 22:04:34 +00:00
@RandyMcMillan
66ab3565ef
change intent to intend 2020-01-26 16:44:37 -05:00
Nicolas Dorier
983955ffc5
Fix broken link 2020-01-26 14:23:23 +09:00
MarcoFalke
a7597ec2c3
Update bip-0119.mediawiki
fix links
2020-01-25 12:10:07 -05:00
Luke Dashjr
0042dec548
Merge pull request #875 from JeremyRubin/ctv
BIP 119: CHECKTEMPLATEVERIFY
2020-01-24 01:43:06 +00:00
Jeremy Rubin
117f4186e7 Fix Links to images in BIP-119 2020-01-23 16:56:03 -08:00
Jeremy Rubin
1db62a07c5 Assign CTV BIP #119 2020-01-23 16:51:50 -08:00
Luke Dashjr
33308e75f8 Merge BIPs 340-342 2020-01-24 00:01:16 +00:00
Luke Dashjr
97ef6783df Merge remote-tracking branch 'origin-pull/876/head' into HEAD 2020-01-24 00:00:01 +00:00
Luke Dashjr
802520e05a Merge commit 'origin-pull/876/head^^^^^^' into HEAD 2020-01-23 23:59:43 +00:00
Luke Dashjr
d81cf9da5e Merge branch 'master' into HEAD 2020-01-23 23:59:10 +00:00
Jeremy Rubin
c36e492f05 Add Backwards Compatibility section to OP_CHECKTEMPLATEVERIFY BIP and change 'Implementations' header to 'Reference Implementation' 2020-01-20 20:17:28 -08:00
Jeremy Rubin
1a42897287 Add BIP for CheckTemplateVerify 2020-01-20 20:17:28 -08:00
Pieter Wuille
9cf4038f17 fix BIP links 2020-01-20 07:35:26 -08:00
Luke Dashjr
6a802329e4
Merge pull request #877 from kallewoof/linter-http-only
linter: avoid false positives such as C++ lambda exprs by only detect…
2020-01-20 05:14:50 +00:00
Karl-Johan Alm
1d20ad8a42
linter: avoid false positives such as C++ lambda exprs by only detecting links starting with 'http' 2020-01-20 14:07:27 +09:00
Pieter Wuille
9de7dfccfa Add to README 2020-01-19 14:48:58 -08:00
Pieter Wuille
c3b91dcc22 Fixes to headers 2020-01-19 14:48:58 -08:00
Pieter Wuille
fa305e5abd Make buildtable.pl support Requires: field 2020-01-19 14:48:58 -08:00
Pieter Wuille
e1914b8173 fixes 2020-01-19 14:48:58 -08:00
Pieter Wuille
eb641cbdb5 Address jonas' comments 2020-01-19 14:47:33 -08:00
Pieter Wuille
1faa4b19bc Rename BIPs 2020-01-19 14:47:33 -08:00
Pieter Wuille
57ed6cb342 Abstract out common signature message calculation 2020-01-19 14:47:33 -08:00
Pieter Wuille
d9ec5f43da Update acknowledgements, remove authors 2020-01-19 14:47:33 -08:00
Pieter Wuille
cd8ea88987 Delete precompiled file 2020-01-19 14:47:33 -08:00
Anthony Towns
1e99e205a8 go back to leaf_version but different rationale 2020-01-19 14:47:33 -08:00
Pieter Wuille
ff8a36200b Redefine leaf versions to be incrementally increasing from 0 2020-01-19 14:47:33 -08:00
Tim Ruffing
41f8993a4b Clarify nonce generation
- Separate nonce generation into getting a random byte string and converting it to a suitable scalar ...
 - ... to make clear that the byte string can be generated differently.
 - Make the warning a little bit more prominent and improve writing
2020-01-19 14:47:33 -08:00
Pieter Wuille
92e3d6ca87 Update Post-History field for taproot/tapscript 2020-01-19 14:47:33 -08:00
Pieter Wuille
f429750036 Update authors 2020-01-19 14:47:33 -08:00
stefanwouldgo
32c0f50d7b more precise wording on limits
there are no tx or block size limits (post-Segwit), just block weight limit

better wording
2020-01-19 14:47:33 -08:00
Pieter Wuille
460163ee0b Add rationale on security assumptions 2020-01-19 14:47:33 -08:00
Pieter Wuille
94e9c0925a Add an informal summary of the design 2020-01-19 14:47:33 -08:00
Pieter Wuille
84161e187d Improve and restructure motivation and design 2020-01-19 14:47:33 -08:00
Matthew Zipkin
734a859b27 bip-taproot: example from diagram 2020-01-19 14:47:33 -08:00