Bryan Bishop
b78b6de4fd
bip-taproot: fix small typo (is does not)
2020-01-19 14:47:33 -08:00
Jonas Nick
65a4f1deb8
Mention SHA256 block size
...
Rebased by Pieter Wuille
2020-01-19 14:47:33 -08:00
Pieter Wuille
8886eb4071
Address some nits
2020-01-19 14:47:33 -08:00
Jonas Nick
a5112f9f01
Move plain public key in output rationale to design section
...
Rebased by Pieter Wuille
2020-01-19 14:47:33 -08:00
Tim Ruffing
2b987b5711
Rework Applications section
2020-01-19 14:47:33 -08:00
Jonas Nick
204b7f13a0
Prescribe that a taproot output key should always have a taproot commitment
2020-01-19 14:47:33 -08:00
Tim Ruffing
29037bd123
Add a footnote about 32-byte security
2020-01-19 14:47:33 -08:00
Anthony Towns
4491902569
note about pubkey collision
2020-01-19 14:47:33 -08:00
Anthony Towns
0d04e41e2f
key gen, verify, sign in intro
2020-01-19 14:47:33 -08:00
Anthony Towns
8ffea86023
use p for taproot internal key
2020-01-19 14:47:33 -08:00
Anthony Towns
4e13ec7301
make secret key a 32-byte array called sk, introduce pubkey()
2020-01-19 14:47:33 -08:00
Anthony Towns
a3f74a204e
pk not p
2020-01-19 14:47:33 -08:00
Anthony Towns
efa556aa06
public keys aren't identical
2020-01-19 14:47:33 -08:00
Jonas Nick
8fd629c3f9
Fix privkey negation in taproot_sign_key
2020-01-19 14:47:33 -08:00
Jonas Nick
cc962bf84f
Address sipa's comments
2020-01-19 14:47:33 -08:00
Jonas Nick
c33c7d0a0c
Tag signature hashes, improve rationale and update test vectors
2020-01-19 14:47:33 -08:00
Jonas Nick
7f3611d239
Use a tagged hash in bip-schnorr nonce derivation
2020-01-19 14:47:33 -08:00
Jonas Nick
ba748dcd93
Use key path spend terminology more consistently in taproot/tapscript
2020-01-19 14:47:33 -08:00
John Newbery
680af7db4c
Return a point from lift_x()
2020-01-19 14:47:33 -08:00
John Newbery
bba0bad5e8
Define c in lift_x(x)
2020-01-19 14:47:33 -08:00
John Newbery
1c6b104597
Replace 'quadratic residue of...'
2020-01-19 14:47:33 -08:00
Jonas Nick
16073d0c20
Clarify how to disable key path spending
2020-01-19 14:47:33 -08:00
Jonas Nick
f3bef4f459
Address sipa's feedback
2020-01-19 14:47:33 -08:00
Jonas Nick
a67e5e323c
Update bip-schnorr/test-vectors.py
...
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2020-01-19 14:47:33 -08:00
Jonas Nick
5da30bd568
Update bip-schnorr.mediawiki
...
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2020-01-19 14:47:33 -08:00
Jonas Nick
303ff5fb26
Address Tim's comments
2020-01-19 14:47:33 -08:00
Jonas Nick
08e1b3da74
Use short public keys for taproot output keys
2020-01-19 14:47:33 -08:00
Jonas Nick
e084aafb8b
Switch to 32 byte public keys in bip-schnorr
2020-01-19 14:47:33 -08:00
Jonas Nick
1a4b08ab72
Fix point_from_bytes in bip-schnorr reference implementation
2020-01-19 14:47:33 -08:00
Jonas Nick
b2e6d11a6e
Clarify diagram
2020-01-19 14:47:33 -08:00
Dmitry Petukhov
953dd23665
taproot_output_script: first returned byte should be OP_1 (0x51)
...
If we look at
def IsPayToTaproot(script):
return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1
First byte is is checked for OP_1. OP_1 is 0x51
But the example code in this BIP returns
`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`
First byte 0x01, but it should be 0x51
2020-01-19 14:47:33 -08:00
Mark B Lundeberg
b65cd69467
remove duplicate warning
...
Though perhaps, the emphasis is warranted given its importance. :-)
2020-01-19 14:47:33 -08:00
Jonas Nick
eb96be7a9d
Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'
2020-01-19 14:47:33 -08:00
Pieter Wuille
c7d7034b16
Add taproot/tapscript bips drafts
2020-01-19 14:47:33 -08:00
Pieter Wuille
6e77233b57
Add draft for Schnorr BIP
...
Includes squashed contributions by GitHub users jonasnick,
real-or-random, AustinWilliams, JustinTArthur, ysangkok,
RCassatta, Sjors, tnakagawa, and guggero.
2020-01-19 14:47:33 -08:00
Pieter Wuille
ffa91573d2
Merge pull request #186 from sipa/202001_commonsighash
...
Abstract out common signature message calculation
2020-01-16 13:04:36 -05:00
Pieter Wuille
0e3b6c595c
Address jonas' comments
2020-01-14 10:28:49 -08:00
Pieter Wuille
86eea8adb4
Merge pull request #187 from sipa/202001_acks
...
Update acknowledgements, remove authors
2020-01-14 10:01:09 -05:00
Pieter Wuille
7497bdeceb
Update acknowledgements, remove authors
2020-01-13 14:39:32 -08:00
Pieter Wuille
c0d2f93f3c
Abstract out common signature message calculation
2020-01-13 14:10:26 -08:00
Pieter Wuille
138c62c8b0
Delete precompiled file
2020-01-13 07:27:18 -08:00
Pieter Wuille
bdef41ab58
Merge pull request #185 from sipa/202001_shifted_leaf_v
...
Rewrite leaf versions rationale
2020-01-13 10:26:14 -05:00
Anthony Towns
f978178d6b
go back to leaf_version but different rationale
2020-01-11 06:28:24 +10:00
Pieter Wuille
39a18f4b18
Redefine leaf versions to be incrementally increasing from 0
2020-01-08 07:39:30 -08:00
Pieter Wuille
6a36adea8d
Merge pull request #184 from real-or-random/patch-15
...
clarify nonce generation
2020-01-05 06:06:47 -05:00
Tim Ruffing
63a19990fd
Clarify nonce generation
...
- Separate nonce generation into getting a random byte string and converting it to a suitable scalar ...
- ... to make clear that the byte string can be generated differently.
- Make the warning a little bit more prominent and improve writing
2020-01-03 12:36:25 +01:00
Luke Dashjr
24eddbb48a
Merge pull request #869 from benthecarman/patch-2
...
BIP 174: Specify that separator only appears at end of the map
2020-01-03 04:31:58 +00:00
Luke Dashjr
ed3b31c136
Merge pull request #870 from dgpv/patch-10
...
BIP-174: add missing types to Appendix A; fix proprietary type names
2020-01-03 04:31:45 +00:00
Pieter Wuille
1d2166edc9
Merge pull request #183 from sipa/201912_authors
...
Update authors
2019-12-19 12:41:43 -05:00
Pieter Wuille
ded38826ce
Merge pull request #167 from stefanwouldgo/patch-4
...
more precise wording: limits on tx+block size -> block weight limit
2019-12-19 12:41:25 -05:00
