Jonas Nick
87fa069b8f
Mention SHA256 block size
...
Rebased by Pieter Wuille
2019-09-11 17:43:11 -07:00
Pieter Wuille
7c37e721de
Merge pull request #68 from sipa/nits_real-or-random_patch-6
...
Address some nits
2019-09-11 13:26:43 -07:00
Pieter Wuille
9424700d78
Merge pull request #66 from sipa/jonasnick_design
...
Move plain public key in output rationale to design section (rebase of #44 )
2019-09-11 13:26:13 -07:00
Pieter Wuille
fa423aced9
Address some nits
2019-09-10 16:24:07 -07:00
Pieter Wuille
10073d1ca5
Merge pull request #65 from real-or-random/patch-6
...
Rework Applications section
2019-09-10 16:21:51 -07:00
Pieter Wuille
a02dbdc850
Merge pull request #49 from jonasnick/key-aggregation-security
...
Prescribe that an output key should always have a taproot commitment
2019-09-10 16:13:29 -07:00
Jonas Nick
0995c8a5b5
Move plain public key in output rationale to design section
...
Rebased by Pieter Wuille
2019-09-10 16:03:25 -07:00
Pieter Wuille
eabf7c9a6d
Merge pull request #64 from real-or-random/patch-7
...
Add a footnote about 32-byte security
2019-09-08 13:29:40 -07:00
Tim Ruffing
4a383064fb
Add a footnote about 32-byte security
2019-09-08 16:38:55 +02:00
Tim Ruffing
6d99e45126
Rework Applications section
2019-09-08 16:38:15 +02:00
Pieter Wuille
6653f9f883
Merge pull request #59 from ajtowns/201908-schnorr32-nits
...
32 byte pubkey nits
2019-09-02 08:55:52 -07:00
Pieter Wuille
51a84fd407
Merge pull request #63 from jonasnick/fix-sign-key
...
Fix privkey negation in taproot_sign_key
2019-08-29 17:47:24 -07:00
Jonas Nick
02bdf88ef9
Fix privkey negation in taproot_sign_key
2019-08-29 20:46:47 +00:00
Anthony Towns
30bc716add
note about pubkey collision
2019-08-29 02:35:00 +10:00
Anthony Towns
fc74ec6b35
key gen, verify, sign in intro
2019-08-29 02:35:00 +10:00
Anthony Towns
d3951f63f3
use p for taproot internal key
2019-08-29 02:35:00 +10:00
Anthony Towns
4643538d4f
make secret key a 32-byte array called sk, introduce pubkey()
2019-08-29 02:35:00 +10:00
Anthony Towns
01e1f6e6b2
pk not p
2019-08-29 02:34:59 +10:00
Anthony Towns
e9600e6ed8
public keys aren't identical
2019-08-29 02:34:36 +10:00
Pieter Wuille
e1f199989b
Merge pull request #61 from jonasnick/tagged-derive
...
Use a tagged hash in bip-schnorr nonce derivation
2019-08-27 11:43:45 -07:00
Jonas Nick
dc6b91c1a9
Address sipa's comments
2019-08-27 15:13:08 +00:00
Jonas Nick
775cb2fd90
Tag signature hashes, improve rationale and update test vectors
2019-08-26 20:46:08 +00:00
Jonas Nick
7cd53f6eec
Use a tagged hash in bip-schnorr nonce derivation
2019-08-26 11:32:04 +00:00
Pieter Wuille
de990a1128
Merge pull request #56 from jonasnick/keypath
...
Use key path spend terminology more consistently in taproot/tapscript
2019-08-22 13:09:58 -07:00
Jonas Nick
ed0bb5b0c2
Prescribe that a taproot output key should always have a taproot commitment
2019-08-22 15:49:09 +00:00
Jonas Nick
16bdfcf534
Use key path spend terminology more consistently in taproot/tapscript
2019-08-22 11:41:04 +00:00
Pieter Wuille
abe79d81e3
Merge pull request #58 from sipa/201908_computec
...
Clarify pseudocode of lift_x
2019-08-21 16:24:39 -07:00
Pieter Wuille
de9bc9c72c
Merge pull request #48 from jnewbery/2019-05-quadratic-residue
...
Reword 'quadratic residue of...'
2019-08-21 16:24:19 -07:00
John Newbery
8492968f34
Replace 'quadratic residue of...'
2019-08-21 18:40:40 -04:00
John Newbery
a462876b9a
Return a point from lift_x()
2019-08-21 14:35:23 -07:00
John Newbery
ad91099b8f
Define c in lift_x(x)
2019-08-21 14:22:57 -07:00
Pieter Wuille
4fef743de7
Merge pull request #43 from jonasnick/script-path-only
...
Clarify how to disable key path spending
2019-08-21 12:45:36 -07:00
Pieter Wuille
28dc94f36c
Merge pull request #55 from jonasnick/bip-schnorr32
...
Completely switch to 32-byte public keys in bip-schnorr/taproot/tapscript
2019-08-21 11:37:34 -07:00
Jonas Nick
0d28b3c37b
Address sipa's feedback
2019-08-21 11:42:03 +00:00
Jonas Nick
ae96228913
Update bip-schnorr/test-vectors.py
...
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2019-08-20 10:53:58 +00:00
Jonas Nick
30fdc87599
Update bip-schnorr.mediawiki
...
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2019-08-20 10:53:51 +00:00
Jonas Nick
112d9c150a
Address Tim's comments
2019-08-19 14:37:55 +00:00
Jonas Nick
9795b7081a
Clarify how to disable key path spending
2019-08-18 15:52:46 +00:00
Jonas Nick
5793d3d735
Use short public keys for taproot output keys
2019-08-18 15:04:03 +00:00
Jonas Nick
ed01c1a776
Switch to 32 byte public keys in bip-schnorr
2019-08-18 15:04:03 +00:00
Jonas Nick
1faf705388
Fix point_from_bytes in bip-schnorr reference implementation
2019-08-18 15:04:03 +00:00
Pieter Wuille
084dee847d
Merge pull request #42 from jonasnick/clarify-diagram
...
Clarify description of diagram
2019-05-10 09:52:25 -07:00
Jonas Nick
04b844540e
Clarify diagram
2019-05-10 13:57:12 +00:00
Pieter Wuille
b55fed9f86
Merge pull request #41 from dgpv/patch-1
...
taproot_output_script: first returned byte should be OP_1 (0x51)
2019-05-09 15:19:04 -07:00
Dmitry Petukhov
0c49346c87
taproot_output_script: first returned byte should be OP_1 (0x51)
...
If we look at
def IsPayToTaproot(script):
return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1
First byte is is checked for OP_1. OP_1 is 0x51
But the example code in this BIP returns
`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`
First byte 0x01, but it should be 0x51
2019-05-10 03:09:54 +05:00
Pieter Wuille
27e61d61e6
Merge pull request #40 from markblundeberg/patch-1
...
remove duplicate warning
2019-05-06 13:14:39 -07:00
Mark B Lundeberg
d194620af9
remove duplicate warning
...
Though perhaps, the emphasis is warranted given its importance. :-)
2019-05-06 13:13:20 -07:00
Pieter Wuille
271e5db6d7
Merge pull request #30 from jonasnick/clarify-reduce
...
Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'
2019-05-06 13:11:40 -07:00
Jonas Nick
e9ea1710ef
Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'
2019-05-06 20:09:33 +00:00
Pieter Wuille
6733024595
Add taproot/tapscript bips drafts
2019-05-06 10:46:09 -07:00
