Kalle Rosenbaum
adf4d78e6c
Nits
2019-12-09 21:20:40 +01:00
Pieter Wuille
4c638b3843
Merge pull request #164 from OrfeasLitos/neither-instead-of-both
...
Replace "both are not" with "neither is"
2019-11-29 11:03:54 -05:00
Orfeas Litos
7ec4ce9a8d
Replace "both are not" with "neither is"
2019-11-26 12:39:34 +00:00
Jonas Nick
9208857b92
Rename is_y_square to is_negated in taproot signing
2019-11-22 20:40:20 +00:00
Pieter Wuille
3e3ac64b53
Merge pull request #140 from jonatack/clarify-and-link-to-bip-schnorr-reference-code
...
bip-taproot: clarify bip-schnorr reference code
2019-11-16 12:53:10 -08:00
Pieter Wuille
a00c4a3dc9
Merge pull request #143 from OrfeasLitos/link-to-other-bips
...
Add links to unlinked BIPs
2019-11-16 12:50:17 -08:00
Pieter Wuille
a6d7059ce0
Merge pull request #137 from AdamISZ/hash-0-meaning
...
Add clarification of semantics of 0x00 hash type
2019-11-16 12:49:35 -08:00
Pieter Wuille
aa337b9fbb
Merge pull request #134 from hebasto/20191111-base-point
...
G refers to the secp256k1 base point rather generator
2019-11-16 12:49:11 -08:00
Pieter Wuille
5dab10b0b6
Merge pull request #135 from pyskell/patch-1
...
ADD: Require BIPs for Taproot and Tapscript
2019-11-16 12:48:23 -08:00
Pieter Wuille
bc0c57e1fd
Merge pull request #144 from devrandom/wording
...
Clarify 211 hash bytes and non-reuse of keys
2019-11-15 19:43:39 -08:00
Gregory Sanders
8861bd503a
remind reader where [:] is defined
...
in addition to `point`. This caused confusion for one reader who expected inclusive at end of range.
2019-11-15 13:46:35 -05:00
Dev Random
b8cbd419e6
tweak 211 bytes text
2019-11-14 10:55:32 -08:00
Devrandom
1a9c7f948a
clarify 211 hash bytes and non-reuse of keys
2019-11-13 18:46:05 +01:00
Orfeas Stefanos Thyfronitis Litos
b417bb3c50
Add links to unlinked BIPs
...
Only first mention of each BIP is made into a link
2019-11-13 17:20:09 +00:00
Orfeas Stefanos Thyfronitis Litos
7bce5a0930
Replace R with P in taproot_tweak_seckey
2019-11-13 14:00:03 +00:00
Jon Atack
8b92d05be9
bip-taproot: clarify bip-schnorr reference code
...
- update the paragraph in question to more clearly convey that the helper
functions, and not the Python3 example code, are from the bip-schnorr
reference code
- add a link to the reference code in
https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr/reference.py
2019-11-12 23:07:44 +01:00
Anthony
f620c87eb7
FIX: BIPs should be specified as lowercase to match filenames
2019-11-12 15:47:39 -05:00
Adam Gibson
e5918b3b29
Add clarification of semantics of 0x00 hash type
2019-11-12 11:41:27 +00:00
Anthony
5abcbca343
ADD: Require Schnorr BIP for Taproot
...
Per https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki :
"BIPs may have a Requires header, indicating the BIP numbers that this BIP depends on"
2019-11-11 13:40:42 -05:00
Hennadii Stepanov
7e98e2fd84
G refers to secp256k1 base point rather generator
2019-11-11 20:09:55 +02:00
Agis Anastasopoulos
af1638ce18
Fix typo
2019-11-11 12:39:53 +02:00
LaurentMT
ad4156a394
Fxied typo in taproot_sign_script()
2019-11-11 01:20:28 +01:00
codeShark149
de82b3ad26
Internal pubkey calculation fixed in taproot_tweak_pubkey()
2019-11-06 23:48:29 +05:30
Pieter Wuille
230f6cb734
Merge pull request #125 from fjahr/patch-1
...
Link design section of BIP Schnorr in Specification
2019-11-06 07:44:44 -08:00
Max Hillebrand
78eb015f63
fix: script spend, not key spend
...
For the key spend the script tree depth is not revealed, it is only done for script spends. This sentence makes sense only for the script spend.
2019-11-06 05:58:11 +01:00
Fabian Jahr
08622c9494
Link design section of BIP Schnorr in Specification
2019-11-05 14:53:16 +01:00
Pieter Wuille
2f1c4d80ae
Merge pull request #124 from sipa/square_terminology
...
Settle on notation: is_square(y), has_square_y(P)
2019-11-04 13:59:59 -08:00
Pieter Wuille
0c6a9cffad
Settle on notation: is_square(y), has_square_y(P)
2019-11-04 13:42:24 -08:00
Dmitry Petukhov
db8d6d426f
fix docstring in taproot_output_script
...
the final "-None" line in the docstring of `taproot_output_script` example function was actually outside of the docstring
2019-11-05 02:13:24 +05:00
Dmitry Petukhov
12d8d5baa8
use bytes() instead of b'' - avoid markdown issue
...
Currently github markdown renders `b''` inside `<source>` tags incorrectly. This makes `h = b''` show as `h = b` and creates some confusion.
The issue can be avoided by using bytes() to create empty byte array
2019-11-04 19:15:12 +05:00
Anthony Towns
01e0c43023
annex is bit 0 of spend_type
2019-10-18 13:43:31 +10:00
Pieter Wuille
6b72dfff51
Increase max Merkle path length
2019-10-08 18:57:19 -07:00
Pieter Wuille
15d5aa2732
Fix formula
2019-10-07 14:37:41 -07:00
Pieter Wuille
4aa889e6ac
Merge pull request #77 from sipa/201909_bigger_opspos
...
Extend codeseparator_position and input_index from 16 to 32 bits
2019-10-07 10:45:24 -07:00
Jonas Nick
a6e5c16821
Replace taproot_tweak_pubkey assertion with exception and add it to taproot_tweak_seckey too
2019-09-30 11:15:23 +00:00
Jonas Nick
398897cd29
Add taproot_tweak_pubkey and taproot_tweak_privkey functions to bip-taproot wallet section
2019-09-27 15:36:51 +00:00
Jonas Nick
479fe5f365
Remove 0xc1
2019-09-25 21:02:43 +00:00
Anthony Towns
f831386103
separate p2sh wrapped security rationale
2019-09-25 14:38:13 +10:00
Pieter Wuille
0d5ac28f2c
Extend input_index from 16 to 32 bits
2019-09-24 10:36:41 -07:00
Pieter Wuille
05efb5de84
Merge pull request #71 from sipa/201909_fix_tag_rationale
...
Move/reword tagged hashes motivation
2019-09-23 13:32:51 -07:00
Pieter Wuille
1ee15f7dd9
Remove P2SH support
2019-09-20 19:44:03 -07:00
Pieter Wuille
77dad346ec
Move/reword tagged hashes motivation
2019-09-20 15:01:57 -07:00
Bryan Bishop
1a8818a446
bip-taproot: fix small typo (is does not)
2019-09-16 18:47:54 -05:00
Pieter Wuille
9424700d78
Merge pull request #66 from sipa/jonasnick_design
...
Move plain public key in output rationale to design section (rebase of #44 )
2019-09-11 13:26:13 -07:00
Pieter Wuille
a02dbdc850
Merge pull request #49 from jonasnick/key-aggregation-security
...
Prescribe that an output key should always have a taproot commitment
2019-09-10 16:13:29 -07:00
Jonas Nick
0995c8a5b5
Move plain public key in output rationale to design section
...
Rebased by Pieter Wuille
2019-09-10 16:03:25 -07:00
Pieter Wuille
6653f9f883
Merge pull request #59 from ajtowns/201908-schnorr32-nits
...
32 byte pubkey nits
2019-09-02 08:55:52 -07:00
Jonas Nick
02bdf88ef9
Fix privkey negation in taproot_sign_key
2019-08-29 20:46:47 +00:00
Anthony Towns
d3951f63f3
use p for taproot internal key
2019-08-29 02:35:00 +10:00
Jonas Nick
dc6b91c1a9
Address sipa's comments
2019-08-27 15:13:08 +00:00