1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-02-25 16:04:13 +01:00
Commit graph

36 commits

Author SHA1 Message Date
Pieter Wuille
2f1c4d80ae
Merge pull request #124 from sipa/square_terminology
Settle on notation: is_square(y), has_square_y(P)
2019-11-04 13:59:59 -08:00
Pieter Wuille
0c6a9cffad Settle on notation: is_square(y), has_square_y(P) 2019-11-04 13:42:24 -08:00
Dmitry Petukhov
db8d6d426f
fix docstring in taproot_output_script
the final "-None" line in the docstring of `taproot_output_script` example function was actually outside of the docstring
2019-11-05 02:13:24 +05:00
Dmitry Petukhov
12d8d5baa8
use bytes() instead of b'' - avoid markdown issue
Currently github markdown renders `b''` inside `<source>` tags incorrectly. This makes `h = b''` show as `h = b` and creates some confusion.
The issue can be avoided by using bytes() to create empty byte array
2019-11-04 19:15:12 +05:00
Anthony Towns
01e0c43023 annex is bit 0 of spend_type 2019-10-18 13:43:31 +10:00
Pieter Wuille
6b72dfff51 Increase max Merkle path length 2019-10-08 18:57:19 -07:00
Pieter Wuille
15d5aa2732 Fix formula 2019-10-07 14:37:41 -07:00
Pieter Wuille
4aa889e6ac
Merge pull request #77 from sipa/201909_bigger_opspos
Extend codeseparator_position and input_index from 16 to 32 bits
2019-10-07 10:45:24 -07:00
Jonas Nick
a6e5c16821 Replace taproot_tweak_pubkey assertion with exception and add it to taproot_tweak_seckey too 2019-09-30 11:15:23 +00:00
Jonas Nick
398897cd29 Add taproot_tweak_pubkey and taproot_tweak_privkey functions to bip-taproot wallet section 2019-09-27 15:36:51 +00:00
Jonas Nick
479fe5f365 Remove 0xc1 2019-09-25 21:02:43 +00:00
Anthony Towns
f831386103 separate p2sh wrapped security rationale 2019-09-25 14:38:13 +10:00
Pieter Wuille
0d5ac28f2c Extend input_index from 16 to 32 bits 2019-09-24 10:36:41 -07:00
Pieter Wuille
05efb5de84
Merge pull request #71 from sipa/201909_fix_tag_rationale
Move/reword tagged hashes motivation
2019-09-23 13:32:51 -07:00
Pieter Wuille
1ee15f7dd9 Remove P2SH support 2019-09-20 19:44:03 -07:00
Pieter Wuille
77dad346ec Move/reword tagged hashes motivation 2019-09-20 15:01:57 -07:00
Bryan Bishop
1a8818a446
bip-taproot: fix small typo (is does not) 2019-09-16 18:47:54 -05:00
Pieter Wuille
9424700d78
Merge pull request #66 from sipa/jonasnick_design
Move plain public key in output rationale to design section (rebase of #44)
2019-09-11 13:26:13 -07:00
Pieter Wuille
a02dbdc850
Merge pull request #49 from jonasnick/key-aggregation-security
Prescribe that an output key should always have a taproot commitment
2019-09-10 16:13:29 -07:00
Jonas Nick
0995c8a5b5 Move plain public key in output rationale to design section
Rebased by Pieter Wuille
2019-09-10 16:03:25 -07:00
Pieter Wuille
6653f9f883
Merge pull request #59 from ajtowns/201908-schnorr32-nits
32 byte pubkey nits
2019-09-02 08:55:52 -07:00
Jonas Nick
02bdf88ef9 Fix privkey negation in taproot_sign_key 2019-08-29 20:46:47 +00:00
Anthony Towns
d3951f63f3 use p for taproot internal key 2019-08-29 02:35:00 +10:00
Jonas Nick
dc6b91c1a9 Address sipa's comments 2019-08-27 15:13:08 +00:00
Jonas Nick
775cb2fd90 Tag signature hashes, improve rationale and update test vectors 2019-08-26 20:46:08 +00:00
Jonas Nick
7cd53f6eec Use a tagged hash in bip-schnorr nonce derivation 2019-08-26 11:32:04 +00:00
Jonas Nick
ed0bb5b0c2 Prescribe that a taproot output key should always have a taproot commitment 2019-08-22 15:49:09 +00:00
Jonas Nick
16bdfcf534 Use key path spend terminology more consistently in taproot/tapscript 2019-08-22 11:41:04 +00:00
Pieter Wuille
4fef743de7
Merge pull request #43 from jonasnick/script-path-only
Clarify how to disable key path spending
2019-08-21 12:45:36 -07:00
Jonas Nick
0d28b3c37b Address sipa's feedback 2019-08-21 11:42:03 +00:00
Jonas Nick
112d9c150a Address Tim's comments 2019-08-19 14:37:55 +00:00
Jonas Nick
9795b7081a Clarify how to disable key path spending 2019-08-18 15:52:46 +00:00
Jonas Nick
5793d3d735 Use short public keys for taproot output keys 2019-08-18 15:04:03 +00:00
Jonas Nick
04b844540e Clarify diagram 2019-05-10 13:57:12 +00:00
Dmitry Petukhov
0c49346c87
taproot_output_script: first returned byte should be OP_1 (0x51)
If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51
2019-05-10 03:09:54 +05:00
Pieter Wuille
6733024595 Add taproot/tapscript bips drafts 2019-05-06 10:46:09 -07:00