1
0
mirror of https://github.com/bitcoin/bips.git synced 2024-11-19 09:50:06 +01:00
Commit Graph

52 Commits

Author SHA1 Message Date
Mark "Murch" Erhardt
d06521f432
Merge pull request #1484 from git-sgmoore/master-1
added colon at end of if statement - bip-0119.mediawiki
2024-04-23 13:38:13 -04:00
sgmoore
2f1e2bc4d8
added colon at end of if statement - bip-0119.mediawiki
Python requires a colon at the end of an if statement to denote the beginning of the block of code that will be executed if the condition is True. If the colon is omitted, a syntax error will occur, and the code will not run. Since the syntax error will prevent the code from running, it won't introduce any vulnerabilities by itself. However, it will cause the application to fail at the point where the code is parsed, which might expose other issues if error handling is not implemented properly.
2023-08-15 12:54:34 -07:00
Jeremy Rubin
0033fd876f
Add James O'Beirne to 119 Author List 2023-07-28 17:34:38 -04:00
Luis Miguel
8f506d8e27
Typos in bip-0119 2023-06-06 15:47:37 +02:00
Luke Dashjr
43a48ec0bf
Merge pull request #1319 from JeremyRubin/119-syntax
[BIP-119] Use mediawiki syntax highlighting, add comment to spec
2022-07-25 21:15:16 +00:00
Jeremy Rubin
cde2bd31a2 [BIP-119] Minor wording fixups
Co-authored-by: /dev/fd0 <94559964+1440000bytes@users.noreply.github.com>
2022-05-23 09:47:28 -07:00
Jeremy Rubin
c05f4042f4 [BIP-119] Reword section on fungibility in motivation 2022-05-23 09:35:04 -07:00
Jeremy Rubin
b29a3d27bf [BIP-119] No double space after period, no trailing whitespaces 2022-05-23 09:28:01 -07:00
Jeremy Rubin
de0ff362fc [BIP-119] Slim down motivation, add more references 2022-05-10 09:09:44 -07:00
Jeremy Rubin
aa1871b149 [BIP-119] Make serialization specification complete, defining all functions fully 2022-05-10 08:51:05 -07:00
Jeremy Rubin
ec3688a610 [BIP-119] Clarify Endianness of serializations 2022-05-10 08:38:37 -07:00
Jeremy Rubin
c8c8e27c2c [BIP-119] Use mediawiki syntax highlighting, add comment to spec 2022-05-10 08:33:05 -07:00
Luke Dashjr
77a7213e15
Merge pull request #1309 from JeremyRubin/anti-dos-119
[BIP-119] Clean Up Spec of Opcode
2022-05-05 15:35:48 +00:00
Luke Dashjr
9b120a1036
Merge pull request #1294 from JeremyRubin/patch-7
Update BIP-119 to include python reference hash / link BIP-341
2022-05-05 15:23:20 +00:00
Luke Dashjr
3f6fc801e3 Merge remote-tracking branch 'origin-pull/1267/head' 2022-05-05 15:22:29 +00:00
Jeremy Rubin
78fc9f2ceb [BIP-119]: Make IsPayToBareDefaultCheckTemplateVerifyHash Pythonic 2022-04-28 09:48:47 -07:00
Jeremy Rubin
cad2b3ee77 [BIP-119] Remove C++ Spec from BIP-119 entirely. 2022-04-28 09:48:38 -07:00
Jeremy Rubin
fa09f7f857 [BIP-119] Reimplement CTV in higher level pythonic pseduocode and clarify DoS Caching requirements. 2022-04-28 09:48:23 -07:00
Jeremy Rubin
ba648bc4aa
Update BIP-119 to include python reference hash / link BIP-341 2022-03-29 14:51:43 -07:00
Jeremy Rubin
5901e7079b
[BIP-119] Make it abundantly clear that policy and standard are recommendations. 2022-01-26 15:31:34 -08:00
Jeremy Rubin
9eb17cd296
[BIP-119] Clarify that policy is not validity + what a covenant is. 2022-01-26 01:44:39 -08:00
Luke Dashjr
8530c16c3b
Merge pull request #1273 from JeremyRubin/patch-5
[BIP-119] Rename Channel Factories / Clarify Malleability
2022-01-15 23:28:31 +00:00
Luke Dashjr
abc9e84e73
Merge pull request #1272 from JeremyRubin/patch-4
[BIP-119] Add notes and warnings about DoS during validation of CTV.
2022-01-15 23:27:16 +00:00
Luke Dashjr
0737622713
Merge pull request #1271 from JeremyRubin/patch-3
[BIP-119] Link Reference implementation to current PR in Bitcoin Core
2022-01-15 23:15:35 +00:00
Luke Dashjr
f59f235d91
Merge pull request #1268 from JeremyRubin/patch-1
Fix BIP-119 Typo + Clarify the reasons for 32 bit lengths
2022-01-15 23:14:23 +00:00
Luke Dashjr
01fe8b4615
Merge pull request #1260 from JeremyRubin/ctv-test-vectors
[BIP-0119] Include test vectors for CTV in BIP's subdirectory
2022-01-15 23:14:05 +00:00
Jeremy Rubin
099694efd3
[BIP-119] Rename Channel Factories / Clarify Malleability 2022-01-12 10:54:03 -08:00
Jeremy Rubin
526e9797a7
[BIP-119] Complete fragmented sentence
Co-authored-by: flack <flack@contentcontrol-berlin.de>
2022-01-12 09:53:55 -08:00
Jeremy Rubin
9f642244b9
[BIP-119] Add notes and warnings about DoS during validation of CTV. 2022-01-10 20:23:07 -08:00
Jeremy Rubin
7845a2a799
[BIP-119] Link Reference implementation to current PR in Bitcoin Core 2022-01-10 19:55:26 -08:00
Jeremy Rubin
b96b1712fc
Fix BIP-119 Typo + Clarify the reasons for 32 bit lengths
when drafting the BIP I attempted to triangulate what the width of the fields for number of inputs/outputs should be from various sources in the codebase, and made an error in looking at the signing and encoding logic, and not the _decoding_ logic which restricts vectors (vin, vout) to MAX_SIZE which is 33554432. This fully justifies not using a wider type (uint64_t).

Also clarified arguments for not using a narrower type (uint16_t) which would be possible just for the vIn based on block size, because it's a leaky abstraction (you can still encode and decode such a transaction,  just not mine it).


thanks to @roconnor-blockstream for pointing this out
2022-01-04 16:11:30 -08:00
pox
b705c60a09
typo - letter case 2022-01-03 03:57:51 +02:00
Jeremy Rubin
ae747e2b90 [BIP-0119] Include test vectors for CTV in BIP's subdirectory 2021-12-25 11:07:33 -08:00
Jeremy Rubin
ea6008eeb1 BIP-119: Clarify that Speedy Trial may or may not be implemented for BIP-119 2021-12-22 19:32:05 -08:00
Jeremy Rubin
4479187baf BIP-119: Update Motivations and describe vaults alternatives better 2021-12-22 19:32:05 -08:00
Luke Dashjr
1904334276
Merge pull request #1226 from OrfeasLitos/define-check-119
Define BIP-119 CheckDefaultCheckTemplateVerifyHash
2021-12-15 21:36:04 +00:00
Orfeas Litos
3ff4a4ce9d
Convert inside CheckDefaultCheckTemplateVerifyHash 2021-11-12 01:08:46 +01:00
Orfeas Litos
1839f43779
Fix typo 2021-11-11 23:27:52 +01:00
Orfeas Litos
897e6458ce
Cast 8-vector of u32 to u256 2021-11-10 23:40:20 +01:00
Orfeas Litos
1cab3e87f3
Define BIP-119 CheckDefaultCheckTemplateVerifyHash 2021-11-02 22:36:05 +01:00
Jeremy Rubin
6058f2f669 [BIP-119] Whitspace Consistency 2021-10-16 09:00:48 -07:00
Jeremy Rubin
b305d56352 [BIP-119] Explain Hash Function Choices 2021-10-15 12:47:42 -07:00
Jeremy Rubin
afc605f8e2 [BIP-119] Describe Synergies with future soft fork proposals 2021-10-15 12:47:42 -07:00
Jeremy Rubin
27466fa815 [BIP-119] Better Explain AnyPrevout v.s. CTV 2021-10-15 12:47:42 -07:00
Jeremy Rubin
8364e25ebc [BIP-119] Clarify Draft Deployment Params 2021-10-15 12:47:42 -07:00
Jeremy Rubin
c788bd9d08 Update BIP-119 Variable Names 2021-08-30 10:48:33 -07:00
Tom Harding
4a4f593c8c
Update bip-0119.mediawiki
"susceptibility", but meaning is clear without this word
2020-08-25 09:34:33 -07:00
Luke Dashjr
b38171d14e
Merge pull request #882 from MarcoFalke/patch-2
Fix links in bip-0119.mediawiki
2020-02-20 01:44:51 +00:00
Richard Kiss
3e85c85044
Update bip-0119.mediawiki
Fix typo.
2020-02-01 12:25:27 -08:00
MarcoFalke
a7597ec2c3
Update bip-0119.mediawiki
fix links
2020-01-25 12:10:07 -05:00