1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-02-25 16:04:13 +01:00
Commit graph

7 commits

Author SHA1 Message Date
Luke Dashjr
94073deb66
Merge pull request #967 from vasild/bip155_time_and_varint
BIP155: clarify variable integer format and change time to fixed 32 bit
2020-10-01 14:07:41 +00:00
Vasil Dimov
87ef5aaa7c
BIP155: clarify that "services" uses CompactSize
The Bitcoin Core source code has `VARINT` type which is different than
the "variable integer" format used all over the P2P protocol and also
for the "services" field in this BIP. The latter is called `CompactSize`
in some BIPs and also in the Bitcoin Core source code, thus use the word
`CompactSize` to refer to it and link to its documentation.
2020-09-29 11:12:43 +02:00
Vasil Dimov
2c7630ec61
BIP155: change "time" to fixed 32 bit unsigned
32 bit unsigned can represent time up to year 2106
(32 bit signed is limited to just 2038).

So, we don't need to have "time" encoded as variable integer which would
take 5 bytes instead of 4.
2020-08-13 11:53:30 +02:00
Vasil Dimov
350189ad48
BIP155: use a dedicated message for signalling
Change signaling of support for the new `addrv2` messages to be done via
a dedicated message `sendaddrv2` instead of protocol bump.

The drawback of using a protocol bump is that the protocol version is
not a bitmask and if a node wants to announce support for `addrv2` this
would imply support for all prior features included in that protocol
version.
2020-07-16 20:38:02 +02:00
Vasil Dimov
42ee3f5c15
BIP155: include changes from followup discussions
* Increase the maximum length of an address from 32 to 512 bytes and
  clarify that the entire message should be rejected if it contains
  a longer address.
  (from https://github.com/bitcoin/bips/pull/766#issuecomment-519248699)

* Remove a contradiction about unknown address types - "MUST ignore" VS
  "MAY store and gossip".

* Recommend gossiping addresses for networks to which the node is not
  currently connected to.
  (from https://github.com/bitcoin/bips/pull/766#issuecomment-545067608)

* Clarify that the entire message should be rejected if it contains an
  address with unexpected size (e.g. IPv4 address with length 5).
2020-07-16 20:37:20 +02:00
Wladimir J. van der Laan
e993478060 bip155: Fix comments URL 2019-07-18 00:33:26 +02:00
Wladimir J. van der Laan
34534b5ee1 bip155: fill in BIP number 2019-07-18 00:17:55 +02:00
Renamed from bip-XXXX.mediawiki (Browse further)