1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-02-25 16:04:13 +01:00
Commit graph

12 commits

Author SHA1 Message Date
Jonas Nick
dc6b91c1a9 Address sipa's comments 2019-08-27 15:13:08 +00:00
Jonas Nick
775cb2fd90 Tag signature hashes, improve rationale and update test vectors 2019-08-26 20:46:08 +00:00
Jonas Nick
7cd53f6eec Use a tagged hash in bip-schnorr nonce derivation 2019-08-26 11:32:04 +00:00
Jonas Nick
16bdfcf534 Use key path spend terminology more consistently in taproot/tapscript 2019-08-22 11:41:04 +00:00
Pieter Wuille
4fef743de7
Merge pull request #43 from jonasnick/script-path-only
Clarify how to disable key path spending
2019-08-21 12:45:36 -07:00
Jonas Nick
0d28b3c37b Address sipa's feedback 2019-08-21 11:42:03 +00:00
Jonas Nick
112d9c150a Address Tim's comments 2019-08-19 14:37:55 +00:00
Jonas Nick
9795b7081a Clarify how to disable key path spending 2019-08-18 15:52:46 +00:00
Jonas Nick
5793d3d735 Use short public keys for taproot output keys 2019-08-18 15:04:03 +00:00
Jonas Nick
04b844540e Clarify diagram 2019-05-10 13:57:12 +00:00
Dmitry Petukhov
0c49346c87
taproot_output_script: first returned byte should be OP_1 (0x51)
If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51
2019-05-10 03:09:54 +05:00
Pieter Wuille
6733024595 Add taproot/tapscript bips drafts 2019-05-06 10:46:09 -07:00