mirrors/bitcoin-bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-01-18 21:35:13 +01:00
Code Issues Projects Releases Wiki Activity

Add disableoutputsubstitution= optional parameter

Browse Source
This commit is contained in:
nicolas.dorier 2020-06-18 10:11:20 +09:00
parent 63aa576fac
commit a2a085cdb4
No known key found for this signature in database
GPG Key ID: 6618763EF09186FE
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bip-0078.mediawiki
View File

@ -147,6 +147,8 @@ This fee contribution can't be used to pay for anything else than additional inp
* <code>minfeerate=</code>, a decimal in satoshi per vbyte that the sender can use to constraint the receiver to not drop the minimum fee rate too much. * <code>minfeerate=</code>, a decimal in satoshi per vbyte that the sender can use to constraint the receiver to not drop the minimum fee rate too much.
* <code>disableoutputsubstitution=</code>, a boolean indicating if the sender forbids the receiver to modify his own output, see [[#output-substitution|payment output substitution]]. (default to <code>false</code>)
===Receiver's well known errors=== ===Receiver's well known errors===
If for some reason the receiver is unable to create a payjoin proposal, it will reply with a HTTP code different than 200. If for some reason the receiver is unable to create a payjoin proposal, it will reply with a HTTP code different than 200.
@ -271,7 +273,7 @@ The sender should check the payjoin proposal before signing it to prevent a mali
The sender must be careful to only sign the inputs that were present in the original PSBT and nothing else. The sender must be careful to only sign the inputs that were present in the original PSBT and nothing else.
Note: Note:
* The sender must allow the receiver to add/remove or modify his own outputs * The sender must allow the receiver to add/remove or modify his own outputs (Except is explicitely disabled via the optional parameter <code>disableoutputsubstitution=</code>)
* The sender should allow the receiver to not add any input. Useful for the receiver to change the paymout output scriptPubKey type. * The sender should allow the receiver to not add any input. Useful for the receiver to change the paymout output scriptPubKey type.
* If no input have been added, the sender's wallet implementation should accept the payjoin proposal, but not mark the transaction as an actual payjoin in the user interface. * If no input have been added, the sender's wallet implementation should accept the payjoin proposal, but not mark the transaction as an actual payjoin in the user interface.
@ -421,7 +423,8 @@ public async Task<PSBT> RequestPayjoin(
var ourOutputs = new Queue<(TxOut OriginalTxOut, PSBTOutput SignedPSBTOutput)>(); var ourOutputs = new Queue<(TxOut OriginalTxOut, PSBTOutput SignedPSBTOutput)>();
for (int i = 0; i < originalGlobalTx.Outputs.Count; i++) for (int i = 0; i < originalGlobalTx.Outputs.Count; i++)
{ {
if (signedPSBT.Outputs[i].ScriptPubKey != bip21.Address.ScriptPubKey) if (optionalParameters.DisableOutputSubstitution ||
signedPSBT.Outputs[i].ScriptPubKey != bip21.Address.ScriptPubKey)
ourOutputs.Enqueue((originalGlobalTx.Outputs[i], signedPSBT.Outputs[i])); ourOutputs.Enqueue((originalGlobalTx.Outputs[i], signedPSBT.Outputs[i]));
} }
endpoint = ApplyOptionalParameters(endpoint, optionalParameters); endpoint = ApplyOptionalParameters(endpoint, optionalParameters);