From 50c4f1255eed6b1c08ca9c20b4d8f380879ed2f5 Mon Sep 17 00:00:00 2001 From: nullius Date: Mon, 1 Jan 2018 04:50:24 +0000 Subject: [PATCH] Fix two errors in the BIP 39 French wordlist The BIP 39 wordlist contained two significant technical errors: - Byte Order Marker (BOM) U+FEFF at the beginning of the first line, preceding the word "abaisser". - No newline '\n' char terminating the last line, after "zoologie". The former may cause user loss of funds. An implementation which generates a mnemonic phrase and also turns it into a BIP 39 seed value may feed the string "abaisser" to the KDF, while displaying the word "abaisser" to the user. Of course, it cannot be expected that the user would enter "abaisser" upon attempt to restore a wallet. In the face of a buggy wordlist, whitespace handling and normalization cannot be absolutely relied on to remove a notoriously mischievous character. Those who provide technical support may be well advised to ask French users with unrestorable wallets, "Did your mnemonic phrase contain the word 'abaisser'?" The latter broke the shell script I use to massage wordlists into C sources when building https://github.com/nym-zone/easyseed . I know of only one commonplace platform where software regularly prepends UTF-8 files with a spurious U+FEFF, and oftentimes omits a line terminator on the last line even when asked to create a Unix ('\n') text file. It is RECOMMENDED that new wordlists be examined for correctness using standard shell tools on a sane platform. --- bip-0039/french.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bip-0039/french.txt b/bip-0039/french.txt index 8600949d..1d749904 100644 --- a/bip-0039/french.txt +++ b/bip-0039/french.txt @@ -1,4 +1,4 @@ -abaisser +abaisser abandon abdiquer abeille @@ -2045,4 +2045,4 @@ yacht zèbre zénith zeste -zoologie \ No newline at end of file +zoologie