mirror of
https://github.com/bisq-network/bisq.git
synced 2024-11-19 18:03:12 +01:00
784e2ae894
Exceptions thrown by the core.api services for the daemon Grpc*Services have to be converted into gRPC StatusRuntimeExceptions before being sent to gRPC clients. Most of these gRPC StatusRuntimeExceptions had a gRPC Status.Code.UNKNOWN, which not helpful to client error handlers. This change partially resolves the issue by sending more meaningful io.grpc.Status.Codes to clients, where possible. But it is not as comprehensive as it an be for a webapp because HTTP has so many more possible response status codes than the gRPC library (sixteen). See: https://github.com/grpc/grpc-java/blob/master/api/src/main/java/io/grpc/Status.java There are three types of changes: - Create custom exceptions in bisq.core.api.exception. - Map any custom bisq.core.api.exception to a meaningful io.grpc.Status.Code within daemon Grpc*Service classes. - Adjust apitest cases to new grpc status codes. Based on branch `move-cli-crypto-offer-filter-to-server`, PR https://github.com/bisq-network/bisq/pull/6086 |
||
---|---|---|
.. | ||
main | ||
test/java/bisq/cli |