mirror of
https://github.com/bisq-network/bisq.git
synced 2024-11-19 09:52:23 +01:00
A decentralized bitcoin exchange network
ea8657e8e0
The routine `cleanUpAddressEntries` in TradeManager was prematurely releasing funds associated with trades when they reach the last step of the process (Step 4, Withdraw to External Wallet). Usually, with a single trade active this would not be an issue because `cleanUpAddressEntries` is called after the withdrawal, but if you have more than one trade at Step 4 then the first withdrawal would go though, but all the others would fail with an error box "Missing x.xxx BTC" (the trade proceeds or deposit amount). Alternatively, if you restart the bisq app with a trade in Step 4, the same cleanup will occur and the attempt to withdraw to external wallet will fail. The change here considers any trade held by the TradeManager to be in use and therefore will not have their associated address entries freed up. After Step 4 has passed, the trade is no longer held by the TradeManager, and so cleanUpAddressEntries will at that point free up the address. |
||
|---|---|---|
| .github | ||
| .idea | ||
| assets/src | ||
| cli | ||
| common/src | ||
| core | ||
| daemon/src/main | ||
| desktop | ||
| docs | ||
| gradle | ||
| monitor | ||
| p2p/src | ||
| pricenode | ||
| proto/src/main/proto | ||
| relay | ||
| scripts | ||
| seednode | ||
| statsnode/src/main | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .travis.yml | ||
| build.gradle | ||
| CODEOWNERS | ||
| CONTRIBUTING.md | ||
| gradle.properties | ||
| gradlew | ||
| gradlew.bat | ||
| LICENSE | ||
| Makefile | ||
| pull_request_template.md | ||
| README.md | ||
| settings.gradle | ||
Bisq
What is Bisq?
Bisq is a safe, private and decentralized way to exchange bitcoin for national currencies and other digital assets. Bisq uses peer-to-peer networking and multi-signature escrow to facilitate trading without a third party. Bisq is non-custodial and incorporates a human arbitration system to resolve disputes.
To learn more, see the doc and video at https://bisq.network/intro.
Get started using Bisq
Follow the step-by-step instructions at https://bisq.network/get-started.
Contribute to Bisq
See CONTRIBUTING.md and the developer docs.