mirror of
https://github.com/bisq-network/bisq.git
synced 2025-02-23 06:55:08 +01:00
19b9c6fe59
Problem:d218094set the version to 0.7.0-SNAPSHOT, but that change failed to produce the intended effect detailed in the commit comment. Setting the version to a value like 0.7.0-SNAPSHOT works fine when publishing artifacts to a local ~/.m2 repository, but JitPack has no awareness of version metadata within pom files, and can only retreive artifacts based on Git metadata, namely tags, branch names and commit hashes. This means it is impossible to resolve artifacts from JitPack with a GAV like `io.bisq.exchange:core:0.7.0-SNAPSHOT` unless there is a branch named `0.7.0`. This is why the pull request at bisq-network/bisq-seednode#1 failed. Solution: JitPack supports the semantics of Maven-style `-SNAPSHOT` versioning, and as a special case, allows for versions to be named literally `-SNAPSHOT` with no preceding version string [1,2]. This commit sets all Maven versions to `-SNAPSHOT`, achieving the original effect intended byd218094. Now downstream components (like bisq-seednode) can resolve dependencies seamlessly from JitPack or a local ~/.m2 repo with a GAV like `io.bisq.exchange:core:-SNAPSHOT`. This is a slightly unconventional arrangement, but should actually result in fewer updates to pom files over time as there may in fact be no reason to ever change this version string so long as we continue using JitPack and avoid publication to Maven Central / JCenter or similar. [1]: https://jitpack.io/docs/#building-with-jitpack [2]: https://github.com/jitpack/jitpack.io/issues/351 See #1440
15 lines
502 B
XML
15 lines
502 B
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<project xmlns="http://maven.apache.org/POM/4.0.0"
|
|
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
|
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
|
|
<parent>
|
|
<artifactId>parent</artifactId>
|
|
<groupId>io.bisq.exchange</groupId>
|
|
<version>-SNAPSHOT</version>
|
|
</parent>
|
|
<modelVersion>4.0.0</modelVersion>
|
|
|
|
<artifactId>consensus</artifactId>
|
|
|
|
|
|
</project>
|