Chris Beams 3d991e009a Qualify relative --configFile value with appDataDir ... This behavior had already been implemented prior to this commit, but has now been tested and improved with refactoring and logging messages. Note that this approach emulates Bitcoin Core's own behavior. When running, for example, `bitcoind -conf=rel/path/to/bitcoin.conf`, the relative path is prefixed / fully qualified by the value of the `datadir` option. So if `datadir` equals `~/Library/Application Support/Bitcoin`, then the `conf` option value above would be fully qualified as ~/Library/Application Support/Bitcoin/rel/path/to/bitcoin.conf If the argument to `-conf` is an absolute path, e.g. `/tmp/bitcoin.conf`, then that absolute path is used without further modification or qualification. It is assumed that the rationale for this behavior is to avoid accidentally running against the wrong conf file because `bitcoind` was invoked in a different directory than usual or because a malicious actor replaced the relative conf file with their own version. Bisq's new `--configFile` option works (and is now tested to work) in the same way: relative paths get prefixed by the value of Config.getAppDataDir(), and absolute paths are processed unmodified.		2020-01-20 16:47:52 +01:00
..
src	Qualify relative --configFile value with appDataDir	2020-01-20 16:47:52 +01:00