mirror of
https://github.com/bisq-network/bisq.git
synced 2025-02-27 00:07:56 +01:00
Created new PhoneNumberValidator + Test. Validator hides no arg constructor; public constructor requires two letter ISO country code for validating inputs. After successful validation, inputs are transformed into E.164 format and cached in a field, accessible via a getter method. However, area and region codes are not checked for correctness. End users are responsible for correctness of area/region codes. Four i18n properties (validation.phone.*) were added to displayStrings.properties This is a partial fix for Issue #3042. The validator will be integrated into the GUI if PR is approved & patch is merged. Question for Bisq devs: Another new pkg protected class, CountryCallingCodes, contains an immutable map of ISO country codes -> country calling codes; it is the only non-validator class in its package. The map declaration is too large to live in the PhoneNumberValidator class, even after tweaking idea.properties in an attempt to prevent the IDE from freezing. Is it OK to leave CountryCallingCodes where it is, or is there a more appropriate home for it? |
||
---|---|---|
.. | ||
bisq/desktop | ||
org/bitcoinj/core |