mirror of
https://github.com/bisq-network/bisq.git
synced 2025-02-23 23:06:39 +01:00
Replace faulty cell update logic, which uses a ChangeListener<Scene>, added in July 2017 (#73f21399) to keep the price column in the offer book table up to date, as it appears to occasionally result in blank cells. Also it seems only the prices, not the volumes, were being kept in sync with the market price feed. Make the price and volume cells stateless and keep them in sync with the market feed by adding it as a dependency of each OfferBookListItem Observable generated by the cell value factory, instead of directly attaching listeners to it. In this way, TableCell::updateItem will be called by the framework whenever the price/volume needs updating. (This does have the disadvantage that if the price feed is unavailable, causing Offer::getPrice to return null, then the cells will reflect that immediately instead of showing any old, stale values, but that is necessary for the UI to behave consistently anyway.) |
||
---|---|---|
.. | ||
package | ||
src |