Commit Graph

5681 Commits

Author SHA1 Message Date
sqrrm
e6b7c88bed
Lower min deposit to 0.001 BTC
Lower min refund to half of min deposit as it doesn't make sense to have
a higher min refund than the min deposit.
2021-03-18 13:44:05 +01:00
Christoph Atteneder
9270398fb3
Merge pull request #5207 from jmacxx/improve_dispute_chat
Improve chat functionality of mediation/arbitration
2021-03-17 09:38:35 +01:00
Christoph Atteneder
16230c7723
Merge pull request #5316 from chimp1984/add-pay-from-bsq-wallet-button
Add pay from BSQ wallet button
2021-03-17 09:35:09 +01:00
Christoph Atteneder
033ec325d2
Merge pull request #5318 from sqrrm/lower-unsigned-size
Lower tolerated small amount
2021-03-17 09:27:02 +01:00
sqrrm
99123b7297
Lower tolerated small amount
Split tolerated amount for placing offers with unsigned accounts
and tolerated amount for taking offers.
2021-03-16 13:07:42 +01:00
chimp1984
2702a7eff4
Add button to buyers trade step 2 view in case of a BSQ
trade to fill in the amount and address to the BSQ send view.
2021-03-15 17:58:05 -05:00
jmacxx
ad4927a666
code review changes requested by @ripcurlx
renamed alertCountProperty to badgeCountProperty
changed the badge counting policy so that the count of chat messages does not contribute to the badge number, but merely the presence of chat messages, and/or the new flag.
show an explanatory message when trader is not allowed to close own dispute ticket
removed some comments and code that were accidentally included from PR5160
renamed variable tpe to tradePeriodEnd
renamed variable cptyName to counterpartyName
clear the new badge on double-click of dispute tablerow
2021-03-15 17:24:00 -05:00
chimp1984
80c23883c8
Add popup for summary of trade history 2021-03-15 16:30:11 -05:00
chimp1984
b421605345
Add formatCoin method with appendCode param
Remove @NotNull annotation (unnecessary verbose, default is non null, if null then we annotate with @Nullable)
2021-03-15 11:07:12 -05:00
sqrrm
edbac95f7c
Merge pull request #5292 from ghubstan/00-fix-corecontext-usage
Fix singleton CoreContext usage
2021-03-11 17:24:55 +01:00
Christoph Atteneder
0e6ce20453
Merge pull request #5216 from huey735/rename-summary-notes-category
Rename summary notes "Seller not responding"  category
2021-03-11 17:01:56 +01:00
Christoph Atteneder
caac1b4c1e
Merge pull request #5272 from BtcContributor/fixbackupbutton
Fix Set Password text button
2021-03-11 16:07:26 +01:00
BtcContributor
2c945b0c40
change text and navigation 2021-03-11 15:55:47 +01:00
sqrrm
a1939f92e6
Merge pull request #5222 from ripcurlx/fix-key-shortcut-documentation
Fix key shortcut documentation when using CMD+Y
2021-03-11 11:55:53 +01:00
Christoph Atteneder
7394da5462
Merge pull request #5206 from jmacxx/improve_mediation_tools
Improve mediation tools / logging.
2021-03-11 11:49:58 +01:00
Christoph Atteneder
43b8f0afbf
Merge pull request #5209 from JaredBoone/master
Changes "Verify result" to "Check signature"
2021-03-11 09:36:44 +01:00
sqrrm
eabb173767
Add NGN as a default currency 2021-03-10 14:41:28 +01:00
ghubstan
58100fda6a
Fix singleton CoreContext usage
After GrpcServer builds a gRPC server instance, it calls injected
CoreContext#setApiUser(true).  The same, singleton CoreContext object
is injected into CoreService constructors, which use the coreContext#
isApiUser value (set true by the server builder) to set their own class
level boolean isApiUser fields.

When CoreContext was added, I was fooled by the correct behavior I
saw while stepping through the server debugger.  But now I see that
the correct boolean value in CoreContext is only available after
CoreService constructors have finished instantiating themselves -
- not in time.

In this change, the CoreContext becomes a class level final field
in CoreServices, and the correct coreContex.isApiUser value is available
in the CoreService methods.
2021-03-10 08:26:14 -03:00
sqrrm
463f87b39e
Merge pull request #5284 from ghubstan/07-validate-paymentacct-n-new-offer
Validate offer <-> payment-acct in createoffer
2021-03-09 16:51:56 +01:00
ghubstan
2161c936f1
Adjust canceloffer to getmyoffer bugfix (commit d6c79fc) 2021-03-08 16:36:01 -03:00
ghubstan
d6c79fca70
Filter out 'my' offers from 'available' offers 2021-03-08 16:26:16 -03:00
ghubstan
04b52f873e
Fix setSelectedCurrency bug, and replace unnecessary reflection usage
Commit de59c0a5f9 did not persist the
assigned selected currency, this fixes the bug.
2021-03-08 16:02:18 -03:00
ghubstan
de59c0a5f9
Assign selected trading currency on new payment accts (api only)
If a new account has a trading currency, assign it as the selected trading currency.

Also fixed a payment acct console formatting issue (left justify the ccy code).
2021-03-08 15:22:28 -03:00
ghubstan
b4f4d90e05
Add tradeCurrencies field to Transferwise acct form
These changes make tradeCurrencies a required twise acct form field.

Addresses issue https://github.com/bisq-network/bisq/issues/5281

- Added comment to PaymentAccountForm about special 'tradeCurrencies' field handling.
- Added support for Transferwise 'tradeCurrencies' to PaymentAccountTypeAdapter.
- Added instance of isTransferwiseAccount check to PaymentAccount.
- Added methods to CurrencyUtil to convert comma delimited code list to TradeCurrency list.
- Added methods to ReflectionUtil for getting fields and methods on class.
- Added required field check to CorePaymentAccountsService.
- Added CreatePaymentAccount test cases.
2021-03-08 14:47:30 -03:00
ghubstan
baca7001ea
Fix unnecessary use of fully qualified name 'String.format' 2021-03-07 20:05:39 -03:00
ghubstan
99fea74e09
Validate offer <-> payment-acct in createoffer
This change prohibits creation of new offers with incompatible payment
accounts with the api.

- PaymentAccountUtil
  Renamed isAnyTakerPaymentAccountValidForOffer -> isAnyPaymentAccountValidForOffer.
  Renmaed isTakerPaymentAccountValidForOffer -> isPaymentAccountValidForOffer.
  Deleted commented code.

- PaymentAccounts: Adjusted to PaymentAccountUtil method name changes.

- OfferFilter: Adjusted to PaymentAccountUtil method name changes.

- OfferBookViewModelTest: Adjusted to PaymentAccountUtil method name changes.

- Add CoreOffersService#verifyPaymentAccountIsValidForOffer

- ValidateCreateOfferTest, OfferTest: Added test cases.
2021-03-07 19:51:29 -03:00
chimp1984
f43dc2032f
Handle flush at shutdown differently to flush at backup 2021-03-06 12:02:17 -05:00
chimp1984
569a2de641
Call onAllServicesInitialized on PersistenceManager and
prevent write to disk before it is called.

In case the user started Bisq 2 times, the second process
would have called the flushAllDataToDisk at shutdown and
overwrote data from the running app.
2021-03-06 10:24:25 -05:00
jmacxx
cc56470b2f
Improve chat functionality of mediation/arbitration
Show badge with number of unread chat messages on each ticket
Use icons for chat, info and process ticket functions
Select a row by clicking on it, no clunky select button needed.
Show chat messages in a movable popup window.
More space for ticket list.

Implement requested feature additions:

Indicate if the trade period is over
Indicate more clearly the sender of each chat message
Support badge count
Indicate the XMR tx proof (when applicable)
Allow trader to close own mediation ticket if the trade is paid out

Fixes:

null check for cases when extraData null/not applicable
when upgrading closed disputes, clear chat unread count
2021-03-03 18:41:17 -06:00
BtcContributor
ba5705ca74
fix setpassword text button 2021-03-03 12:13:10 +01:00
Christoph Atteneder
0c9d278629
Merge pull request #5235 from jmacxx/mempool_minimumFee
Obtain minimumFee from mempool api in place of hardcoded value
2021-03-01 11:18:16 +01:00
sqrrm
80c722803d
Merge pull request #5247 from bisq-network/release/v1.5.7
Release/v1.5.7
2021-02-26 22:34:08 +01:00
jmacxx
fd7ce51bf9
Field id strings for FeeService extracted to Config.java 2021-02-25 11:51:40 -06:00
ghubstan
e125ba8ab8
Prepare to adjust api to new minimum fee per vbyte (from feeService)
Commit c33ac1b983 changed the source of
the min tx fee rate, and the api will adjust after the associated PR
is merged.  For now, the required change is a comment.
2021-02-25 11:53:12 -03:00
ghubstan
b725f06514
Adjust api to new minimum fee per vbyte
The BaseCurrencyNetwork#getDefaultMinFeePerVbyte now returns
15 (sats/byte) since commit b341bb6e89.

This change adjusts the api to the new min tx fee rate by validating
the api's setTxFeeRatePreference param, and throwing an appropirate
exception if the param value is below the minimum.  Also adjusted a broken
test, and added a new test to check the appropriate exception is received
from the server.
2021-02-25 11:31:13 -03:00
jmacxx
be78f47b0e
Update Preferences tests to new constructor signature 2021-02-25 08:27:30 -06:00
ghubstan
3dde3cbeef
Fix typo in toString 2021-02-25 10:37:30 -03:00
jmacxx
c33ac1b983
Obtain minimumFee from mempool api in place of hardcoded value 2021-02-24 22:47:06 -06:00
Christoph Atteneder
0feb1079b8
Merge pull request #5223 from BtcContributor/lengthcheck
Fix length check text on manual payout tool
2021-02-24 10:33:06 +01:00
jmacxx
dab8b638ae
TraderChatManager to handle onAllServicesInitialized
Upon receipt of onAllServicesInitialized, TraderChatManager should
call tryApplyMessages in order to process any pending mailbox
messages stored up while offline.
2021-02-24 09:14:02 +01:00
jmacxx
b3263be5e9
Fix initialization ordering issue
TradeManager must be inited before MailboxMessageService
2021-02-24 09:13:52 +01:00
jmacxx
d3b62b1a58
TraderChatManager to handle onAllServicesInitialized
Upon receipt of onAllServicesInitialized, TraderChatManager should
call tryApplyMessages in order to process any pending mailbox
messages stored up while offline.
2021-02-23 21:12:59 -06:00
BtcContributor
6edb318236
Fix length check text on manual payout tool 2021-02-23 17:57:47 +01:00
Christoph Atteneder
5951e140e3
Fix key shortcut documentation when using CMD+Y
This behavior change as you cannot manually fails an open trade anymore. Only unfail it after selecting it in the failed trades section and pressing CMD+Y
2021-02-23 09:23:31 +01:00
jmacxx
0e5c7e5de7
Fix initialization ordering issue
TradeManager must be inited before MailboxMessageService
2021-02-22 17:56:30 -06:00
Christoph Atteneder
aae52f801a
Update translations for v1.5.7 2021-02-22 15:54:53 +01:00
Christoph Atteneder
c30fd72990
Update bitcoinj checkpoints for v1.5.7 2021-02-22 15:51:33 +01:00
Huey
b8d24291b7
Rename summary notes "Seller not responding" category
I renamed the string for the
disputeSummaryWindow.reason.SELLER_NOT_RESPONDING key because
BTC buyers can also be unresponsive.
2021-02-22 10:16:32 +00:00
Jared Boone
5ddce75213
resolves #5208 2021-02-19 17:12:35 -08:00
Christoph Atteneder
314e6ce314
Merge pull request #5142 from chimp1984/add-coin-input-control
Add coin input control
2021-02-19 19:13:31 +01:00