PhoneNumberValidator + Test Changes:
Added no-arg constuctor required for Guice injection.
Added isoCountryCode setter; this field must be set before
validation.
Added validation of isoCountryCode.
Added missing country code test.
SwishValidator Changes:
SwishValidator now extends PhoneValidator.
Added no-arg constuctor required for Guice injection.
Set isoCountryCode = SE in constructor.
SwishForm Changes:
Sets Swish acct phone number to normalized phone number if
phone # validation is successful.
Replaced Logger declaration with @Slf4j annotation.
Formatted source.
Added 'validation.phone.missingCountryCode' property to i18n file.
Created new PhoneNumberValidator + Test. Validator hides
no arg constructor; public constructor requires two letter
ISO country code for validating inputs.
After successful validation, inputs are transformed into E.164
format and cached in a field, accessible via a getter method.
However, area and region codes are not checked for correctness.
End users are responsible for correctness of area/region codes.
Four i18n properties (validation.phone.*) were added to
displayStrings.properties
This is a partial fix for Issue #3042. The validator
will be integrated into the GUI if PR is approved & patch is
merged.
Question for Bisq devs:
Another new pkg protected class, CountryCallingCodes, contains
an immutable map of ISO country codes -> country calling codes;
it is the only non-validator class in its package. The map
declaration is too large to live in the PhoneNumberValidator class,
even after tweaking idea.properties in an attempt to prevent
the IDE from freezing. Is it OK to leave CountryCallingCodes
where it is, or is there a more appropriate home for it?
When loading the preferences view, it would always log a warning
indicating that DAO full node is selected without providing required
parameters even though it wasn't selected.
Bisq's SearchComboBox implements a simple autocomplete. It is used
on the "add new altcoin account" form.
This fixes the following bugs in the SearchComboBox:
* no more dropdown flickering (fixed hide+show hack)
* space key no longer resets the text input
* unconfirmed changes no longer affect the form
* empty list no longer renders empty dropdown
This is a preparation step for using SearchComboBox more widely
in the project.
When activating the ProposalsView, the table height is updated on the
user thread. Sometimes the scene is unavailable and causes a
NullPointerException. This should at least prevent the exception.
Fixes#2883 and #3116
When adding a payment account Bisq requires IBAN to be whitespace free.
It is annoying for the user to manually clean pasted IBAN of spaces.
In online banking IBAN-s are usually displayed *with* spaces for
better readability.
This commit auto-removes whitespace when user is leaving the input
field, right before validation, effectively allowing to paste
real world IBAN-s.
When exporting to CSV, both portfolio/trades and funds/transactions
were lacking the column headers.
Additionally, portfolio/trades colum values were outdated and
not matching the intended export.
Both issues are fixed.
this is the correct way to do it. the way it is currently done means
that if a component is not declared in a module, guice still finds it
but does not use the singleton lifecycle
binding as singleton in the module is meant to be used for classes that
we don't have the sourcecode for (i.e. jdk classes)
