Issue: When attempting to create an offer without a trading account for
the selected currency, a prompt is shown asking the user whether to still
create an offer or to create a new account. But this prompt is missing a
cancel/close button in case you don't want to do either action. And
pressing Esc on the keyboard proceeds to create the account.
Cause: The close button on the prompt was renamed and being used to
create a new account.
Fix: Use the close button as a close button and add a secondary action
button to create a new account. The popup width was increased to
accommodate the long button text without being truncated.
We don't want to burn BSQ in cases like that the tx was published too
late, which is a valid case if the tx does not make it in the next block.
We set such txs as IRREGULAR and allow spending of the BSQ, but there
function in the governance is invalidated.
We also add a check if the sum of all UTXO is the same as the sum of the
genesis + sum of issuance txs - burned fees.
We limit the possible max. issuance (including reimbursements) to the
valued defined in the ISSUANCE_LIMIT param.
In case we exceed that limit the whole cycle becomes invalid.
The main reason for that feature is limitation of max.
damage in case that an attacker manages to create unjustified issuance.
For valid cases we consider such a case as social consensus problem as
the majority of voters should be aware of that limit before they
accept such a high issuance. If known in advance that an extraordinary
high issuance is expected the DAO parameter can be changed.
We only want to show active bonds in the list for confiscation.
The Inactive bond label is not necessary in the vote result as a
confiscated bond is inactive anyway. Intention was probably to show it
as inactive in the proposal display but they will be filtered out
anyway there.
Use lockup and unlock tx for miner fee and tx size display.
The getMiningFeeAndTxSize in daoFacade was used for blind vote. Got
renamed in the meantime to make it more clear.
Issue: When shutting down the application with disabled open offers, the
confirmation popup was still being shown informing the user there are
open offers.
Fix: On shutdown, check all open offers and only show the popup if any
of them are enabled.
Fixes#2115
