Commit graph

14232 commits

Author SHA1 Message Date
ghubstan
d3b5e1ee4b
Alternate ports to improve api/protocol guide 2021-03-18 12:56:18 -03:00
Christoph Atteneder
87d8f5f28a
Merge pull request #5160 from jmacxx/mempool_check_maker_tx
Verify maker & taker fee transactions via Mempool lookup
2021-03-17 22:38:54 +01:00
jmacxx
47ad4219e2
Merge branch 'master' into mempool_check_maker_tx 2021-03-17 16:26:38 -05:00
Christoph Atteneder
3b897085b1
Merge pull request #5325 from jmacxx/fix_not_synced_bitcoind
Prevent trading when not connected to the Bitcoin network
2021-03-17 22:25:37 +01:00
jmacxx
9fcd65f320
Validate maker/taker fees using mempool lookup
apply @chimp1984 patch.txt code review suggestions
taker tx check moved to trade step 2, after confirmation
solve issue with calculating expected fees for unconfirmed tx
resolve conflict with PR5207 (Disputes UI)
check new offers after 1 block; check Json string not null; warn -> info
remove unused parameter
remove debugging log.warn message
2021-03-17 16:23:18 -05:00
jmacxx
8dd2328b03
handle case where bitcoind chain height is stale
improve description of chain height display
2021-03-17 16:00:57 -05:00
Christoph Atteneder
38cdea740b
Merge pull request #5323 from wallclockbuilder/patch-4
Update commands for mediator/refund agent
2021-03-17 10:23:25 +01:00
Christoph Atteneder
9270398fb3
Merge pull request #5207 from jmacxx/improve_dispute_chat
Improve chat functionality of mediation/arbitration
2021-03-17 09:38:35 +01:00
Christoph Atteneder
16230c7723
Merge pull request #5316 from chimp1984/add-pay-from-bsq-wallet-button
Add pay from BSQ wallet button
2021-03-17 09:35:09 +01:00
Christoph Atteneder
033ec325d2
Merge pull request #5318 from sqrrm/lower-unsigned-size
Lower tolerated small amount
2021-03-17 09:27:02 +01:00
Mawueli Kofi Adzoe
baa2f2bd9b
Update commands for mediator/refund agent
Commands are flipped in the documentation.
CMD+D for Mediator
CMD+N for Refund Agent
2021-03-17 00:26:25 -07:00
jmacxx
f93f202f8d
process icon use GAVEL 2021-03-16 19:33:29 -05:00
jmacxx
ae9e6dad59
double-click opens chat window 2021-03-16 07:23:23 -05:00
sqrrm
99123b7297
Lower tolerated small amount
Split tolerated amount for placing offers with unsigned accounts
and tolerated amount for taking offers.
2021-03-16 13:07:42 +01:00
Christoph Atteneder
64ab053b1b
Merge pull request #5315 from chimp1984/improve-portfolio-history
Improve portfolio history
2021-03-16 11:03:29 +01:00
chimp1984
2702a7eff4
Add button to buyers trade step 2 view in case of a BSQ
trade to fill in the amount and address to the BSQ send view.
2021-03-15 17:58:05 -05:00
jmacxx
ad4927a666
code review changes requested by @ripcurlx
renamed alertCountProperty to badgeCountProperty
changed the badge counting policy so that the count of chat messages does not contribute to the badge number, but merely the presence of chat messages, and/or the new flag.
show an explanatory message when trader is not allowed to close own dispute ticket
removed some comments and code that were accidentally included from PR5160
renamed variable tpe to tradePeriodEnd
renamed variable cptyName to counterpartyName
clear the new badge on double-click of dispute tablerow
2021-03-15 17:24:00 -05:00
chimp1984
80c23883c8
Add popup for summary of trade history 2021-03-15 16:30:11 -05:00
chimp1984
1e593205d7
Fix taker trade fee amount.
We need to use fee from trade not from offer
2021-03-15 11:34:37 -05:00
chimp1984
e2a99a988a
Fix incorrect taker trade fee.
We had only displayed the fee for 1 tx, but taker pays 3 times that fee.
The real miner fee is a bit higher in case we used BSQ as we add the
burned BSQ to miner fee, we ignore that small difference as it would
add more complexity and for that use case it't not that important to
be exact.
2021-03-15 11:15:21 -05:00
chimp1984
5327657806
Various improvements to make make work with csv data easier
Separate volume with currency (add new column for currency)
Separate trade fee in btc and bsq, remove currency from value
Replace "-" with empty string

Improve detection of bsq fee tx. Previous version was more complicate
and would not have covered case where BSQ fee input matches exactly
required fee so not BSQ output would have been created.
2021-03-15 11:12:57 -05:00
chimp1984
b421605345
Add formatCoin method with appendCode param
Remove @NotNull annotation (unnecessary verbose, default is non null, if null then we annotate with @Nullable)
2021-03-15 11:07:12 -05:00
Christoph Atteneder
6148b610a0
Merge pull request #5231 from BtcContributor/bankidcopy
Fix copy of BankName value + BranchId/BankId
2021-03-12 09:54:00 +01:00
jmacxx
35f6ea2508
color of new badge should be red 2021-03-11 11:36:21 -06:00
BtcContributor
fbf7af8093
Change naming of variables and methods 2021-03-11 17:37:32 +01:00
sqrrm
edbac95f7c
Merge pull request #5292 from ghubstan/00-fix-corecontext-usage
Fix singleton CoreContext usage
2021-03-11 17:24:55 +01:00
Christoph Atteneder
0e6ce20453
Merge pull request #5216 from huey735/rename-summary-notes-category
Rename summary notes "Seller not responding"  category
2021-03-11 17:01:56 +01:00
Christoph Atteneder
9a2dbd7147
Merge pull request #5215 from jmacxx/fix_issue_5214
Fix Multiple Warnings on Enable All Offers
2021-03-11 17:01:05 +01:00
Christoph Atteneder
e1e7ca6cba
Merge pull request #5295 from bisq-network/hotfix/v1.5.9
Hotfix/v1.5.9
2021-03-11 16:54:41 +01:00
Christoph Atteneder
d57df53146
Merge pull request #5248 from cd2357/tor-update-guide
Document tor upgrade steps
2021-03-11 16:33:32 +01:00
Christoph Atteneder
38a9bf0277
Merge branch 'master' of github.com:bisq-network/bisq into hotfix/v1.5.9
# Conflicts:
#	build.gradle
#	desktop/package/linux/Dockerfile
#	desktop/package/linux/package.sh
#	desktop/package/linux/release.sh
#	desktop/package/macosx/create_app.sh
#	desktop/package/macosx/finalize.sh
#	desktop/package/macosx/insert_snapshot_version.sh
#	desktop/package/windows/package.bat
#	desktop/package/windows/release.bat
#	relay/src/main/resources/version.txt
2021-03-11 16:26:50 +01:00
Christoph Atteneder
fb053e85ad
Revert to SNAPSHOT version 2021-03-11 16:24:32 +01:00
Christoph Atteneder
944fa7e120
Merge pull request #5232 from BtcContributor/darkread
Fix dark mode readibility of specific texts
2021-03-11 16:22:59 +01:00
Christoph Atteneder
caac1b4c1e
Merge pull request #5272 from BtcContributor/fixbackupbutton
Fix Set Password text button
2021-03-11 16:07:26 +01:00
BtcContributor
2c945b0c40
change text and navigation 2021-03-11 15:55:47 +01:00
BtcContributor
144b3e4f9a
fix css 2021-03-11 13:23:39 +01:00
sqrrm
a1939f92e6
Merge pull request #5222 from ripcurlx/fix-key-shortcut-documentation
Fix key shortcut documentation when using CMD+Y
2021-03-11 11:55:53 +01:00
Christoph Atteneder
7394da5462
Merge pull request #5206 from jmacxx/improve_mediation_tools
Improve mediation tools / logging.
2021-03-11 11:49:58 +01:00
Christoph Atteneder
337c7bb0cd
Merge pull request #5291 from wallclockbuilder/master
Fix typo
2021-03-11 11:35:45 +01:00
Mawueli Kofi Adzoe
dda2570ee6
Fix
typo in test function name.
2021-03-11 02:26:18 -08:00
sqrrm
f97595ddc2
Merge pull request #5239 from ripcurlx/update-release-process
Add step for signature creation for Arch Linux
2021-03-11 10:22:08 +01:00
Christoph Atteneder
43b8f0afbf
Merge pull request #5209 from JaredBoone/master
Changes "Verify result" to "Check signature"
2021-03-11 09:36:44 +01:00
Christoph Atteneder
9635ed5416
Merge pull request #5293 from sqrrm/make-ngn-default
Add NGN as a default currency
2021-03-11 09:25:28 +01:00
Christoph Atteneder
0130e81600
Adapt new version number placeholder to be conform with Bash specification 2021-03-11 09:20:29 +01:00
sqrrm
eabb173767
Add NGN as a default currency 2021-03-10 14:41:28 +01:00
ghubstan
58100fda6a
Fix singleton CoreContext usage
After GrpcServer builds a gRPC server instance, it calls injected
CoreContext#setApiUser(true).  The same, singleton CoreContext object
is injected into CoreService constructors, which use the coreContext#
isApiUser value (set true by the server builder) to set their own class
level boolean isApiUser fields.

When CoreContext was added, I was fooled by the correct behavior I
saw while stepping through the server debugger.  But now I see that
the correct boolean value in CoreContext is only available after
CoreService constructors have finished instantiating themselves -
- not in time.

In this change, the CoreContext becomes a class level final field
in CoreServices, and the correct coreContex.isApiUser value is available
in the CoreService methods.
2021-03-10 08:26:14 -03:00
sqrrm
463f87b39e
Merge pull request #5284 from ghubstan/07-validate-paymentacct-n-new-offer
Validate offer <-> payment-acct in createoffer
2021-03-09 16:51:56 +01:00
ghubstan
389abf459d
Check valid createoffer opt values with asserts 2021-03-09 10:43:05 -03:00
sqrrm
343d311a25
Merge pull request #5273 from ghubstan/05-doc-test-disputeagents
Document test harness dispute agent registration
2021-03-09 11:53:28 +01:00
sqrrm
3ab184c8da
Merge pull request #5259 from ghubstan/04-fix-feerate-validation-bug
Fix CLI number opt validation, improve server-not-up msg
2021-03-09 11:52:29 +01:00