Commit graph

5308 commits

Author SHA1 Message Date
chimp1984
8ab16e5e3a
Add new burningman address for delayed payout txs
See; https://github.com/bisq-network/roles/issues/80#issuecomment-723577776
2020-11-08 18:38:02 -05:00
jmacxx
8484398dee
Remove default fee rate from Bisq startup screen
The display of fee rate on the startup screen is misleading because
at startup a fee has not been received from the mempool fee service
and instead the default value of 50 sats is shown.

This change causes the fee rate not to be displayed until a response
has been received from the service.

Fixes #4765
2020-11-08 08:38:05 -06:00
Oscar Guindzberg
c4131c7398
Rename "tx size" to "tx vsize" 2020-11-05 19:28:45 -03:00
Oscar Guindzberg
52f1d37863
Complete Use segwit tx sizes
Completes 29f23fe50c
2020-11-05 19:14:50 -03:00
chimp1984
f835396d71
Change log level 2020-11-05 15:50:02 -05:00
Oscar Guindzberg
7740e3e56d
Fix comment 2020-11-05 11:51:44 -03:00
Oscar Guindzberg
0d59d5e872
Remove unused PAYOUT_TX_SIZE 2020-11-05 11:51:44 -03:00
Oscar Guindzberg
5f0009e1a4
Explain why legacy is used by default 2020-11-05 11:51:43 -03:00
Oscar Guindzberg
327a358446
Split segwit from legacy inputs
Goal: Have a more accurate fee calculation
2020-11-05 11:51:43 -03:00
Oscar Guindzberg
29f23fe50c
Use segwit tx sizes 2020-11-05 11:51:43 -03:00
Oscar Guindzberg
7a58bfbafa
Use SegwitAddress for fee estimation 2020-11-05 11:51:43 -03:00
Oscar Guindzberg
b2023e2366
Use tx.getVsize()
Replace tx.bitcoinSerialize().length
2020-11-05 11:51:43 -03:00
Oscar Guindzberg
6bba6a526f
Use bitcoinj 0.15.8 (commit 60b4f2f) 2020-11-05 11:51:43 -03:00
Oscar Guindzberg
dffa251e1d
Remove unused imports 2020-11-05 11:47:41 -03:00
Oscar Guindzberg
d1620c4fd7
Revert "Validate AddressEntry.segwit"
This reverts commit e49c56527825a443b794ab74cee24b12d5b9eb45.
2020-11-05 11:47:41 -03:00
Oscar Guindzberg
953a5f0bb5
Deal with P2WPKH has empty scriptSig 2020-11-05 11:47:41 -03:00
Oscar Guindzberg
3585dc95fc
Create the scriptCode the right way 2020-11-05 11:47:41 -03:00
Oscar Guindzberg
22ba9a898b
Explain why bitcoinSerialize(false) is used 2020-11-05 11:47:41 -03:00
Oscar Guindzberg
4a05b6d6d5
Revert "Construct dummy outputs with LegacyAddress"
This reverts commit b8f5c6e970fc29b705478aac8a655a73bed52a7e.
2020-11-05 11:47:40 -03:00
Oscar Guindzberg
06e5091f79
TradeWalletService use P2WSH 2020-11-05 11:47:40 -03:00
Oscar Guindzberg
161e220a4f
BtcWalletService: Use segwit addresses 2020-11-05 11:47:40 -03:00
Oscar Guindzberg
ef97daac89
Use bitcoinj 0.15.8 (commit fcec3da) 2020-11-05 11:47:38 -03:00
Christoph Atteneder
2d3c94d283
Update translations for v1.5.0 2020-11-05 11:37:35 +01:00
Bayer
7163344084
Update core/src/main/resources/i18n/displayStrings.properties
Co-authored-by: m52go <mfiver@gmail.com>
2020-11-05 09:47:31 +01:00
Bayer
80d87a728d
Apply suggestions from code review
Co-authored-by: m52go <mfiver@gmail.com>
2020-11-05 09:47:22 +01:00
Bayer
90c00097ac
Fix display strings lines 2968-3437 2020-11-05 09:47:11 +01:00
Christoph Atteneder
b8fbc74d6c
Merge pull request #4744 from sqrrm/cleanup-signed-witness
Cleanup signed witness
2020-11-05 09:42:46 +01:00
chimp1984
5817525776
Check for 0 and only apply the value in that case.
See comment at change for more background.
2020-11-04 12:54:35 -05:00
chimp1984
c9b3f9d457
Set initial value for bsqAverageTrimThreshold to 5% in case of an
update (using persisted preferences which would
have value set to 0 as it was not existing in old version)
2020-11-04 11:34:10 -05:00
chimp1984
5c7906980c
Clean up mailbox messages for closed trades
Util for removing pending mailbox messages in case the
trade has been closed by the seller after confirming receipt
and a AckMessage as mailbox message will be sent by the
buyer once they go online. In that case the seller's trade
is closed already and the TradeProtocol is not executing
the message processing, thus the mailbox message would not
be removed. To ensure that in such cases (as well other
potential cases in failure scenarios) the mailbox message
gets removed from the network we use that util.
2020-11-03 22:08:38 -05:00
Christoph Atteneder
63cae1ceb1
Merge pull request #4745 from chimp1984/fix-bug-with-reading-historical-data
Fix bug with reading historical data
2020-11-03 21:56:05 +01:00
chimp1984
ab5645b864
Fix issue with getting complete handler called twice from P2PService
We used a delegate method in P2PService for calling readPersisted on p2PDataStorage and peerManager.
This was from old times when those classed have not been injected classes. The complete handlers got
called from both p2PDataStorage and peerManager but we counted only P2PService as host, so the
countdown completed before the last host was really completed, leading to a nullpointer in
MainView (not always).

We removed now PersistedDataHost interface from P2PService and use P2PDataStorage and PeerManager to be added to hosts.
2020-11-03 13:01:35 -05:00
sqrrm
02e53304ed
Cleanup unused argument 2020-11-03 17:35:29 +01:00
sqrrm
7f734292f3
Cleanup line breaks 2020-11-03 16:59:15 +01:00
sqrrm
0f0b75c2ac
Change time dependent trade limits
This is in accordance with https://github.com/bisq-network/proposals/issues/264

Any account type that doesn't need signing can now trade the full
amount immediately, same goes for signed type accounts that are
selling.

Signed type accounts that are buying now has minimum limit (0.01 BTC) up until
30 days after getting signed, then the limit is increased to 0.5 times the max
limit (0.125 BTC) and after 60 days they get the full limits (0.25 BTC).
2020-11-03 16:58:14 +01:00
Christoph Atteneder
8fe8261a1e
Clean up code 2020-11-03 15:42:46 +01:00
Luis Aranguren
ecf9d49f65
Resolve conflicts with master 2020-11-03 15:42:23 +01:00
Christoph Atteneder
b49a3eb15b
Merge pull request #4738 from chimp1984/improve-logs
Change log level at registerProposalAsBallot. Don't log full filter a…
2020-11-03 09:07:11 +01:00
Christoph Atteneder
9da7100ef2
Merge pull request #4734 from chimp1984/show-past-deviation-in-monitor
Show past deviation in monitor
2020-11-03 09:03:14 +01:00
Christoph Atteneder
3d7273883c
Merge pull request #4733 from jmacxx/edit_explorer_details
Allow user-defined block explorers
2020-11-02 19:23:48 +01:00
chimp1984
483116dcd0
Change log level at registerProposalAsBallot. Don't log full filter at onFilterAddedFromNetwork 2020-11-02 12:51:41 -05:00
sqrrm
f03be6ad3d
Merge pull request #4628 from chimp1984/improve-read-file-handling
Use a thread in PersistenceManager for reading persisted files instead of using threads in client code
2020-11-02 17:36:21 +01:00
sqrrm
84ac65b163
Merge pull request #4731 from ghubstan/19-sqrrm-pr-changes
Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...]
2020-11-02 15:32:07 +01:00
jmacxx
8a9d05eba0
Allow user-defined block explorers
In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may
now be user defined in addition to the hard coded block explorer choices.

This implementation takes advantage of the existing Protobuf implementation
that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.

A new popup dialog is implemented which allows editing of the explorer
details (name, txUrl, and addressUrl).  Any of the system-defined
explorer details may be selected into the edit fields thus allowing
them to be used as templates, customized or an entirely new explorer to
be used.

If the user switches choice from a customized back to a pre-defined
explorer then the customized settings are gone; this is because the
Protobuf storage only allows saving one selection.

Fixes #4371
Closes #4634
2020-11-02 07:53:06 -06:00
sqrrm
85237cb870
Merge pull request #4714 from ghubstan/13-canceloffer-impl
Implement 'canceloffer' api method
2020-11-02 12:59:56 +01:00
sqrrm
9e1466417f
Merge pull request #4713 from ghubstan/12-stub-canceloffer
Stub out 'canceloffer offer-id' api method
2020-11-02 12:59:03 +01:00
Christoph Atteneder
9ab65459df
Merge pull request #4736 from jmacxx/add_autoconf_service_filter
Admin filter for auto-confirmation service addresses
2020-11-02 10:47:22 +01:00
jmacxx
15b8e72059
Admin filter for auto-confirmation service addresses
A service address can be filtered out using the admin key.  This would
be useful if a federated server failed, it could be filtered out so
that the auto-confirmation operates with the remaining services.  If
all federated service addresses were filtered out the user would have to
either confirm manually or use their own explorer service.
2020-11-01 08:20:33 -06:00
sqrrm
89620a02da
Merge pull request #4706 from chimp1984/remove-outliers-at-bsq-rate
Remove outliers when calculating BSQ rate
2020-10-31 23:07:40 +01:00
chimp1984
cdace6d9f3
Update commit hash to d789282b 2020-10-31 13:54:01 -05:00