Commit graph

6226 commits

Author SHA1 Message Date
chimp1984
c559e6e044
Fix getCycleIndex method
The recursive version is very slow with more cycles.
2021-11-04 12:48:08 +01:00
chimp1984
d73bc55edf
Add method. Inline var 2021-11-04 12:48:08 +01:00
chimp1984
cd3e8217ae
Rename onChangeAfterBatchProcessing to onDaoStateHashesChanged
at DaoStateMonitoringService.Listener
2021-11-04 12:48:07 +01:00
chimp1984
3ac61c59f1
Cleanups, improve logs 2021-11-04 12:48:07 +01:00
Christoph Atteneder
928208c200
Merge pull request #5791 from jmacxx/fix_monese_satispay
Include holder name field for Monese & Satispay accounts
2021-11-04 10:54:12 +01:00
Christoph Atteneder
26e75413d7
Fix mixed usage of static import to pacify Codacy 2021-11-04 09:31:53 +01:00
chimp1984
1ca0ed5e36
Add notification when BSQ swap trade got confirmed 2021-11-04 01:20:50 +01:00
chimp1984
8fa66ea7aa
Moved instance methods to ClosedTradableManager
Renamed ClosedTradeUtil to ClosedTradableUtil

Leaves only static functional methods in ClosedTradableUtil
Domain methods requiring services are in ClosedTradableManager
This keeps also the TradableList

All formatting code is in ClosedTradableFormatter
2021-11-03 23:54:18 +01:00
chimp1984
27df58b336
Extract formatter methods to ClosedTradeFormatter 2021-11-03 23:12:13 +01:00
chimp1984
acf7c216ae
Moved PriceUtil to bisq.core.util 2021-11-03 22:02:21 +01:00
chimp1984
7109666047
Moved AltcoinValidator, FiatPriceValidator and NumberValidator
to bisq.core.util.validation package. No code change.

Is needed for next refactorings.
2021-11-03 21:58:53 +01:00
chimp1984
24f18b75ae
Rename txFeeAsLong to tradeTxFee and txFeeAsLong to txFeeAsLong
Implement getTxFee in concrete classes. For Maker trades we return the txFee from the offer.

We use txFee in 2 different context:
1. For the txFee the taker pays and which is used for all the trade txs
2. As generic tx fee the user has paid. The makers tx fee is in the offer.
   The taker pays 3 times the tradeTxFee
2021-11-03 21:52:04 +01:00
chimp1984
3023d5b353
Add confirmed state
Fix num trades
2021-11-03 20:47:35 +01:00
chimp1984
c4a8627183
Use TradeModel instead of Trade in the avatar icon
classes and comparators
Add bsq wallet balance listener to update list
Use BsqSwapTrade details window if Bsq trade
Show "N/A" for deposits in case of BSQ swaps
Cleanup ClosedTradesDataModel
2021-11-03 20:10:15 +01:00
chimp1984
ba64ba55e8
Add methods for confirmed and unconfirmed trades 2021-11-03 20:06:01 +01:00
chimp1984
792bbaa6f2
Rename BSQ Swap Trades to Unconfirmed BSQ Swaps 2021-11-03 20:03:14 +01:00
chimp1984
2ac5b3532c
Rename BSQ swap trades tab to Unconfirmed BSQ swaps
Move it left to closed trades
2021-11-03 19:06:06 +01:00
chimp1984
b021f96738
Refactor methods
Prepare that BsqSwapTrades can be added
2021-11-03 18:58:10 +01:00
chimp1984
98bed9682d
Move ClosedTradableManager and ClosedTradeUtil one level up
We will move BsqSwapTrades into closed trades as well once confrimed
2021-11-03 18:21:45 +01:00
chimp1984
01b3691241
Add null check 2021-11-03 18:09:59 +01:00
chimp1984
a5eec8c998
Add getOptionalTakerFee and getOptionalMakerFee to Tradeable 2021-11-03 17:06:11 +01:00
chimp1984
080255ce11
Add getMakerFee to TradeModel 2021-11-03 17:04:00 +01:00
chimp1984
f6d2f7c8a5
Rename makerFee to makerFeeAsLong in BsqSwapTrade 2021-11-03 17:02:49 +01:00
chimp1984
128bd5b297
Add getOptionalTxFee method 2021-11-03 17:01:17 +01:00
chimp1984
310de35af3
Add getTakerFee to TradeModel 2021-11-03 17:00:59 +01:00
chimp1984
964144c89f
Rename takerFee to takerFeeAsLong 2021-11-03 16:58:27 +01:00
chimp1984
baa1fe5282
Add getTxFee method to TradeModel 2021-11-03 14:49:58 +01:00
chimp1984
300e19d095
Add default methods for volume, price, amount 2021-11-03 14:49:38 +01:00
chimp1984
d9d054f2bd
Add getPrice to TradeModel 2021-11-03 14:15:09 +01:00
chimp1984
d235daef01
Add getVolume to TradeModel 2021-11-03 14:14:06 +01:00
chimp1984
3fa4b57d70
Rename getTradeVolume to getVolume in Trade 2021-11-03 14:10:34 +01:00
chimp1984
1f96122e96
Add getAmount to TradeModel 2021-11-03 14:06:41 +01:00
chimp1984
12aadf9ab8
Add getAmountAsLong to TradeModel 2021-11-03 13:42:06 +01:00
chimp1984
863a52077d
Rename getAmount to getAmountAsLong in Trade 2021-11-03 13:39:47 +01:00
chimp1984
05de48b9e0
Rename setTradePrice to setPriceAsLong in Trade 2021-11-03 13:37:55 +01:00
chimp1984
5b4e2a0deb
Rename getTradeAmountAsLong to getAmountAsLong in Trade 2021-11-03 13:36:48 +01:00
chimp1984
b3e8d56f48
Rename tradeAmountProperty to amountProperty in Trade 2021-11-03 13:36:23 +01:00
chimp1984
d0cdf9fac6
Rename tradeVolumeProperty to volumeProperty in Trade 2021-11-03 13:35:58 +01:00
chimp1984
5bf02e944f
Rename getTradePrice to getPrice in Trade 2021-11-03 13:35:20 +01:00
chimp1984
bc4241cbe0
Rename tradeAmount to amount in Trade 2021-11-03 13:34:55 +01:00
chimp1984
9778950018
Rename BSQ SWAP TRADES to BSQ Swap Trades 2021-11-03 12:27:24 +01:00
Christoph Atteneder
41ce2d8088
Remove unused import 2021-11-03 11:39:55 +01:00
chimp1984
c5f2cbc008
Merge branch 'bsq-swap-low-risk-refactorings-2' into bsq-swap-impl-3 2021-11-02 17:16:47 +01:00
chimp1984
ab7d6ed18b
Add missing class (merge mistake) 2021-11-02 17:16:16 +01:00
chimp1984
17d7388aa7
Fix link to BSQ_Swaps wiki 2021-11-02 16:18:50 +01:00
chimp1984
0c0c27c0d9
Rename package 2021-11-02 16:18:50 +01:00
chimp1984
8ee8cba668
Apply patch from ghubstan
Remove currency params. Bsq swaps have statically defined currencies (BSQ/BTC).
2021-11-02 16:18:50 +01:00
chimp1984
bcbce6e0d5
Revert behaviour to old version in master to return null if amount is null.
This caused an issue in the UI so its more safe to leave old behaviour.
2021-11-02 16:18:50 +01:00
chimp1984
311d1e4c4e
Fix linebreak 2021-11-02 16:18:50 +01:00
chimp1984
d0bb421839
Improve naming, cleanups, use static imports 2021-11-02 16:18:50 +01:00