mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity
17,097 Commits 4 Branches 148 Tags 4.3 GiB
bdbb857c3f
Commit Graph

897 Commits

Author SHA1 Message Date
HenrikJannsen
bdbb857c3f
Add more logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 20:00:43 -05:00
Alejandro García
6f8204a73a
Merge pull request #6506 from HenrikJannsen/update_BurningManAccountingStore 
Update BurningManAccountingStore
 2023-01-06 14:10:11 +00:00
HenrikJannsen
9fe3d22b24
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:23:24 -05:00
HenrikJannsen
719602358d
Increase pool size 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:17:09 -05:00
HenrikJannsen
31592ac955
Update BurningManAccountingStore 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 21:46:44 -05:00
HenrikJannsen
1172eec2ce
Improve log 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:14:06 -05:00
HenrikJannsen
5efd13a678
Check if setException returns false and if so, cancel future. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:09:04 -05:00
HenrikJannsen
5e29bfe4c2
Maintain pending futures and cancel them at cleanup. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 14:01:54 -05:00
HenrikJannsen
3e48956227
Increase numOfFailedBroadcasts at timeout 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 14:01:54 -05:00
HenrikJannsen
de32339926
Remove stop setter at cancel 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 14:01:53 -05:00
HenrikJannsen
20b39a4055
Do not send close message to banned node 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 14:01:53 -05:00
HenrikJannsen
41fb5e464c
Use AtomicBoolean for stopped and timeoutTriggered 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 14:01:53 -05:00
HenrikJannsen
b7d1a9da22
Increase thread pool size at Broadcaster 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 19:58:29 -05:00
HenrikJannsen
d5b4ce275b
Add support for listeners when GetDataResponse and GetBlocksResponse are sent. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
1030f891b9
Improve/cleanup logs. 
Only log lostAllConnections after numOnConnections > 2 to avoid logs at startup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
a8a0c0e725
Add custom thread pool to broadcaster 
The broadcasting consumes most of the threads but has lower priority than other messages being sent.
By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of
broadcasts exhausts the thread pool and might drop send message tasks.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:33:39 -05:00
HenrikJannsen
d5b65fe239
Reduce keepAliveTime to 30 sec. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:31:07 -05:00
HenrikJannsen
7953e35395
Add executor parameter to sendMessage 
Add try/catch to handle RejectedExecutionException

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:13:13 -05:00
HenrikJannsen
4a72c27fa0
Increase queue capacity from 10 to 30. 
https://github.com/bisq-network/bisq/issues/6480 reported reaching the limit with the current settings.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-22 08:46:02 +01:00
HenrikJannsen
30afccb2d6
Use ThreadPoolExecutor with custom set queueCapacity instead of CachedThreadPool 
The previously used newCachedThreadPool carries higher risk for execution exceptions if exceeded.

Originally we had only one executor with a corePoolSize of 15 and a maximumPoolSize of 30 and queueCapacity was set to maximumPoolSize.
This was risky when the 15 corePool threads have been busy and new messages or connection creation threads are
queued up with potentially significant delay until getting served leading to timeouts.
Now we use (if maxConnections is 12) corePoolSize of 24, maximumPoolSize 36 and queueCapacity 10. This gives
considerable headroom. We also have split up the executors in 2 distinct ones.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 16:50:55 +01:00
HenrikJannsen
1b182743a2
Update BurningManAccountingStore_BTC_MAINNET 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:58 +01:00
HenrikJannsen
2f9f66280a
Remove try catch. Will be handled in Future fault handler 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:55 +01:00
HenrikJannsen
ddf5239800
Increase timeouts from 3 to 4 min. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:44 +01:00
HenrikJannsen
6aad3a8dc5
Reduce getDataResponse size from 9 MB to 6 MB 
Reduce number of blocks at GetBlocksResponse from 4000 to 3000

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:27 +01:00
Christoph Atteneder
2b77f777a3
Update data stores for v1.9.7 2022-12-14 11:13:23 +01:00
Christoph Atteneder
5dea677644
Merge pull request #6459 from HenrikJannsen/handle_exception_at_send 
Handle exception at send
 2022-12-14 10:20:07 +01:00
Christoph Atteneder
71d6e126dd
Merge pull request #6423 from HenrikJannsen/add-burningman-accounting 
Add burningman accounting
 2022-12-14 10:17:38 +01:00
HenrikJannsen
8c65da9c85
Add thread index format 
Add name param to newCachedThreadPool

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 20:35:49 -05:00
HenrikJannsen
fc2f9241b8
Apply codacy complaint 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 20:30:41 -05:00
HenrikJannsen
ebb6652cef
Remove restartTor method as restart is not supported anymore. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 18:15:23 -05:00
HenrikJannsen
c000d38a09
Remove unnecessary thread and try/catch. 
Wrap nodeAddressProperty.set into UserThread.execute as it is a javafx api. We call startServer also in that execute scope to maintain order of calls.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 18:11:49 -05:00
HenrikJannsen
04a1dee9e9
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 18:07:01 -05:00
HenrikJannsen
6d2bd9f8d4
Use 3 distinct executors for send message, create connection and server. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 18:03:29 -05:00
HenrikJannsen
c4dfc2f9ac
Add ExecutorService to TorNetworkNode instead of using pool from base class. 
Remove torStartupFuture as it was not needed.
Make executorService private and add shutdownNow call.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 17:57:19 -05:00
HenrikJannsen
0e34932ec8
Remove createExecutorService method and create executor in constructor instead. 
Make executorService protected final

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 17:53:03 -05:00
HenrikJannsen
553dd84f28
Cleanups 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 17:49:51 -05:00
HenrikJannsen
43233db70c
Throw RuntimeException at sendMessage. 
Make sendMessage package scope to not be used from client code.
Remove stacktrace print.

The caller in NetworkNode would report a onSuccess in the future callback because we do not escalate the exception but only handle it inside handleException.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 17:47:04 -05:00
HenrikJannsen
f90c4b8f6b
Use cachedThreadPool which uses SynchronousQueue instead of ArrayBlockingQueue. 
When ArrayBlockingQueue is used (as in case of using Utilities.getListeningExecutorService) the maxPoolSize
has no effect. The pool creates never more threads than the core pool size.
Thus we have been limited to 15 threads for message sending and connection creation.
This was likely a reason why seed nodes are not accepting new connections if the pool is exhausted.
Slow message send can block a thread for 1-3 minutes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 17:33:31 -05:00
HenrikJannsen
0dc8d0b2bd
Add maxConnection parameter to be used for setting the core pool size of the executor in NetworkNode. 
We use double the maxConnection size for the core size and 4x for the max pool size.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 16:35:16 -05:00
HenrikJannsen
1e32d86b23
Only log errors if shutdown is not in progress. 
I want to avoid to risk changes with not calling error handlers/listeners in those cases
as not 100% sure if that could have unintended effects.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:08:40 -05:00
HenrikJannsen
1bb4b55220
Add BurningManAccountingStore resource file. 
Use resourceDataStoreService and extend StoreService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
3caf2c2b64
Change visibility (will be used from monitor project). 
Remove log, change log level.
Add getters

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:50:24 -05:00
Alejandro García
e054083c1f
Merge pull request #6376 from jmacxx/fix_issue_6367 
Fix loss of mailbox messages during SPV resync
 2022-11-29 14:41:27 +02:00
sqrrm
b10881ff7f
Merge pull request #6418 from HenrikJannsen/improve-dao-node-domain 
Improve dao node domain
 2022-11-26 16:19:52 +01:00
jmacxx
8a94642e1a
Do not erase mailbox messages during SPV resync. 2022-11-25 21:13:09 -06:00
Alejandro García
a6293a64cb
Merge pull request #6396 from jmacxx/show_commit_hash 
Store the build's commit hash in Jarfile manifest
 2022-11-25 17:36:34 +02:00
HenrikJannsen
ffd2cc1a8c
Handle nullable case caused by tests 
Add mock to test.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-24 19:47:55 -05:00
HenrikJannsen
2de86222b7
Do not apply large persisted messages 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-24 13:36:47 -05:00
HenrikJannsen
143af43eba
Remove log level change for tor at startup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-23 19:53:40 -05:00
HenrikJannsen
96ea154176
Rename delegate to outputStream 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-23 19:53:12 -05:00