Commit graph

13318 commits

Author SHA1 Message Date
chimp1984
cd98617ec8
Property fields must not bet set from non JavaFX threads.
So we map those setters to our UserThread.

How to reproduce issue?
Restore from seed triggered following exception:

Dec-08 13:20:04.547 [ STARTING] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.IllegalStateException: Not on FX application thread; currentThread =  STARTING
	at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:291)
	at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:424)
	at javafx.scene.Parent$3.onProposedChange(Parent.java:471)
	at com.sun.javafx.collections.VetoableListDecorator.setAll(VetoableListDecorator.java:113)
	at com.sun.javafx.collections.VetoableListDecorator.setAll(VetoableListDecorator.java:108)
	at javafx.scene.control.skin.LabeledSkinBase.updateChildren(LabeledSkinBase.java:272)
	at javafx.scene.control.skin.LabeledSkinBase.lambda$new$11(LabeledSkinBase.java:220)
	at com.sun.javafx.scene.control.LambdaMultiplePropertyChangeListenerHandler.lambda$new$1(LambdaMultiplePropertyChangeListenerHandler.java:49)
	at javafx.beans.value.WeakChangeListener.changed(WeakChangeListener.java:86)
	at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)
	at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)
	at javafx.beans.property.StringPropertyBase.access$000(StringPropertyBase.java:50)
	at javafx.beans.property.StringPropertyBase$Listener.invalidated(StringPropertyBase.java:231)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)
	at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)
	at javafx.beans.property.StringPropertyBase.access$000(StringPropertyBase.java:50)
	at javafx.beans.property.StringPropertyBase$Listener.invalidated(StringPropertyBase.java:231)
	at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:348)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)
	at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)
	at javafx.beans.property.StringPropertyBase.set(StringPropertyBase.java:145)
	at javafx.beans.property.StringPropertyBase.set(StringPropertyBase.java:50)
	at bisq.core.app.WalletAppSetup.lambda$init$1(WalletAppSetup.java:170)
	at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:170)
	at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.beans.property.IntegerPropertyBase.fireValueChangedEvent(IntegerPropertyBase.java:107)
	at javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:114)
	at javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:148)
	at bisq.core.btc.setup.WalletsSetup$1.onSetupCompleted(WalletsSetup.java:245)
2020-12-08 13:22:43 -05:00
chimp1984
eb40c777ee
Make paymentGroupBox local 2020-12-08 11:28:22 -05:00
chimp1984
9a5ffeecb3
Remove unused method 2020-12-08 11:28:22 -05:00
chimp1984
c1e702c507
Remove BUYER_SECURITY_DEPOSIT_NEWS (was used in 0.9.5) 2020-12-08 11:28:22 -05:00
chimp1984
2411f2d9c8
Use setMinHeight instead of setPrefHeight for textArea in F2FForm and USPostalMoneyOrderForm and sue 70 px for both 2020-12-08 11:28:21 -05:00
chimp1984
bd736be956
Use full width for altcoin accounts view (as it was already in fiat accounts) 2020-12-08 11:28:21 -05:00
chimp1984
2ead91c961
Increase height of account list when account is selected to make scrolling easier. 2020-12-08 11:28:21 -05:00
Christoph Atteneder
6adf8503df
Merge pull request #4907 from chimp1984/avoid-persistence-write-call-before-read
Prevent that we write data at shutdown before we have read the data.
2020-12-08 16:36:38 +01:00
Christoph Atteneder
6431d639ae
Merge pull request #4908 from chimp1984/add-memo-field-at-step4
Add memo field at step4
2020-12-08 16:35:16 +01:00
Christoph Atteneder
1ab4766600
Merge pull request #4909 from chimp1984/fix-bsq-to-fiat-calculation
Fix bsq to fiat calculation
2020-12-08 16:26:20 +01:00
Christoph Atteneder
ce04a8fc95
Merge pull request #4913 from chimp1984/fix-warning-log-with-address-is-null-at-startup
Avoid logging warning at startup
2020-12-08 16:15:38 +01:00
chimp1984
455c9b0ff3
Avoid logging warning at startup 2020-12-08 10:13:31 -05:00
Christoph Atteneder
d41692602a
Merge pull request #4903 from oscarguindzberg/bloomFilterFix
Upate bitcoinj to commit dcf8af0 - Bloom filter fix
2020-12-08 15:03:28 +01:00
Christoph Atteneder
89e55774c7
Merge pull request #4910 from chimp1984/remove-log-entry
Improve logs
2020-12-08 15:03:09 +01:00
sqrrm
2a2f05f408
Merge pull request #4912 from chimp1984/add-serialized-tx-as-hex-to-trade-details
Add "Raw deposit transaction as hex" to details window
2020-12-08 12:28:15 +01:00
chimp1984
25d227556b
Add "Raw deposit transaction as hex" to details window
Rename Contract as json button to detail data
2020-12-07 20:25:29 -05:00
chimp1984
d0005e45f4
Add logs of tx in case of exceptions 2020-12-07 19:47:44 -05:00
chimp1984
a3df372ecd
Apply project format rules (no code change) 2020-12-07 19:47:05 -05:00
chimp1984
b5e19312c5
Remove logs logging absolute path to data directory 2020-12-07 19:35:01 -05:00
chimp1984
38d52ff6f9
Add more logs to AddressEntry domain 2020-12-07 19:32:32 -05:00
chimp1984
f4fd286b86
Remove verbose log 2020-12-07 17:56:28 -05:00
chimp1984
30ff8c3853
Remove paymentAccount from log 2020-12-07 14:53:45 -05:00
chimp1984
249c6143c9
Use preferredTradeCurrency is fiat, otherwise the users country currency 2020-12-07 13:48:43 -05:00
chimp1984
a7765d0cce
Use 30 day average BSQ price for calculating BSQ fee 2020-12-07 13:45:02 -05:00
chimp1984
5a0634f94d
Move methods to AveragePriceUtil 2020-12-07 13:24:17 -05:00
chimp1984
469f9494ba
Remove empty class 2020-12-07 13:22:01 -05:00
chimp1984
f745f0f0d6
Move methods from AxisInlierUtils to InlierUtil
We will need some of those methods later inside another core util class.
2020-12-07 13:21:44 -05:00
chimp1984
104b7edc99
Add memo field at withdraw to external wallet screen
Implements https://github.com/bisq-network/bisq/issues/4869
2020-12-07 12:32:56 -05:00
chimp1984
959c53c18d
Apply project format rules (no code change) 2020-12-07 12:31:34 -05:00
chimp1984
15ed165cdd
Move readCalled.set(true); to getPersisted(String fileName) method.
Note: It must be before the null check as no existing file must not prevent write.
2020-12-07 12:05:28 -05:00
chimp1984
0520942a4c
Prevent that we write data at shutdown before we have read the data.
Fixes https://github.com/bisq-network/bisq/issues/4844
2020-12-07 11:42:19 -05:00
sqrrm
368121e997
Merge pull request #4906 from chimp1984/fix-logs
Remove dev log, fix typo in log
2020-12-07 17:17:21 +01:00
chimp1984
e2f9009fce
Remove dev log, fix typo in log 2020-12-07 10:33:41 -05:00
Oscar Guindzberg
9ca20d8b3d
Use bitcoinj 0.15.8 (commit dcf8af0) 2020-12-07 11:39:58 -03:00
sqrrm
4e4d3e72d6
Merge pull request #4898 from chimp1984/diable-setupConnectionLossCheck-for-regtest
Dont shut down seed in regtest mode if all connections lost
2020-12-07 14:47:19 +01:00
sqrrm
74485f0844
Merge pull request #4884 from ghubstan/01-refactor-getdust
Refactor: move getDust(Transaction transaction)
2020-12-07 14:12:59 +01:00
Christoph Atteneder
6d01bc91ea
Merge pull request #4897 from chimp1984/dont-require-account-witness-for-small-amounts
Allow take offer in case account age witness is not found and trade amount is small
2020-12-06 20:20:52 +01:00
Deus Max
ea6d5640d4
Refactored outlier filtering for Market Offer chart.
Moved the outlier filtering outside of the updateChartData function.
2020-12-06 00:33:14 +02:00
chimp1984
51ab5685de
For dev testing (usually on BTC_REGTEST) we don't want to get the seed shut
down as it is normal that the seed is the only actively running node.
2020-12-04 12:44:19 -05:00
chimp1984
82445c0e28
In case the peers witness is not found and the trade amount
is not exceeding TOLERATED_SMALL_TRADE_AMOUNT (0.01 BTC) we
return true for verifyPeersTradeAmount.
Before such offers could not be taken even the witness
check would be irrelevant as the trade amount is below the
threshold where we require account age witness.
2020-12-04 12:40:30 -05:00
Christoph Atteneder
9e3968e5f4
Merge pull request #4892 from deusmax/market-offer-filter-bugfix
Offer Book chart outlier filter improved.
2020-12-04 16:54:25 +01:00
Christoph Atteneder
0d6b17fa3f
Merge pull request #4875 from deusmax/FXC-ext
Replace use of Collections to FXCollections in desktop.
2020-12-04 16:44:05 +01:00
Christoph Atteneder
588623eb2d
Merge pull request #4885 from chimp1984/fix-bug-with-reapplying-past-trade-state
Avoid that buyer switches back to trade step 2 at startup after payment confirmed
2020-12-04 16:41:41 +01:00
Christoph Atteneder
c44eaa88bb
Merge pull request #4895 from chimp1984/fix-maker-removes-offer-task
Remove checkNotNull for takerFeeTxId
2020-12-04 16:12:23 +01:00
chimp1984
c04b95b996
Remove checkNotNull for takerFeeTxId 2020-12-04 10:10:57 -05:00
sqrrm
57681245ff
Merge pull request #4889 from chimp1984/avoid-case-of-multi-trades-with-same-offer-id
Avoid case of multi trades with same offer
2020-12-04 00:48:45 +01:00
Christoph Atteneder
8a683f0024
Merge pull request #4891 from chimp1984/increase-log-limit
Increase max number of log files to 20.
2020-12-03 21:26:40 +01:00
Christoph Atteneder
c782f22fe8
Merge pull request #4874 from jmacxx/fix_systray_error
Prevent annoying popup errors for unhandled systray exception.
2020-12-03 21:21:47 +01:00
chimp1984
546c7546ac
Increase max number of log files to 20.
Requested here: https://github.com/bisq-network/bisq/issues/4856
2020-12-03 14:57:33 -05:00
chimp1984
8f99ca0b63
Add uid to trade to make sure that look up for process model cannot
fail in case of multiple trades with the same offer id.
Use uid instead of the weaker offerId as key for the tradeProtocolByTradeId map
2020-12-03 14:43:35 -05:00