In case of reorgs there are several scenarios:
1. We have no snapshot yet: We start from genesis again
2. We have a snapshot and go back to that: We use last snapshot
3. We have a snapshot but the reorg does deeper so our last block in the
snapshot is invalid as well: -> we go back to genesis
There are many edge cases
There was one important bug fix with a == instead of an equals
comparison.
Added also the check that the first block need to be the genesis block.
Unfortunately the chainHeight is set to the genesis height initially
which is not right (should be 0 as we dont have any block and therefore
no chainHeight). To change that will be a bit risky, but for mainnet we
should consider it. There are several usages where a change might break
stuff, for instance the parameter handling.
Rather than having a separate install_java.sh script for distributions
that use a different package manger, I updated install_java.sh to
handle package managers used by various Linux distributions.
On Windows, it is likely that cli-output_windows.txt will have CRLF line
endings since core.autocrlf is normally true which converts LF endings
to CRLF on checkout. This causes BisqHelpFormatterTest to fail since
the actual content it is compared against uses LF endings.
As a result, when loading the cli-output_windows.txt file normalize
line endings to LF.
- apply snapshot in case of a reorg and if the snapshot is still empty.
Set chain height to genesis height.
- Handle case if cycles are empty
- Add checks for getLast for linked lists
- gives testnet and regtest a more realistic environment (most assets
would be disabled due lack of trade activity otherwise as testnet and
regtest ahs dao enabled)
- reason for dispute fields have been not visible in dispute payout
window (row index of next iem was not increased)
- Moved payout amount fields to second column to not exceed window
height
- Set window width wider
- Cleanups
