Commit graph

68 commits

Author SHA1 Message Date
Christoph Sturm
9eb174bc88 provide PubKeyRing and use it where appropriate instead of keyring 2019-08-14 17:58:04 +02:00
Christoph Sturm
d5af6e5260 avoid acronyms 2019-08-14 10:45:05 +02:00
Christoph Sturm
bd06d2a7df document what this is for 2019-08-14 10:42:38 +02:00
Christoph Sturm
17221cbed8 remove more powermock and jmockit tests.
ignore 2 or 3 tests that are not possible to convert now
2019-08-13 19:30:57 +02:00
Christoph Sturm
a8494a993a fix missing annotation 2019-08-13 15:58:14 +02:00
Christoph Sturm
c6f07ed945 singletonify the rest of the core module 2019-08-13 15:58:14 +02:00
Christoph Sturm
7500887484 even more singletoning 2019-08-13 15:58:14 +02:00
Christoph Sturm
3f097ebf63 more singletoning 2019-08-13 15:58:13 +02:00
Christoph Sturm
a4e8ec5ebf convert some of the core config 2019-08-13 15:58:13 +02:00
sqrrm
e52c255446
Merge pull request #3058 from christophsturm/bump-guice
use singleton annotation instead of binding as singleton
2019-08-13 15:19:41 +02:00
sqrrm
fb1c96d24c
Merge pull request #2976 from niyid/master
Fixes for issues #2741, #2944, #2955
2019-08-09 15:35:21 +02:00
Christoph Sturm
643c0daef0 use singleton annotation instead of binding as singleton.
this is the correct way to do it. the way it is currently done means
that if a component is not declared in a module, guice still finds it
but does not use the singleton lifecycle

binding as singleton in the module is meant to be used for classes that
we don't have the sourcecode for (i.e. jdk classes)
2019-08-06 17:44:47 +02:00
Christoph Sturm
20e011178e bump guice version and start testing desktop guice setup 2019-08-06 17:44:47 +02:00
Christoph Atteneder
fdf5364c47 Add domain layer for signed account age witnesses (credits ManfredKarrer and oscarguindzberg) 2019-07-30 11:38:57 +02:00
Niyi Dada
36002dbbcc Added test for median statistics 2019-07-18 19:11:54 +01:00
Devin Bileck
13cec4a877
Add more tests for formatDurationAsWords 2019-05-17 14:37:37 -07:00
Manfred Karrer
8ab348c495
Add check for account age to apply restrictions 2019-05-02 13:06:46 -05:00
Manfred Karrer
25e2621ce5
Fix missing arguments 2019-04-19 20:37:19 -05:00
Christoph Atteneder
55d09a308b
Use different security deposit for fiat-crypto and crypto-crypto trades 2019-04-18 19:37:46 +02:00
Christoph Atteneder
e37a704016
Remove BSQ filter for crypto currencies 2019-04-17 11:16:55 +02:00
Manfred Karrer
b8f8fbff20
Use percentage based value for security deposits
Use percentage based value of trade amount for buyer and seller
security deposit.
To ensure that the BTC value is not getting too low, we apply a min.
value for both.
2019-03-04 23:35:35 -05:00
Manfred Karrer
03d0a22580
Allow spending of unconfirmed BSQ change outputs
When creating a BSQ transaction (actually at commit time as we can create a tx and then
cancel it in the confirmation popup) we store the change output (only that not the other
possible BSQ output) in a persisted list. The BsqCoinSelector will take that list to
allow spending those coins. We use the txType to find the index of the cahnge output.
We only have one change output in the transactions created in Bisq. Multiple change
outputs would be valid but our goal is only increased usability in the Bisq app and it is
not related to validation rules.

We update out list at each new block confirmation.

With that approach we avoid too much dependencies to the BitcoinJ side.

- Add UnconfirmedBsqChangeOutputListService and persisted UnconfirmedBsqChangeOutputList
for storing unconfirmed outputs
- Add lookup for unconfirmed BSQ change outputs at BsqCoinSelector and allow spending if
found
- Pass TxType for walletsManager.publishAndCommitBsqTx calls
- Add TxType to bsqWalletService.commitTx
- Refactor getPreparedSendTx methods for BSQ and BTC sending to one common method with a
coinselector parameter.
- Add getChangeAddress method to BsqWalletService to make change outputs more explicit
- Add unconfirmedChangeBalance to onUpdateBalances handlers
- Rename availableBalance to availableConfirmedBalance in onUpdateBalances
- Unify onUpdateBalances parameter names
2019-02-28 23:22:43 -05:00
Manfred Karrer
11bc11fd24
Remove code for Venmo, Cashapp and OKPay
- We had an automate remove accounts for those payment methods for long
time, so we can assume that no traders have any of those accounts still
in their persisted user objects and it is safe to completely remove them.
Only part where we cannot remove it is the PB definitions (actually I
think we could remove those as well, but not 100% sure and it seems to
be more safe to mark those as deprecated and leave the entries).
2019-02-13 21:34:51 -05:00
Manfred Karrer
d1faa846ea
Merge pull request #2410 from ripcurlx/add-utm-parameters-for-website-links
Add utm parameters to bisq.network links
2019-02-12 07:58:05 -05:00
Manfred Karrer
a4b39135f8
Remove empty lines 2019-02-12 07:41:59 -05:00
Christoph Atteneder
eb2e1a96bf
Add utm parameters to bisq.network links to be able to track referral traffic from client 2019-02-12 12:35:33 +01:00
Christoph Atteneder
10f7007037
Add application launchers for UI test files 2019-02-07 21:18:34 +01:00
Christoph Atteneder
efcee3e28f
Fix broken test 2019-01-23 22:31:46 +01:00
Manfred Karrer
83d67e3532
Merge pull request #2310 from ripcurlx/fix-tradecurrency-selection
Fix trade currency handling for multiple currency payment accounts
2019-01-23 20:07:20 +01:00
Manfred Karrer
fc815eed77
Fix testclass 2019-01-23 13:47:10 +01:00
Manfred Karrer
200c90b7aa
Merge pull request #2251 from ManfredKarrer/refactor-fee-estimation
Refactor fee estimation
2019-01-23 13:44:27 +01:00
Christoph Atteneder
0a7c85f7d8
Use selected trade currency if available in payment account 2019-01-23 13:16:55 +01:00
Christoph Atteneder
f8d77de642
Improve exception if offer of removed assets is edited 2019-01-22 17:33:38 +01:00
Devin Bileck
7a16b3f3c6
Fix CurrencyListTest when locale is not en_US
When declaring a fiat currency and only providing the currency code,
it uses the system locale to get the currency display name.
This potentially causes different sorting results in
testUpdateWhenNotSortNumerically when locale is not en_US.

Now, it specifies the en_US locale when defining the fiat currencies
for this test.

Fixes https://github.com/bisq-network/bisq/issues/2259
2019-01-13 22:27:06 -08:00
Manfred Karrer
28d0db8ac8
Fix missing param in test class 2019-01-12 00:16:57 +01:00
Christoph Atteneder
fe864724f3
Configure jMockit for desktop module 2019-01-11 16:59:18 +01:00
Christoph Atteneder
e31a314904
Fix ignored test cases 2019-01-11 16:17:56 +01:00
Manfred Karrer
f0eb12df06
Remove param from CreateOfferViewModelTest 2019-01-07 12:19:45 +01:00
Christoph Atteneder
9e22a7df6d
Add print tool for all markets used in https://github.com/bisq-network/bisq-website/blob/master/_includes/market_currency_selector.html 2018-12-13 14:54:08 +01:00
Christoph Atteneder
0bc29e198c
Ignore monospace spacing tests until re-introduced again 2018-12-13 14:20:13 +01:00
Jeffrey Ko
4cd2ac8d40
Add advanced cash payment method 2018-11-23 20:50:03 +07:00
Manfred Karrer
b852a6b94a
Merge branch 'master' into release-candidate-0.9.0 2018-11-12 20:36:47 -05:00
Manfred Karrer
16e4b72d4d
Fix tests 2018-11-12 00:25:25 -05:00
Manfred Karrer
6861e76d61
Merge branch 'master' into release-candidate-0.9.0
# Conflicts:
#	desktop/src/main/java/bisq/desktop/util/GUIUtil.java
#	desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java
#	gradle/witness/gradle-witness.gradle
2018-11-08 16:55:03 -05:00
Manfred Karrer
4fd86c64e3
Fix tests and improve the isCryptoCurrency method.
- We return true at isCryptoCurrency in those cases:
- The code is BTC
- The code is found in assetRegistry
- If not found we check if we have a fiat currency for that code,
if not we treat it as crypto (case of a removed asset)
2018-11-07 16:31:32 -05:00
Manfred Karrer
526a9f5442
Merge branch 'master' into release-candidate-0.9.0
# Conflicts:
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java
2018-10-30 14:03:12 -05:00
Jeffrey Ko
ee51292d87
add interac e-transfer question/answer validation 2018-10-30 21:53:32 +07:00
Manfred Karrer
5ac35284ef
Fix test 2018-10-27 18:43:50 -05:00
Christoph Atteneder
45060575bd
Merge branch 'master' of github.com:bisq-network/bisq into redesign
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/dao/governance/ProposalDisplay.java
#	desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java
#	desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java
2018-10-24 13:52:49 +02:00
Manfred Karrer
538538ec34
FIx missing arguments in test, Ignore test (JMockit issue)
@Christoph Can you have a look why JMockit is not working anymore
in that module? TradesChartsViewModel is null and creates a nullpointer.
Adding RunWith("JMockit") as it was earlier does not work with changed gradle file
with newer JMockit version.
2018-10-23 13:13:36 -05:00