mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-25 23:31:24 +01:00
Code Issues Projects Releases Packages Wiki Activity
12065 commits 3 branches 150 tags 4.1 GiB
Commit graph

4520 commits

Author SHA1 Message Date
ghubstan
94996a5e25
Fix tx result handling in GrpcOffersService 
Separates offer placement from offer creation to fix tx result
handling problem in GrpcOffersService, and readies the core api
for a new CLI 'placeoffer' implementation.  Offer placement still
happens in the api's 'createoffer', but we may want to change it
to show the created offer to a CLI user for review, prior to manual
placement via a new 'placeoffer offer-id' (of 'confirmoffer offer-id'?)
api method.
 2020-09-28 11:48:56 -03:00
ghubstan
f3761530b5
Codacy requires default label in switch 2020-09-28 09:38:08 -03:00
ghubstan
d9ece9f5ba
Revert "Fix 'switch statements should have a default label' codacy problem" 
This reverts commit 50d4b9f5e1.
Back out codacy fix;  it did not work.
 2020-09-27 17:25:44 -03:00
ghubstan
50d4b9f5e1
Fix 'switch statements should have a default label' codacy problem 
This is an ugly, temporary fix.  Need to refactor again.
 2020-09-27 17:18:50 -03:00
ghubstan
35a77be7e4
Redefine DisputeAgentType REFUNDAGENT as REFUND_AGENT 
The CLI needs to be able to register a REFUND_AGENT using the
'refund_agent' or 'refundagent' parameter value (in any case),
so an alt-name mapping was added to the enum def.
 2020-09-27 15:23:19 -03:00
ghubstan
de3105a62b
Add license comment 2020-09-25 20:56:48 -03:00
ghubstan
92042d70ad
Remove unused import 2020-09-25 20:56:25 -03:00
ghubstan
2f3e3a31e1
Add simple mkt-price service & test calculated offer prices 
A gRPC price service was added, and api create-offer tests can check
mkt based price margin calculations.
 2020-09-25 20:48:26 -03:00
ghubstan
82ce864fda
Delete trailing spaces from blank line for codacy 2020-09-25 15:19:10 -03:00
ghubstan
3b518249d4
Do not reassign currencyCode parameter 2020-09-25 14:44:35 -03:00
ghubstan
995af0dd21
Convert mktPriceMargin to %, make createAndPlaceOffer private 
And move createAndPlaceOffer to bottom of class file.
 2020-09-25 13:50:50 -03:00
ghubstan
96278b9bab
Push currencyCode.toUpperCase conversion below CoreApi 2020-09-25 12:33:51 -03:00
ghubstan
6cdbc137c1
Move 'createoffer' price arg transform to server & test it 
The CreateOfferRequest's price field type was changed from long to string,
so a CLI param like 10000.0055 can be passed to the server as is, to be
scaled and converted there.  In general, we want to keep validation logic
on the CLI as simple as possible, and use existing core logic to
validate args and convert arg types when needed.
 2020-09-24 18:13:19 -03:00
ghubstan
ec9c1b0f10
Uppercase direction & ccy-code CLI arguments in core 
Don't convert parameter case in CLI.
 2020-09-24 09:18:13 -03:00
ghubstan
3c0c443680
Change API's createoffer return value from bool to Offer 2020-09-22 22:13:42 -03:00
ghubstan
e63a6c5771
Remove comment 2020-09-22 18:45:50 -03:00
ghubstan
8896372a0f
Move test dispute agent type constants to core 
The string constants deleted from the test case are re-defined as enums,
but the test harness still passes around strings (enum.name()) because
the handling of invalid dispute agent type string args needs to be
tested.  (Reminder:  CLI does not accept any enum arguments.)
 2020-09-22 15:31:38 -03:00
Christoph Atteneder
e3b3c625b3
Merge pull request #4548 from ghubstan/use-legacyaddress-frombase58 
Remove unused, broken accessor
 2020-09-22 16:32:50 +02:00
Christoph Atteneder
44bf29b67e
Merge pull request #4546 from oscarguindzberg/code-cleanup 
Minor code cleanup changes
 2020-09-22 16:23:31 +02:00
Christoph Atteneder
64d4b9b136
Merge pull request #4544 from oscarguindzberg/removeListeners 
Remove unnecessary listeners in TransactionsView
 2020-09-22 16:22:37 +02:00
Christoph Atteneder
69d533d9ea
Merge pull request #4520 from cd2357/show-qubes-info-popup 
Show info popup if Bisq started under Qubes OS
 2020-09-22 16:21:03 +02:00
ghubstan
86c62c1333
Revert WalletService change (accessor breaks build) 
The accessor added in commit e2bd89f broke the build, and was not
used as originally intended -- by CoreWalletsService -- because the
the api's wallet methods need addresses from the wallet, not just
a valid address.
 2020-09-22 11:16:53 -03:00
sqrrm
3d07c064e4
Merge pull request #4534 from ghubstan/daemon-status-scratch 
Give core api a simple way to verify init status
 2020-09-22 11:41:12 +02:00
sqrrm
dee92670c5
Merge pull request #4539 from ghubstan/refactor-bisqdaemonmain 
Refactor API & add registerdisputeagent method to CLI
 2020-09-22 11:37:18 +02:00
Oscar Guindzberg
64dc4fbf84
Remove unused code from WalletConfig 2020-09-21 18:22:41 -03:00
Oscar Guindzberg
6cf7a9977a
Code cleanup 2020-09-21 17:32:47 -03:00
Oscar Guindzberg
c890d3c02a
Remove unused code 2020-09-21 17:19:01 -03:00
Christoph Atteneder
6af2a46e49
Merge pull request #4542 from chimp1984/refactor-regexvalidator 
Refactor regexvalidator
 2020-09-21 20:16:53 +02:00
Oscar Guindzberg
93f9f83136
Make codacy happy 2020-09-21 12:40:53 -03:00
Oscar Guindzberg
2a33095021
WalletService.isOutputScriptConvertibleToAddress() include segwit outputs 2020-09-21 12:40:53 -03:00
Oscar Guindzberg
e8c82549a8
Use Address.fromString() for btc addresses 
Use Address.fromString() instead of LegacyAddress.fromBase58() for btc addresses.
Trade protocol addresses not migrated yet.
 2020-09-21 12:40:52 -03:00
Oscar Guindzberg
87833fd3fc
Declare returning type as LegacyAddress 2020-09-21 12:40:52 -03:00
Oscar Guindzberg
8a3d403bfc
Rename WalletService.emptyWallet() to emtyBtcWallet() 2020-09-21 12:40:52 -03:00
Oscar Guindzberg
fe79369be6
Rename Base58BitcoinAddressValidator to Base58AddressValidator 2020-09-21 12:40:49 -03:00
chimp1984
9c0b40a3b9
Refactor: Move Regex test methods from GUIUtilTest to RegexValidatorTest in core 2020-09-20 22:16:22 -05:00
chimp1984
c6f2732062
Refactor: Move RegexValidator factory methods to RegexValidatorFactory in core 2020-09-20 22:14:14 -05:00
chimp1984
3675e76194
Refactor: Move egexValidator from desktop to core 2020-09-20 22:13:18 -05:00
chimp1984
48a3f7443e
Merge branch 'master_upstream' into fix-trade-protocol-issues 
# Conflicts:
#	core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java
 2020-09-19 10:23:40 -05:00
Oscar Guindzberg
9a7439bef7
Break lines at 120 characters 2020-09-18 18:29:39 -03:00
Oscar Guindzberg
b89e9e1168
Code quality: Use {} in if oneliners 2020-09-18 18:29:39 -03:00
Oscar Guindzberg
24da46879f
bugfix: When creating a new BSQ wallet, use the BTC wallet seed 2020-09-18 18:29:39 -03:00
Oscar Guindzberg
f1738f0b19
Code polishing to make Codacy happier 2020-09-18 18:29:38 -03:00
Oscar Guindzberg
f342c89c8e
Code polishing to make Codacy happy 2020-09-18 18:29:37 -03:00
Oscar Guindzberg
02559f2334
Revert "bitcoinj 0.15: Remove call to PeerGroup.setIgnoreHttpSeeds(true)." 
This reverts commit 9be6a9dd295b439a66c4d369563411009c9db329.
 2020-09-18 18:29:37 -03:00
Oscar Guindzberg
daaacecafb
Use bitcoinj 0.15.8 (commit 0d98efb) 2020-09-18 18:29:37 -03:00
Oscar Guindzberg
4de39fc2a3
Make it clear P2PKH is used always used 
Make it clear P2PKH is used for both BSQ and BTC wallets
until segwit is implemented.
 2020-09-18 18:29:36 -03:00
Oscar Guindzberg
d0b00fb6f4
Use bitcoinj 0.15.8 (commit 0d7762b) 2020-09-18 18:29:36 -03:00
Oscar Guindzberg
00c9f401c1
WalletConfig.preferredOutputScriptType: make it a method variable 2020-09-18 18:29:36 -03:00
Oscar Guindzberg
5a00770377
bitcoinj 0.15: BisqRiskAnalisys: Add commented out code to match original DefaultRiskAnalysis. 2020-09-18 18:29:35 -03:00
Oscar Guindzberg
d8e0ba752f
bitcoinj 0.15: Replace deprecated Script methods with ScriptPattern methods. 2020-09-18 18:29:34 -03:00