Commit graph

14547 commits

Author SHA1 Message Date
ghubstan
d01a7b7fee
Improve required-argument opt validation
Make sure non-empty opt values are present in the parsers' custom
validation, or jsimpleopt will throw exceptions with stylistically
inconsisent messages.
2021-03-05 07:10:42 -03:00
ghubstan
62ff79d718
Update cli getoffers smoke test to posix style opts 2021-03-05 07:09:41 -03:00
ghubstan
cfaa539a5e
Fix opt validation bugs in CLI
Unset empty string default values on some the createoffer method's
required option declarations in CreateOfferOptionParser, and adds a
check for presence of required currency-code option.

- Removes default "" value from required opt direction.
- Removes default "" value from required opt currency-code.
- Removes default "" value from required opt amount.
- Removes default "" value from required opt min-amount.
- Removes default "" value from required opt fixed-price.
- Removes default "" value from required opt security-deposit.
- Check for required currency-code option.

Unset empty string default values on some of the createoffer method's
required option declarations in TakeOfferOptionParser.

- Removes default "" value from required opt offer-id.
- Removes default "" value from required opt payment-account.

Other opt parser default values removed from:

- CancelOfferOptionParser#offer-id
- CreatePaymentAcctOptionParser#payment-account-form
- GetAddressBalanceOptionParser#address
- GetBTCMarketPriceOptionParser#currency-code
- GetOfferOptionParser#offer-id
- GetOffersOptionParser#direction
- GetOffersOptionParser#currency-code
- GetPaymentAcctFormOptionParser#payment-method-id
- GetTradeOptionParser#trade-id
- GetTransactionOptionParser#transaction-id
- RegisterDisputeAgentOptionParser#registration-key
- RegisterDisputeAgentOptionParser#dispute-agent-type
- RemoveWalletPasswordOptionParser#wallet-password
- SendBsqOptionParser#address
- SendBsqOptionParser#amount
- SendBtcOptionParser#address
- SendBtcOptionParser#amount
- SetTxFeeRateOptionParser#tx-fee-rate
- SetWalletPasswordOptionParser#wallet-password
- UnlockWalletOptionParser#wallet-password
- UnlockWalletOptionParser#timeout
- WithdrawFundsOptionParser#trade-id
- WithdrawFundsOptionParser#address
2021-03-04 13:03:04 -03:00
jmacxx
cc56470b2f
Improve chat functionality of mediation/arbitration
Show badge with number of unread chat messages on each ticket
Use icons for chat, info and process ticket functions
Select a row by clicking on it, no clunky select button needed.
Show chat messages in a movable popup window.
More space for ticket list.

Implement requested feature additions:

Indicate if the trade period is over
Indicate more clearly the sender of each chat message
Support badge count
Indicate the XMR tx proof (when applicable)
Allow trader to close own mediation ticket if the trade is paid out

Fixes:

null check for cases when extraData null/not applicable
when upgrading closed disputes, clear chat unread count
2021-03-03 18:41:17 -06:00
jmacxx
9777181ff9
Dark mode: highlight text fields +8% vs background 2021-03-03 16:16:26 -06:00
ghubstan
a2000bdc33
Explain how to manually register test dispute agents 2021-03-03 12:44:29 -03:00
ghubstan
e0bf773564
Add link to api-beta-test-guide.md 2021-03-03 12:43:21 -03:00
BtcContributor
ba5705ca74
fix setpassword text button 2021-03-03 12:13:10 +01:00
jmacxx
62e71e1ccb
fix mailbox bootstrap issue 2021-03-03 11:57:47 +01:00
Christoph Atteneder
3b1158a908
Merge pull request #5267 from jmacxx/fix_mailbox_bootstrap
Fix mailbox bootstrap issue
2021-03-03 11:57:20 +01:00
jmacxx
f936210717
fix mailbox bootstrap issue 2021-03-02 14:34:03 -06:00
Christoph Atteneder
c1d6ea93bb
Bump version number for v1.5.9 2021-03-02 18:53:37 +01:00
ghubstan
8590c67670
Remove warning supression 2021-03-02 14:40:36 -03:00
ghubstan
2473ff6374
Fix tx-fee-rate formatting (and math) bug in cli/CurrencyFormat
Now prints '<integer> sats/byte' to console.
2021-03-02 13:28:51 -03:00
BtcContributor
e28843dd41
fix opening windows dao links 2021-03-02 13:14:25 +01:00
sqrrm
411395bf94
Merge pull request #5260 from bisq-network/hotfix/v1.5.8
Hotfix/v1.5.8
2021-03-02 11:55:37 +01:00
Christoph Atteneder
bdf6463e61
Merge branch 'master' of github.com:bisq-network/bisq into hotfix/v1.5.8
# Conflicts:
#	build.gradle
#	desktop/package/linux/Dockerfile
#	desktop/package/linux/package.sh
#	desktop/package/linux/release.sh
#	desktop/package/macosx/create_app.sh
#	desktop/package/macosx/finalize.sh
#	desktop/package/macosx/insert_snapshot_version.sh
#	desktop/package/windows/package.bat
#	desktop/package/windows/release.bat
#	relay/src/main/resources/version.txt
2021-03-02 10:06:49 +01:00
Christoph Atteneder
996e264cfb
Revert to SNAPSHOT version 2021-03-02 10:03:29 +01:00
ghubstan
392c0f58af
Fix CLI number opt validation, improve server-not-up msg
- Fix tx-fee-rate opt validation bug.

- Tell user what option value is not a number.

- Append ", server may not be running" text to "io exception" exception msg.
2021-03-01 15:20:08 -03:00
jmacxx
7c80934a17
Field id strings for FeeService extracted to Config.java 2021-03-01 11:25:04 +01:00
jmacxx
a043e3bdf1
Update Preferences tests to new constructor signature 2021-03-01 11:24:56 +01:00
jmacxx
6efeae09c5
Obtain minimumFee from mempool api in place of hardcoded value 2021-03-01 11:24:38 +01:00
Christoph Atteneder
5288d0840b
Bump version number for v1.5.8 2021-03-01 11:24:04 +01:00
Christoph Atteneder
0c9d278629
Merge pull request #5235 from jmacxx/mempool_minimumFee
Obtain minimumFee from mempool api in place of hardcoded value
2021-03-01 11:18:16 +01:00
ghubstan
3f84246f59
Improve interceptor's rate metering key definition and lookup
This change replaces the hard coded strings used as keys in
interceptor rate-metering lookup maps.

Now, the fullMethodName defined in each bisq.proto.grpc.* class'
io.grpc.MethodDescriptor is used, not a hard coded String.

For example, the rate metering lookup key for 'GetBalances',
in 'GrpcWalletsService', is the

   fullMethodName = SERVICE_NAME + '/' + "GetBalances",

   where SERVICE_NAME = "io.bisq.protobuffer.Wallets".

Also adjusted affected tests, and tidy'd up interceptor logging.
2021-02-28 17:10:51 -03:00
ghubstan
19aed84910
Fix getunusedbsqaddress test 2021-02-27 22:58:22 -03:00
ghubstan
b618776b1b
Wait 3 secs after removing password (for wallet save) 2021-02-27 22:50:14 -03:00
ghubstan
3bbefffb9c
Adjust mainnet bats test to default rate meter interceptors 2021-02-27 22:38:38 -03:00
ghubstan
3feacf4580
Remove unused import 2021-02-27 22:25:49 -03:00
ghubstan
724950926c
No need to wait, default+test call rate > 2x / second 2021-02-27 21:57:53 -03:00
ghubstan
675ce9813e
Make test call rate = default call rate 2021-02-27 21:56:19 -03:00
ghubstan
6b2c386a7c
Fix call rate metering interceptor bug
The gRPC interceptor was not using the correct method/ratemeter
map key, and failing to find a rate meter for the server call.

- Fix the rate meter key lookup bug.

- Disable most strict, default call rate meters in tests.
  Made an adjustment to the test harness' scaffold setup so an interceptor
  testing or disabling config file is always picked up by bob and alice
  daemons.

- Set arbitration daemon's registerDisputeAgent rate @ 10/second, so
  it does not interfere with the test harness.  (There is no pre-existing
  arb node appDataDir before that daemon starts.)

Note:  The test harness cannot install the custom rate metering file in
an arb daemon's appDataDir before it starts because there is no dao-setup
file for that node type.

TODO:  Adjust api simulation scripts to interceptor bug fix.
2021-02-27 21:47:52 -03:00
ghubstan
f90d2cee57
Fix test bug 2021-02-27 18:24:57 -03:00
ghubstan
e8d1f03792
Clean up call rate meter config file in test teardown 2021-02-27 18:10:06 -03:00
ghubstan
98ff6cf9ef
Fix test bug 2021-02-27 18:01:45 -03:00
ghubstan
320e63c0a1
Log 'trade not found' a warning instead of full stack trace 2021-02-27 17:25:49 -03:00
ghubstan
e5a0a3998d
Permit some gRPC excptions to be logged only as warning
A new handleExceptionAsWarning method logs warn(ex.msg) instead of
the full stack trace.
2021-02-27 17:14:22 -03:00
ghubstan
e5291e9f45
Use the logger of the gRPC service throwing an exception 2021-02-27 17:09:54 -03:00
cd2357
8ef03e5801
Document tor upgrade steps
Add a guide describing how to upgrade Bisq's tor dependencies.
2021-02-27 12:44:39 +01:00
ghubstan
e2bb64de7d
Merge branch 'master' into 01-show-cost-in-trade-output 2021-02-27 08:40:51 -03:00
sqrrm
80c722803d
Merge pull request #5247 from bisq-network/release/v1.5.7
Release/v1.5.7
2021-02-26 22:34:08 +01:00
Christoph Atteneder
52c90dc9c1
Revert to SNAPSHOT version 2021-02-26 21:06:35 +01:00
ghubstan
d60c0dd3ca
Display buyer's cost in api's gettrade output
The offer volume is shown so traders know how much fiat
they are sending or receiving without having to call getoffer.

Changed the 'Fiat Sent' and 'Fiat Received' column headers
to show which fiat is being transfered, e.g., 'EUR Sent',
'EUR Received'.

Adjusted apitest's trade-simulation-utils.sh to the modified
gettrade output.
2021-02-26 15:25:31 -03:00
cd2357
fb3ed20d74
Bump netlayer and tor-binary versions
Update dependencies to use tor v0.4.5.6
2021-02-26 17:20:01 +01:00
Christoph Atteneder
4051d196c2
Merge pull request #5245 from cd2357/update-netlayer-tor-binary-v0.4.5.6
Bump netlayer and tor-binary versions
2021-02-26 17:19:34 +01:00
sqrrm
11a1167b44
Merge pull request #5244 from ghubstan/001-adjust-apitest-for-grpc-client
Refactor apitest cases to use GrpcClient
2021-02-26 13:54:42 +01:00
sqrrm
acaa115355
Merge pull request #5240 from ghubstan/000-refactor-grpc-client
Refactor grpc stub boilerplate from CliMain to GrpcClient
2021-02-26 13:53:45 +01:00
sqrrm
b5793b59f4
Merge pull request #5238 from ghubstan/03-fix-settxfeerate-bug
Adjust api to new minimum fee per vbyte
2021-02-26 13:42:23 +01:00
sqrrm
8b70278174
Merge pull request #5203 from ghubstan/02-scripted-bot-test
Add CLI testing bot to :apitest
2021-02-26 13:31:39 +01:00
ghubstan
6c0eac8942
Fix param order 2021-02-26 08:24:16 -03:00