Commit graph

1855 commits

Author SHA1 Message Date
Christoph Atteneder
57bed13cf8
Merge pull request #4475 from chimp1984/fix-mobile-notification-bug
Fix bug with all mobile notifications for disputes are sent at startup.
2020-09-04 10:20:43 +02:00
Christoph Atteneder
d33b40128e
Merge pull request #4474 from chimp1984/stop-xmr-proof-service-at-dispute
Stop xmr proof service at dispute
2020-09-04 10:16:00 +02:00
Christoph Atteneder
2c39ded714
Merge pull request #4472 from chimp1984/update-about-view
Remove short cut info for removed key handlers
2020-09-04 10:12:53 +02:00
Christoph Atteneder
766d04588f
Merge pull request #4471 from chimp1984/add-setup-info-to-app-header
Add flags to header to signal which dev setup is used
2020-09-04 10:12:14 +02:00
chimp1984
6d37bedbbe
Fix bug with all mobile notifications for disputes are sent at startup. 2020-09-03 23:50:28 -05:00
chimp1984
a7e10155b1
Change hex color code to lower case 2020-09-03 21:22:54 -05:00
chimp1984
1016c73b35
Add null check. Improve text 2020-09-03 21:14:06 -05:00
chimp1984
6ab679c479
Adjust auto-conf css for badge
- make it xmr orange
- make with dynamic with 10 px padding left/right
- fix 1 px vertical offset
2020-09-03 21:02:16 -05:00
chimp1984
4e27b93acf
Show tx confidence indicator for XMR blocks. Show info icon 2020-09-03 20:51:19 -05:00
chimp1984
7cc021d7d6
Add monero orange color code for tx confidence indicator 2020-09-03 20:50:46 -05:00
chimp1984
023eb97f04
Change min required confirmations from 0 to 1.
If users accept visible in mempool only txs its their own risk and they
can manually confirm anyway. We should not support 0 conf txs.
2020-09-03 20:33:49 -05:00
chimp1984
b80082005c
Set default services based on localhost check not on devMode check 2020-09-03 19:15:42 -05:00
chimp1984
e74edc254a
Add check if dispute is open
If a mediation or arbitration dispute has been opened we do not use the
auto-confirm feature.
2020-09-03 15:38:47 -05:00
chimp1984
0434ba52b6
Refactor dependency structure to enable adding dispute managers
If we would add DisputeManager to previous structure it would cause a
circular dependency error from guice. We change dependency structure so
that TradeManager does not know XmrTxProofService but XmrTxProofService
gets an instance of TradeManager. It makes code cleaner in total as well
as responsibility is better defined.

Next commit will contain the DisputeManager addition.
2020-09-03 14:36:28 -05:00
chimp1984
d61aad66df
Add flags to header to signal which dev setup is used
Add to app header a post fix with info if Regtest or testnet,
LOCALHOST or DEV MODE is used.
At Mainnet without devmode nothing is added
2020-09-03 13:02:10 -05:00
chimp1984
7e17b181c9
Rmove short cut info for removed key handlers 2020-09-03 12:20:22 -05:00
chimp1984
341c5193ce
Add dontShowAgain button in osxKeyLoggerWarning window 2020-09-03 10:54:43 -05:00
chimp1984
b3d48deb39
Add getShowAccountUpdatesNotification which got deleted unintentionally
at merge.

We keep daoPresentation and accountPresentation support even it is
not used atm. But if we add a new feature and add a badge again it
will be needed.
2020-09-03 10:26:51 -05:00
Christoph Atteneder
77c7629478
Merge branch 'master' of github.com:bisq-network/bisq into add-xmr-tx-key-service-3
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/MainView.java
#	desktop/src/main/java/bisq/desktop/main/MainViewModel.java
2020-09-03 17:10:05 +02:00
Christoph Atteneder
3df94288b5
Merge pull request #4464 from chimp1984/show-popup-for-osx-key-logger-warning
Show popup about key-logger warning if OSX version is >= 10.14
2020-09-03 16:49:58 +02:00
Christoph Atteneder
5812103579
Merge pull request #4467 from chimp1984/remove-double-username-tf-in-revolut
Fix wrong label for account name when displaying revolut account
2020-09-03 16:48:58 +02:00
chimp1984
e496637b4b
Remove NewTradeProtocolLaunchWindow and badges for dao and account
Those have been added for 1.2 and are not new anymore.
2020-09-02 22:44:49 -05:00
chimp1984
59725f8a5f
Fix wrong label for account name when displaying revolut account 2020-09-02 22:10:03 -05:00
chimp1984
b17ee93b6f
Add listeners for filter change for shutdown all requests and
disable settings UI if auto-conf is disabled in filter.
2020-09-02 21:27:13 -05:00
chimp1984
842eeebe56
Show popup about key-logger warning if OSX version is >= 10.14
Tell user about the issue and instruct him how to change OS settings.
2020-09-02 10:26:33 -05:00
sqrrm
604dabbb46
Merge pull request #4461 from ghubstan/1-singleton-coreapi
Make CoreApi a singleton
2020-09-02 14:44:23 +02:00
Christoph Atteneder
095c8b5bdb
Merge pull request #4415 from sqrrm/dev-css
Add option to use different css for dev mode
2020-09-02 14:20:57 +02:00
Christoph Atteneder
a691eed223
Merge pull request #4455 from sqrrm/simplify-witness-signing
Simplify witness signing
2020-09-02 14:19:46 +02:00
chimp1984
a9e61e409e
Replace ObjectProperty<AssetTxProofResult> with IntegerProperty
// ObjectProperty with AssetTxProofResult does not notify changeListeners. Probably because AssetTxProofResult is
// an enum and enum does not support EqualsAndHashCode. Alternatively we could add a addListener and removeListener
// method and a listener interface, but the IntegerProperty seems to be less boilerplate.
2020-09-02 00:25:35 -05:00
chimp1984
a8968da23f
Add listener on autoConfirmSettings changes and terminate all services
if feature got disabled in setting.
2020-09-02 00:00:23 -05:00
chimp1984
320179f5ec
Improve handling of invalid/empty tx hash/tx key 2020-09-01 22:29:17 -05:00
chimp1984
7240bd62d1
Read numRequiredConfirmations from autoConfirmSettings just in time.
This allows the user to change required confirmation and it has impact
on open requests. Will be read at parsing the result.

Changed also the text field to not listen on text change but on focus
out so that the values are only updated once the user has left the
field and the value is valid. Otherwise small numbers like 1 might be
written during typing. The other values are only read at request start
and changes will have no impact on already started requests.

Also applies previous value in case the user added an invalid value at
focus out.

- Made display text shorter and added a tooltip.
- Allow very high numbers in devmode as max conf value
2020-09-01 21:22:16 -05:00
chimp1984
7c0d24c567
Refactoring: Rename package
bisq.core.trade.autoconf to bisq.core.trade.txproof
2020-09-01 19:56:48 -05:00
chimp1984
039860935d
Merge master
- fix tests
2020-09-01 19:53:23 -05:00
chimp1984
28c8150b6b
Refactoring
This is another larger refactoring, sorry ;-)

But the structure was just not correct before. We had handled multiple
trades with multiple results and that is error prone. Now each class
has much more clear responsibilities. Also the result enums are not
changes so that they are better separated between result based and
service bases states.

All different states are still hard to test. We should set up some mock
service to simulate confirmations counting up and error scenarios.
2020-09-01 19:10:43 -05:00
sqrrm
6e77ef08f0
Fix legit codacy complaints 2020-09-02 00:44:19 +02:00
sqrrm
f0acec0cb1
Add option to use different color header in dev mode
This is to help differentiate dev instances and live ones.
This can help devs avoiding silly mistakes.
2020-09-01 23:03:22 +02:00
chimp1984
512f1a5972
Refactor AutoConfirmSettings handling in preferences
- Do not use immutability for AutoConfirmSettings as it makes setting
values cumbersome.

- Add btc validator for trade limit

- Make AutoConfirmSettings an optional and add find method by currency
code to be better prepared when used for other coins.

- Add static getDefaultForXmr to AutoConfirmSettings

- Move listener creation to init method
2020-09-01 16:00:02 -05:00
Christoph Atteneder
7da3663e1d
Merge pull request #4457 from chimp1984/add-USDT-variants
Add Tether (ERC20, Omni and Liquid)
2020-09-01 20:04:57 +02:00
sqrrm
5b1d9cb759
Merge pull request #4453 from chimp1984/add-username-to-revolut
Add support for user name for Revolut accounts
2020-09-01 19:52:40 +02:00
sqrrm
7830dbf4e4
Merge pull request #4460 from chimp1984/refactor-filter
Refactor filter
2020-09-01 19:48:38 +02:00
ghubstan
804adf08a3
Remove commented code from BisqAppMain
Also fixed line length of a comment, and removed two extra white lines.
2020-09-01 11:03:18 -03:00
sqrrm
43ad831916
Merge pull request #4451 from chimp1984/add-check-for-option-trade
Add check for option trade
2020-09-01 11:12:59 +02:00
chimp1984
d36306a73c
More refactoring.... 2020-09-01 00:56:54 -05:00
chimp1984
4323b417b1
Adjust to codacy complaints
codacy does not like raw Exceptions ;-(

- Remove unused method
2020-08-31 19:36:19 -05:00
chimp1984
86999e52d1
- Remove isPublicKeyInList check at remove as its irrelevant (dev could
add his key anyway to src code)
- Fix wrong logs
- Remove duplicated line
2020-08-31 17:13:09 -05:00
chimp1984
8bf75b5f45
- Filter out prices with code "NON_EXISTING_SYMBOL"
- Add comments
2020-08-31 15:19:31 -05:00
chimp1984
b409c8add5
Merge branch 'master_upstream' into add-tether-pinguin 2020-08-31 14:17:59 -05:00
chimp1984
4a2f7dc92c
Rename bannedSignerPubKeys to bannedAccountWitnessSignerPubKeys
We use several signing keys, so better to make it more explicit.
protobuf entry is not changed to not risk issues (i guess it would
work renaming it)
2020-08-31 13:01:44 -05:00
chimp1984
9a142be86e
Add bannedPrivilegedDevPubKeys field 2020-08-31 12:51:01 -05:00